From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@fb.com>,
linux-mtd@lists.infradead.org, Tejun Heo <tj@kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mtd: export new mtd_mmap_capabilities
Date: Wed, 28 Jan 2015 17:55:36 +0100 [thread overview]
Message-ID: <20150128165536.GA17313@lst.de> (raw)
In-Reply-To: <1900951.4yX9yJNQM5@wuerfel>
On Wed, Jan 28, 2015 at 04:19:31PM +0100, Arnd Bergmann wrote:
> The recently added mtd_mmap_capabilities can be used from loadable
> modules, in particular romfs, but is not exported, so we get
>
> ERROR: "mtd_mmap_capabilities" [fs/romfs/romfs.ko] undefined!
>
> This adds the missing export.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b4caecd48005f ("fs: introduce f_op->mmap_capabilities for nommu mmap support")
Thanks, this looks fine to me:
Acked-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: export new mtd_mmap_capabilities
Date: Wed, 28 Jan 2015 17:55:36 +0100 [thread overview]
Message-ID: <20150128165536.GA17313@lst.de> (raw)
In-Reply-To: <1900951.4yX9yJNQM5@wuerfel>
On Wed, Jan 28, 2015 at 04:19:31PM +0100, Arnd Bergmann wrote:
> The recently added mtd_mmap_capabilities can be used from loadable
> modules, in particular romfs, but is not exported, so we get
>
> ERROR: "mtd_mmap_capabilities" [fs/romfs/romfs.ko] undefined!
>
> This adds the missing export.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b4caecd48005f ("fs: introduce f_op->mmap_capabilities for nommu mmap support")
Thanks, this looks fine to me:
Acked-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Christoph Hellwig <hch@lst.de>, Tejun Heo <tj@kernel.org>,
Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mtd: export new mtd_mmap_capabilities
Date: Wed, 28 Jan 2015 17:55:36 +0100 [thread overview]
Message-ID: <20150128165536.GA17313@lst.de> (raw)
In-Reply-To: <1900951.4yX9yJNQM5@wuerfel>
On Wed, Jan 28, 2015 at 04:19:31PM +0100, Arnd Bergmann wrote:
> The recently added mtd_mmap_capabilities can be used from loadable
> modules, in particular romfs, but is not exported, so we get
>
> ERROR: "mtd_mmap_capabilities" [fs/romfs/romfs.ko] undefined!
>
> This adds the missing export.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b4caecd48005f ("fs: introduce f_op->mmap_capabilities for nommu mmap support")
Thanks, this looks fine to me:
Acked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2015-01-28 16:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 15:19 [PATCH] mtd: export new mtd_mmap_capabilities Arnd Bergmann
2015-01-28 15:19 ` Arnd Bergmann
2015-01-28 15:19 ` Arnd Bergmann
2015-01-28 16:55 ` Christoph Hellwig [this message]
2015-01-28 16:55 ` Christoph Hellwig
2015-01-28 16:55 ` Christoph Hellwig
2015-01-28 18:05 ` Brian Norris
2015-01-28 18:05 ` Brian Norris
2015-01-28 18:05 ` Brian Norris
2015-01-28 18:09 ` Jens Axboe
2015-01-28 18:09 ` Jens Axboe
2015-01-28 18:09 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128165536.GA17313@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.