From: Dan Carpenter <dan.carpenter@oracle.com>
To: bskeggs@redhat.com
Cc: dri-devel@lists.freedesktop.org
Subject: re: drm/nouveau/devinit: move simple pll setting routines to devinit
Date: Wed, 28 Jan 2015 22:28:21 +0300 [thread overview]
Message-ID: <20150128192821.GA13560@mwanda> (raw)
[ Hm... That's weird. I don't know why this old bug is showing up in
my new bugs pile. Oh well, it looks valid. ]
Hello Ben Skeggs,
The patch 88524bc06926: "drm/nouveau/devinit: move simple pll setting
routines to devinit" from Mar 5, 2013, leads to the following static
checker warning:
drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv04.c:404 nv04_devinit_fini()
warn: impossible condition '(priv->owner < 0) => (0-255 < 0)'
drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv04.c
402
403 /* unslave crtcs */
404 if (priv->owner < 0)
^^^^^^^^^^^^^^^
This condition is never true. We could change the -1 in
nv04_devinit_ctor() to 0xff or make owner an int.
405 priv->owner = nv_rdvgaowner(priv);
406 nv_wrvgaowner(priv, 0);
407 return 0;
408 }
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
reply other threads:[~2015-01-28 19:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128192821.GA13560@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.