re: drm/nouveau/devinit: move simple pll setting routines to devinit

re: drm/nouveau/devinit: move simple pll setting routines to devinit

[Dan Carpenter]

[ Hm...  That's weird.  I don't know why this old bug is showing up in
  my new bugs pile.  Oh well, it looks valid. ]

Hello Ben Skeggs,

The patch 88524bc06926: "drm/nouveau/devinit: move simple pll setting
routines to devinit" from Mar 5, 2013, leads to the following static
checker warning:

	drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv04.c:404 nv04_devinit_fini()
	warn: impossible condition '(priv->owner < 0) => (0-255 < 0)'

drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv04.c
   402  
   403          /* unslave crtcs */
   404          if (priv->owner < 0)
                    ^^^^^^^^^^^^^^^
This condition is never true.  We could change the -1 in
nv04_devinit_ctor() to 0xff or make owner an int.

   405                  priv->owner = nv_rdvgaowner(priv);
   406          nv_wrvgaowner(priv, 0);
   407          return 0;
   408  }

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel