From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: grub-devel@gnu.org
Subject: Re: commit 3661261f breaks arm64
Date: Wed, 28 Jan 2015 21:58:56 +0300 [thread overview]
Message-ID: <20150128215856.4bc94ca7@opensuse.site> (raw)
In-Reply-To: <20150128183359.GG4278@bivouac.eciton.net>
В Wed, 28 Jan 2015 18:33:59 +0000
Leif Lindholm <leif.lindholm@linaro.org> пишет:
> commit 3661261fe17a8fe19681073889b5b36ec1ee823d,
> "Always add -msoft-float to avoid compiler generating float
> arithmetics." breaks the arm64 build.
>
> -msoft-float is not a valid command line option for aarch64 (as far as
> I can see, it is technically a target-specific option which just
> happens to exist for most targets - including arm).
>
> This setting will need to be conditionalised somehow.
> An option that works for arm64 is -march=armv8-a+nofp+nosimd.
>
> Would something like this be an acceptable workaround?:
>
> diff --git a/configure.ac b/configure.ac
> index a3bca06..c99e1ea 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -678,7 +678,11 @@ fi
> # that floats are a good fit to run instead of what's written in the
> # code.
> # Given that floating point unit is disabled (if present to begin
> # with)
> # when GRUB is running which may result in various hard crashes.
> -TARGET_CFLAGS="$TARGET_CFLAGS -msoft-float"
> +if ( test "x$target_cpu" = xarm64 ); then
Why subshell?
> + TARGET_CFLAGS="$TARGET_CFLAGS -march=armv8-a+nofp+nosimd"
> +else
> + TARGET_CFLAGS="$TARGET_CFLAGS -msoft-float"
> +fi
>
> # By default, GCC 4.4 generates .eh_frame sections containing unwind
> # information in some cases where it previously did not. GRUB doesn't
> # need
>
> /
> Leif
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2015-01-28 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 18:33 commit 3661261f breaks arm64 Leif Lindholm
2015-01-28 18:58 ` Andrei Borzenkov [this message]
2015-01-28 19:36 ` Leif Lindholm
2015-01-28 19:39 ` Vladimir 'phcoder' Serbinenko
2015-01-28 20:48 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128215856.4bc94ca7@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
--cc=leif.lindholm@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.