All of lore.kernel.org
 help / color / mirror / Atom feed
* re: csiostor:T5 Firmware fix and cleanup.
@ 2015-01-29 17:14 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-01-29 17:14 UTC (permalink / raw)
  To: kernel-janitors

Hello Praveen Madhavan,

The patch 216ce69c7ff5: "csiostor:T5 Firmware fix and cleanup." from
Jan 27, 2015, leads to the following static checker warning:

	drivers/scsi/csiostor/csio_hw.c:1780 csio_hw_use_fwconfig()
	warn: missing error code here? 'csio_hw_validate_caps()' failed.

drivers/scsi/csiostor/csio_hw.c
  1776          }
  1777  
  1778          /* Validate device capabilities */
  1779          if (csio_hw_validate_caps(hw, mbp))

We should probably preserve the error code here instead of returning
success.

  1780                  goto bye;
  1781          /*

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-01-29 17:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-29 17:14 csiostor:T5 Firmware fix and cleanup Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.