From: Samuel Ortiz <sameo@linux.intel.com>
To: clement.perrochaud@effinnov.com
Cc: linux-nfc@lists.01.org,
"Clément Perrochaud" <clement.perrochaud@nxp.com>,
sunil.jogi@nxp.com, jerome.pele@nxp.com,
Charles.Gorand-Effinnov@nxp.com, lauro.venancio@openbossa.org,
aloisio.almeida@openbossa.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
davem@davemloft.net, grant.likely@linaro.org,
lefrique@marvell.com, christophe.ricard@gmail.com,
cuissard@marvell.com, bzhao@marvell.com, hirent@marvell.com,
akarwar@marvell.com, linux-wireless@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] NFC: nxp-nci: Add support for NXP NCI chips
Date: Fri, 30 Jan 2015 01:10:48 +0100 [thread overview]
Message-ID: <20150130001048.GD20998@ribalta.ger.corp.intel.com> (raw)
In-Reply-To: <1421940460-14049-3-git-send-email-clement.perrochaud@effinnov.com>
Hi Clement,
On Thu, Jan 22, 2015 at 04:27:38PM +0100, clement.perrochaud@effinnov.com wrote:
> @@ -686,7 +686,7 @@ L: alsa-devel@alsa-project.org (moderated for non-subscribers)
> W: http://blackfin.uclinux.org/
> S: Supported
> F: sound/soc/blackfin/*
> -
> +
Unneeded change, please remove it.
> +config NFC_NXP_NCI
> + tristate "NXP-NCI NFC driver"
> + depends on NFC_NCI
> + default n
> + ---help---
> + Generic core driver for NXP NCI chips.
It usually is nice to be more specific and describe which chipsets
(e.g. NPC100) this driver supports among all the NXP NCI chipsets.
> +struct nxp_nci_phy_ops {
> + int (*enable)(void *id);
> + int (*fw_enable)(void *id);
Wouldn't a int (*enable)(void *id, enum nxp_nci_mode mode); hook be
enough ?
Cheers,
Samuel.
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: clement.perrochaud-BPEPtVrvniRWk0Htik3J/w@public.gmane.org
Cc: linux-nfc-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
"Clément Perrochaud"
<clement.perrochaud-3arQi8VN3Tc@public.gmane.org>,
sunil.jogi-3arQi8VN3Tc@public.gmane.org,
jerome.pele-3arQi8VN3Tc@public.gmane.org,
Charles.Gorand-Effinnov-3arQi8VN3Tc@public.gmane.org,
lauro.venancio-430g2QfJUUCGglJvpFV4uA@public.gmane.org,
aloisio.almeida-430g2QfJUUCGglJvpFV4uA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
lefrique-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org,
christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
cuissard-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org,
bzhao-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org,
hirent-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org,
akarwar-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/4] NFC: nxp-nci: Add support for NXP NCI chips
Date: Fri, 30 Jan 2015 01:10:48 +0100 [thread overview]
Message-ID: <20150130001048.GD20998@ribalta.ger.corp.intel.com> (raw)
In-Reply-To: <1421940460-14049-3-git-send-email-clement.perrochaud-BPEPtVrvniRWk0Htik3J/w@public.gmane.org>
Hi Clement,
On Thu, Jan 22, 2015 at 04:27:38PM +0100, clement.perrochaud-BPEPtVrvniRWk0Htik3J/w@public.gmane.org wrote:
> @@ -686,7 +686,7 @@ L: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org (moderated for non-subscribers)
> W: http://blackfin.uclinux.org/
> S: Supported
> F: sound/soc/blackfin/*
> -
> +
Unneeded change, please remove it.
> +config NFC_NXP_NCI
> + tristate "NXP-NCI NFC driver"
> + depends on NFC_NCI
> + default n
> + ---help---
> + Generic core driver for NXP NCI chips.
It usually is nice to be more specific and describe which chipsets
(e.g. NPC100) this driver supports among all the NXP NCI chipsets.
> +struct nxp_nci_phy_ops {
> + int (*enable)(void *id);
> + int (*fw_enable)(void *id);
Wouldn't a int (*enable)(void *id, enum nxp_nci_mode mode); hook be
enough ?
Cheers,
Samuel.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Ortiz <sameo@linux.intel.com>
To: clement.perrochaud@effinnov.com
Cc: linux-nfc@ml01.01.org,
"Clément Perrochaud" <clement.perrochaud@nxp.com>,
sunil.jogi@nxp.com, jerome.pele@nxp.com,
Charles.Gorand-Effinnov@nxp.com, lauro.venancio@openbossa.org,
aloisio.almeida@openbossa.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
davem@davemloft.net, grant.likely@linaro.org,
lefrique@marvell.com, christophe.ricard@gmail.com,
cuissard@marvell.com, bzhao@marvell.com, hirent@marvell.com,
akarwar@marvell.com, linux-wireless@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] NFC: nxp-nci: Add support for NXP NCI chips
Date: Fri, 30 Jan 2015 01:10:48 +0100 [thread overview]
Message-ID: <20150130001048.GD20998@ribalta.ger.corp.intel.com> (raw)
In-Reply-To: <1421940460-14049-3-git-send-email-clement.perrochaud@effinnov.com>
Hi Clement,
On Thu, Jan 22, 2015 at 04:27:38PM +0100, clement.perrochaud@effinnov.com wrote:
> @@ -686,7 +686,7 @@ L: alsa-devel@alsa-project.org (moderated for non-subscribers)
> W: http://blackfin.uclinux.org/
> S: Supported
> F: sound/soc/blackfin/*
> -
> +
Unneeded change, please remove it.
> +config NFC_NXP_NCI
> + tristate "NXP-NCI NFC driver"
> + depends on NFC_NCI
> + default n
> + ---help---
> + Generic core driver for NXP NCI chips.
It usually is nice to be more specific and describe which chipsets
(e.g. NPC100) this driver supports among all the NXP NCI chipsets.
> +struct nxp_nci_phy_ops {
> + int (*enable)(void *id);
> + int (*fw_enable)(void *id);
Wouldn't a int (*enable)(void *id, enum nxp_nci_mode mode); hook be
enough ?
Cheers,
Samuel.
next prev parent reply other threads:[~2015-01-30 0:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 15:27 [PATCH 0/4] NFC: nxp-nci: Add support for NXP-NCI NFC controllers clement.perrochaud
2015-01-22 15:27 ` clement.perrochaud
2015-01-22 15:27 ` clement.perrochaud-BPEPtVrvniRWk0Htik3J/w
2015-01-22 15:27 ` [PATCH 1/4] NFC: nci: Add FWDL support clement.perrochaud
2015-01-22 15:27 ` clement.perrochaud
2015-01-22 15:27 ` clement.perrochaud-BPEPtVrvniRWk0Htik3J/w
2015-01-29 23:28 ` Samuel Ortiz
2015-01-29 23:28 ` Samuel Ortiz
2015-03-09 10:26 ` Clément Perrochaud
2015-03-09 10:26 ` Clément Perrochaud
2015-01-22 15:27 ` [PATCH 2/4] NFC: nxp-nci: Add support for NXP NCI chips clement.perrochaud
2015-01-22 15:27 ` clement.perrochaud
2015-01-22 15:27 ` clement.perrochaud-BPEPtVrvniRWk0Htik3J/w
2015-01-30 0:10 ` Samuel Ortiz [this message]
2015-01-30 0:10 ` Samuel Ortiz
2015-01-30 0:10 ` Samuel Ortiz
2015-01-22 15:27 ` [PATCH 3/4] NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver clement.perrochaud
2015-01-22 15:27 ` clement.perrochaud
2015-01-22 15:27 ` clement.perrochaud-BPEPtVrvniRWk0Htik3J/w
2015-01-30 0:07 ` Samuel Ortiz
2015-01-30 0:07 ` Samuel Ortiz
2015-01-22 15:27 ` [PATCH 4/4] NFC: nxp-nci: Allow module removal during download clement.perrochaud
2015-01-22 15:27 ` clement.perrochaud
2015-01-22 15:27 ` clement.perrochaud-BPEPtVrvniRWk0Htik3J/w
2015-01-30 0:08 ` Samuel Ortiz
2015-01-30 0:08 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150130001048.GD20998@ribalta.ger.corp.intel.com \
--to=sameo@linux.intel.com \
--cc=Charles.Gorand-Effinnov@nxp.com \
--cc=akarwar@marvell.com \
--cc=aloisio.almeida@openbossa.org \
--cc=bzhao@marvell.com \
--cc=christophe.ricard@gmail.com \
--cc=clement.perrochaud@effinnov.com \
--cc=clement.perrochaud@nxp.com \
--cc=cuissard@marvell.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=hirent@marvell.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jerome.pele@nxp.com \
--cc=lauro.venancio@openbossa.org \
--cc=lefrique@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sunil.jogi@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.