All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Feng Kan <fkan-qTEPVZfXA3Y@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	patches <patches-qTEPVZfXA3Y@public.gmane.org>,
	jassisingbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Hieu Le <hnle-qTEPVZfXA3Y@public.gmane.org>
Subject: Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform
Date: Fri, 30 Jan 2015 07:11:18 +0100	[thread overview]
Message-ID: <20150130061118.GA995@katana> (raw)
In-Reply-To: <CAL85gmCuJtS2DMVHc96FtM_nP2++wMXNrrUp0Kvx0qajKsFuCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]


> > ctx->dev is probably the wrong device here. The i2c controller is not
> > DMA capable itself, you need to have a pointer to the device that actually
> > performs the DMA here.
> 
> Arnd, I do agree this may not be the best identification. There is no
> representation for this on the Linux side. I could put it as NULL. However,
> there are other i2c bus drivers that seem to do the same thing. Please
> let me know what you think.

For completeness: Those drivers need fixing!

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform
Date: Fri, 30 Jan 2015 07:11:18 +0100	[thread overview]
Message-ID: <20150130061118.GA995@katana> (raw)
In-Reply-To: <CAL85gmCuJtS2DMVHc96FtM_nP2++wMXNrrUp0Kvx0qajKsFuCw@mail.gmail.com>


> > ctx->dev is probably the wrong device here. The i2c controller is not
> > DMA capable itself, you need to have a pointer to the device that actually
> > performs the DMA here.
> 
> Arnd, I do agree this may not be the best identification. There is no
> representation for this on the Linux side. I could put it as NULL. However,
> there are other i2c bus drivers that seem to do the same thing. Please
> let me know what you think.

For completeness: Those drivers need fixing!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150130/41b913cb/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Feng Kan <fkan@apm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>, patches <patches@apm.com>,
	jassisingbrar@gmail.com, linux-i2c@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Hieu Le <hnle@apm.com>
Subject: Re: [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform
Date: Fri, 30 Jan 2015 07:11:18 +0100	[thread overview]
Message-ID: <20150130061118.GA995@katana> (raw)
In-Reply-To: <CAL85gmCuJtS2DMVHc96FtM_nP2++wMXNrrUp0Kvx0qajKsFuCw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]


> > ctx->dev is probably the wrong device here. The i2c controller is not
> > DMA capable itself, you need to have a pointer to the device that actually
> > performs the DMA here.
> 
> Arnd, I do agree this may not be the best identification. There is no
> representation for this on the Linux side. I could put it as NULL. However,
> there are other i2c bus drivers that seem to do the same thing. Please
> let me know what you think.

For completeness: Those drivers need fixing!

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-01-30  6:11 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08  0:06 [PATCH 0/6] APM X-Gene platform mailbox and proxy i2c driver Feng Kan
2014-10-08  0:06 ` Feng Kan
2014-10-08  0:06 ` [PATCH 1/6] mailbox: add support for APM X-Gene platform mailbox driver Feng Kan
2014-10-08  0:06   ` Feng Kan
2014-10-08  0:06 ` [PATCH 2/6] Documentation: mailbox: Add APM X-Gene SLIMpro mailbox dts documentation Feng Kan
2014-10-08  0:06   ` Feng Kan
     [not found]   ` <1412726809-7525-3-git-send-email-fkan-qTEPVZfXA3Y@public.gmane.org>
2014-10-08  9:50     ` Mark Rutland
2014-10-08  9:50       ` Mark Rutland
2014-10-08  9:50       ` Mark Rutland
     [not found] ` <1412726809-7525-1-git-send-email-fkan-qTEPVZfXA3Y@public.gmane.org>
2014-10-08  0:06   ` [PATCH 3/6] arm64: dts: mailbox device tree node for APM X-Gene platform Feng Kan
2014-10-08  0:06     ` Feng Kan
2014-10-08  0:06     ` Feng Kan
2014-10-08  0:06 ` [PATCH 4/6] i2c: busses: add SLIMpro I2C device driver on " Feng Kan
2014-10-08  0:06   ` Feng Kan
2014-11-11 20:32   ` Wolfram Sang
2014-11-11 20:32     ` Wolfram Sang
2014-11-17 23:39     ` Feng Kan
2014-11-17 23:39       ` Feng Kan
2015-01-09 18:52     ` Feng Kan
2015-01-09 18:52       ` Feng Kan
     [not found]       ` <CAL85gmB172hgTCHUQ=sshAAYjOwpNKc=YdovjfTFXfnW7LJTLQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-09 20:42         ` Wolfram Sang
2015-01-09 20:42           ` Wolfram Sang
2015-01-09 20:42           ` Wolfram Sang
     [not found]   ` <1412726809-7525-5-git-send-email-fkan-qTEPVZfXA3Y@public.gmane.org>
2014-11-11 21:51     ` Arnd Bergmann
2014-11-11 21:51       ` Arnd Bergmann
2014-11-11 21:51       ` Arnd Bergmann
2015-01-09 18:56       ` Feng Kan
2015-01-09 18:56         ` Feng Kan
     [not found]         ` <CAL85gmCOXKiHEO=URrAGBNZpJpen5P5PH1xDoF1-jasj0iDg4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-09 19:42           ` Arnd Bergmann
2015-01-09 19:42             ` Arnd Bergmann
2015-01-09 19:42             ` Arnd Bergmann
2015-01-30  1:07       ` Feng Kan
2015-01-30  1:07         ` Feng Kan
2015-01-30  1:07         ` Feng Kan
     [not found]         ` <CAL85gmCuJtS2DMVHc96FtM_nP2++wMXNrrUp0Kvx0qajKsFuCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-30  6:11           ` Wolfram Sang [this message]
2015-01-30  6:11             ` Wolfram Sang
2015-01-30  6:11             ` Wolfram Sang
2015-02-02 22:15             ` Feng Kan
2015-02-02 22:15               ` Feng Kan
2015-02-02 22:15               ` Feng Kan
     [not found]               ` <CAL85gmD+0cJfZoWo8ujmjwy9yaKjNPjJaUm00Vrv5o9kcg-ozA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-02 23:16                 ` Wolfram Sang
2015-02-02 23:16                   ` Wolfram Sang
2015-02-02 23:16                   ` Wolfram Sang
2014-10-08  0:06 ` [PATCH 5/6] Documentation: i2c: Add APM X-Gene platform SLIMpro I2C driver documentation Feng Kan
2014-10-08  0:06   ` Feng Kan
     [not found]   ` <1412726809-7525-6-git-send-email-fkan-qTEPVZfXA3Y@public.gmane.org>
2014-10-08 10:11     ` Mark Rutland
2014-10-08 10:11       ` Mark Rutland
2014-10-08 10:11       ` Mark Rutland
2014-11-11 21:40     ` Arnd Bergmann
2014-11-11 21:40       ` Arnd Bergmann
2014-11-11 21:40       ` Arnd Bergmann
2014-10-08  0:06 ` [PATCH 6/6] arm64: dts: add proxy I2C device driver on APM X-Gene platform Feng Kan
2014-10-08  0:06   ` Feng Kan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150130061118.GA995@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=fkan-qTEPVZfXA3Y@public.gmane.org \
    --cc=hnle-qTEPVZfXA3Y@public.gmane.org \
    --cc=jassisingbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=patches-qTEPVZfXA3Y@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.