From: mgorman@suse.de (Mel Gorman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/mm: fix compiler warning in pmdp_invalidate() (in -next)
Date: Fri, 30 Jan 2015 10:06:20 +0000 [thread overview]
Message-ID: <20150130100620.GL2395@suse.de> (raw)
In-Reply-To: <1422553680-25374-1-git-send-email-andre.przywara@arm.com>
On Thu, Jan 29, 2015 at 05:48:00PM +0000, Andre Przywara wrote:
> Commit ff61d185f4e7 ("mm: convert p[te|md]_mknonnuma and remaining
> page table manipulations") removed a check in
> mm/pgtable-generic.c:pmdp_invalidate(), which leaves the
> pmd_mknotpresent macro the only user of the entry variable.
> For ARM/LPAE we use a constant 0 without referencing the argument to
> mark this condition, so the entry variable is no longer used here:
>
> mm/pgtable-generic.c: In function 'pmdp_invalidate':
> mm/pgtable-generic.c:195:8: warning: unused variable 'entry' [-Wunused-variable]
> pmd_t entry = *pmdp;
> ^
>
> Replace the ARM macro implementation with a static inline function to
> get rid of this warning.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Patch looks fine to me but this is against a mmotm patch that is
included in mmotm. The commit ID is not going to last. This should be
sent to Andrew Morton with a note saying it's a fix to the mmotm patch
mm-convert-p_mknonnuma-and-remaining-page-table-manipulations.patch .
He'll then fold your fix into the original patch so that bisection works
correctly when merged to mainline. Do you mind doing that please?
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Andre Przywara <andre.przywara@arm.com>
Cc: catalin.marinas@arm.com, rmk+kernel@arm.linux.org.uk,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm/mm: fix compiler warning in pmdp_invalidate() (in -next)
Date: Fri, 30 Jan 2015 10:06:20 +0000 [thread overview]
Message-ID: <20150130100620.GL2395@suse.de> (raw)
In-Reply-To: <1422553680-25374-1-git-send-email-andre.przywara@arm.com>
On Thu, Jan 29, 2015 at 05:48:00PM +0000, Andre Przywara wrote:
> Commit ff61d185f4e7 ("mm: convert p[te|md]_mknonnuma and remaining
> page table manipulations") removed a check in
> mm/pgtable-generic.c:pmdp_invalidate(), which leaves the
> pmd_mknotpresent macro the only user of the entry variable.
> For ARM/LPAE we use a constant 0 without referencing the argument to
> mark this condition, so the entry variable is no longer used here:
>
> mm/pgtable-generic.c: In function 'pmdp_invalidate':
> mm/pgtable-generic.c:195:8: warning: unused variable 'entry' [-Wunused-variable]
> pmd_t entry = *pmdp;
> ^
>
> Replace the ARM macro implementation with a static inline function to
> get rid of this warning.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Patch looks fine to me but this is against a mmotm patch that is
included in mmotm. The commit ID is not going to last. This should be
sent to Andrew Morton with a note saying it's a fix to the mmotm patch
mm-convert-p_mknonnuma-and-remaining-page-table-manipulations.patch .
He'll then fold your fix into the original patch so that bisection works
correctly when merged to mainline. Do you mind doing that please?
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2015-01-30 10:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 17:48 [PATCH] arm/mm: fix compiler warning in pmdp_invalidate() (in -next) Andre Przywara
2015-01-29 17:48 ` Andre Przywara
2015-01-30 10:06 ` Mel Gorman [this message]
2015-01-30 10:06 ` Mel Gorman
2015-01-30 16:37 ` Andre Przywara
2015-01-30 16:37 ` Andre Przywara
2015-01-30 16:40 ` Russell King - ARM Linux
2015-01-30 16:40 ` Russell King - ARM Linux
2015-02-11 22:06 ` Andrew Morton
2015-02-11 22:06 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150130100620.GL2395@suse.de \
--to=mgorman@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.