* Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed [not found] <1422705282-17374-1-git-send-email-varsharamt91@gmail.com> @ 2015-01-31 16:29 ` Greg KH 0 siblings, 0 replies; 8+ messages in thread From: Greg KH @ 2015-01-31 16:29 UTC (permalink / raw) To: varsharamt Cc: jak-4HMq4SXA452hPH1hqNUYSQ, marvin24-Mmb7MZpHnFY, ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt, linux-tegra-u79uwXL29TY76Z2rM5mHXA, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote: > The task was to fix a warning which was shown while compiling a driver > called NVEC. I wrote a brief description about how to enable support for > a nVidya complaint embedded controller. This makes no sense, what "task"? > Signed-off-by:Varsha Ram T<varsharamt91-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Please use proper spaces. Also, this doesn't match your From: line. And, is this the name you use to sign legal documents? > --- > drivers/staging/nvec/Kconfig | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/nvec/Kconfig b/drivers/staging/nvec/Kconfig > index 9475e20..a65ad4c 100644 > --- a/drivers/staging/nvec/Kconfig > +++ b/drivers/staging/nvec/Kconfig > @@ -3,33 +3,33 @@ config MFD_NVEC > depends on I2C && GPIOLIB && ARCH_TEGRA > select MFD_CORE > help > - Say Y here to enable support for a nVidia compliant embedded > - controller. > + Say Y to enable support for a nVidia complaint embedded controller. > + nVidia complaint embedded controller is used to communicate with EC. > + This is done through I2C bus. > + The request to the EC can be initiated by triggering a gpio line. > + The gpio line is a generic pin on integrated circuit whose input or output pin can be controlled by the user at run time. There's no way this is correct, look at how long your line is. > > config KEYBOARD_NVEC > tristate "Keyboard on nVidia compliant EC" > depends on MFD_NVEC && INPUT > help > - Say Y here to enable support for a keyboard connected to > - a nVidia compliant embedded controller. > + Say Y here to enable support for a keyboard connected to a nVidia compliant embedded controller. Why did you change these lines and the rest of the lines in this patch? thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed @ 2015-01-31 16:29 ` Greg KH 0 siblings, 0 replies; 8+ messages in thread From: Greg KH @ 2015-01-31 16:29 UTC (permalink / raw) To: varsharamt; +Cc: jak, marvin24, ac100, linux-tegra, devel, linux-kernel On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote: > The task was to fix a warning which was shown while compiling a driver > called NVEC. I wrote a brief description about how to enable support for > a nVidya complaint embedded controller. This makes no sense, what "task"? > Signed-off-by:Varsha Ram T<varsharamt91@gmail.com> Please use proper spaces. Also, this doesn't match your From: line. And, is this the name you use to sign legal documents? > --- > drivers/staging/nvec/Kconfig | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/nvec/Kconfig b/drivers/staging/nvec/Kconfig > index 9475e20..a65ad4c 100644 > --- a/drivers/staging/nvec/Kconfig > +++ b/drivers/staging/nvec/Kconfig > @@ -3,33 +3,33 @@ config MFD_NVEC > depends on I2C && GPIOLIB && ARCH_TEGRA > select MFD_CORE > help > - Say Y here to enable support for a nVidia compliant embedded > - controller. > + Say Y to enable support for a nVidia complaint embedded controller. > + nVidia complaint embedded controller is used to communicate with EC. > + This is done through I2C bus. > + The request to the EC can be initiated by triggering a gpio line. > + The gpio line is a generic pin on integrated circuit whose input or output pin can be controlled by the user at run time. There's no way this is correct, look at how long your line is. > > config KEYBOARD_NVEC > tristate "Keyboard on nVidia compliant EC" > depends on MFD_NVEC && INPUT > help > - Say Y here to enable support for a keyboard connected to > - a nVidia compliant embedded controller. > + Say Y here to enable support for a keyboard connected to a nVidia compliant embedded controller. Why did you change these lines and the rest of the lines in this patch? thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20150131162913.GA23688-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed 2015-01-31 16:29 ` Greg KH @ 2015-01-31 19:11 ` Julian Andres Klode -1 siblings, 0 replies; 8+ messages in thread From: Julian Andres Klode @ 2015-01-31 19:11 UTC (permalink / raw) To: Greg KH Cc: varsharamt, marvin24-Mmb7MZpHnFY, ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt, linux-tegra-u79uwXL29TY76Z2rM5mHXA, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 31 January 2015 at 17:29, Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> wrote: > On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote: >> The task was to fix a warning which was shown while compiling a driver >> called NVEC. I wrote a brief description about how to enable support for >> a nVidya complaint embedded controller. > > This makes no sense, what "task"? > >> Signed-off-by:Varsha Ram T<varsharamt91-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Please use proper spaces. > > Also, this doesn't match your From: line. And, is this the name you use > to sign legal documents? > > >> --- >> drivers/staging/nvec/Kconfig | 20 ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/staging/nvec/Kconfig b/drivers/staging/nvec/Kconfig >> index 9475e20..a65ad4c 100644 >> --- a/drivers/staging/nvec/Kconfig >> +++ b/drivers/staging/nvec/Kconfig >> @@ -3,33 +3,33 @@ config MFD_NVEC >> depends on I2C && GPIOLIB && ARCH_TEGRA >> select MFD_CORE >> help >> - Say Y here to enable support for a nVidia compliant embedded >> - controller. >> + Say Y to enable support for a nVidia complaint embedded controller. >> + nVidia complaint embedded controller is used to communicate with EC. >> + This is done through I2C bus. >> + The request to the EC can be initiated by triggering a gpio line. >> + The gpio line is a generic pin on integrated circuit whose input or output pin can be controlled by the user at run time. > > > There's no way this is correct, look at how long your line is. > I'm not even sure if this level of detail is needed. Why should anyone that reads the config option care how NVEC is enabled or communicated with? -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed @ 2015-01-31 19:11 ` Julian Andres Klode 0 siblings, 0 replies; 8+ messages in thread From: Julian Andres Klode @ 2015-01-31 19:11 UTC (permalink / raw) To: Greg KH; +Cc: varsharamt, marvin24, ac100, linux-tegra, devel, linux-kernel On 31 January 2015 at 17:29, Greg KH <gregkh@linuxfoundation.org> wrote: > On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote: >> The task was to fix a warning which was shown while compiling a driver >> called NVEC. I wrote a brief description about how to enable support for >> a nVidya complaint embedded controller. > > This makes no sense, what "task"? > >> Signed-off-by:Varsha Ram T<varsharamt91@gmail.com> > > Please use proper spaces. > > Also, this doesn't match your From: line. And, is this the name you use > to sign legal documents? > > >> --- >> drivers/staging/nvec/Kconfig | 20 ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/staging/nvec/Kconfig b/drivers/staging/nvec/Kconfig >> index 9475e20..a65ad4c 100644 >> --- a/drivers/staging/nvec/Kconfig >> +++ b/drivers/staging/nvec/Kconfig >> @@ -3,33 +3,33 @@ config MFD_NVEC >> depends on I2C && GPIOLIB && ARCH_TEGRA >> select MFD_CORE >> help >> - Say Y here to enable support for a nVidia compliant embedded >> - controller. >> + Say Y to enable support for a nVidia complaint embedded controller. >> + nVidia complaint embedded controller is used to communicate with EC. >> + This is done through I2C bus. >> + The request to the EC can be initiated by triggering a gpio line. >> + The gpio line is a generic pin on integrated circuit whose input or output pin can be controlled by the user at run time. > > > There's no way this is correct, look at how long your line is. > I'm not even sure if this level of detail is needed. Why should anyone that reads the config option care how NVEC is enabled or communicated with? -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Warning that occured while compiling the nvec in3.19.0-rc5+ is fixed 2015-01-31 19:11 ` Julian Andres Klode @ 2015-01-31 20:22 ` Marc Dietrich -1 siblings, 0 replies; 8+ messages in thread From: Marc Dietrich @ 2015-01-31 20:22 UTC (permalink / raw) To: Julian Andres Klode Cc: Greg KH, varsharamt, ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt, linux-tegra-u79uwXL29TY76Z2rM5mHXA, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b, linux-kernel-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 2271 bytes --] Am Samstag 31 Januar 2015, 20:11:29 schrieb Julian Andres Klode: > On 31 January 2015 at 17:29, Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> wrote: > > On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote: > >> The task was to fix a warning which was shown while compiling a driver > >> called NVEC. I wrote a brief description about how to enable support for > >> a nVidya complaint embedded controller. > > > > This makes no sense, what "task"? > > > >> Signed-off-by:Varsha Ram T<varsharamt91-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > > > Please use proper spaces. > > > > Also, this doesn't match your From: line. And, is this the name you use > > to sign legal documents? > > > >> --- > >> > >> drivers/staging/nvec/Kconfig | 20 ++++++++++---------- > >> 1 file changed, 10 insertions(+), 10 deletions(-) > >> > >> diff --git a/drivers/staging/nvec/Kconfig b/drivers/staging/nvec/Kconfig > >> index 9475e20..a65ad4c 100644 > >> --- a/drivers/staging/nvec/Kconfig > >> +++ b/drivers/staging/nvec/Kconfig > >> @@ -3,33 +3,33 @@ config MFD_NVEC > >> > >> depends on I2C && GPIOLIB && ARCH_TEGRA > >> select MFD_CORE > >> help > >> > >> - Say Y here to enable support for a nVidia compliant embedded > >> - controller. > >> + Say Y to enable support for a nVidia complaint embedded controller. > >> + nVidia complaint embedded controller is used to communicate with > >> EC. > >> + This is done through I2C bus. > >> + The request to the EC can be initiated by triggering a gpio line. > >> + The gpio line is a generic pin on integrated circuit whose input or > >> output pin can be controlled by the user at run time.> > > There's no way this is correct, look at how long your line is. > > I'm not even sure if this level of detail is needed. Why should anyone > that reads the config option care how NVEC is enabled or communicated > with? I didn't received the original mail, but I think this is related to a checkpatch warning which demands at least *three* lines of help text (we only have two). While the sense of such requirement is discussable, blowing up an already complete help text just to avoid a checkpatch warning doesn't make much sense to me. Marc [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Warning that occured while compiling the nvec in3.19.0-rc5+ is fixed @ 2015-01-31 20:22 ` Marc Dietrich 0 siblings, 0 replies; 8+ messages in thread From: Marc Dietrich @ 2015-01-31 20:22 UTC (permalink / raw) To: Julian Andres Klode Cc: Greg KH, varsharamt, ac100, linux-tegra, devel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 2211 bytes --] Am Samstag 31 Januar 2015, 20:11:29 schrieb Julian Andres Klode: > On 31 January 2015 at 17:29, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote: > >> The task was to fix a warning which was shown while compiling a driver > >> called NVEC. I wrote a brief description about how to enable support for > >> a nVidya complaint embedded controller. > > > > This makes no sense, what "task"? > > > >> Signed-off-by:Varsha Ram T<varsharamt91@gmail.com> > > > > Please use proper spaces. > > > > Also, this doesn't match your From: line. And, is this the name you use > > to sign legal documents? > > > >> --- > >> > >> drivers/staging/nvec/Kconfig | 20 ++++++++++---------- > >> 1 file changed, 10 insertions(+), 10 deletions(-) > >> > >> diff --git a/drivers/staging/nvec/Kconfig b/drivers/staging/nvec/Kconfig > >> index 9475e20..a65ad4c 100644 > >> --- a/drivers/staging/nvec/Kconfig > >> +++ b/drivers/staging/nvec/Kconfig > >> @@ -3,33 +3,33 @@ config MFD_NVEC > >> > >> depends on I2C && GPIOLIB && ARCH_TEGRA > >> select MFD_CORE > >> help > >> > >> - Say Y here to enable support for a nVidia compliant embedded > >> - controller. > >> + Say Y to enable support for a nVidia complaint embedded controller. > >> + nVidia complaint embedded controller is used to communicate with > >> EC. > >> + This is done through I2C bus. > >> + The request to the EC can be initiated by triggering a gpio line. > >> + The gpio line is a generic pin on integrated circuit whose input or > >> output pin can be controlled by the user at run time.> > > There's no way this is correct, look at how long your line is. > > I'm not even sure if this level of detail is needed. Why should anyone > that reads the config option care how NVEC is enabled or communicated > with? I didn't received the original mail, but I think this is related to a checkpatch warning which demands at least *three* lines of help text (we only have two). While the sense of such requirement is discussable, blowing up an already complete help text just to avoid a checkpatch warning doesn't make much sense to me. Marc [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed 2015-01-31 16:29 ` Greg KH @ 2015-02-02 17:08 ` Stephen Warren -1 siblings, 0 replies; 8+ messages in thread From: Stephen Warren @ 2015-02-02 17:08 UTC (permalink / raw) To: Greg KH, varsharamt Cc: jak-4HMq4SXA452hPH1hqNUYSQ, marvin24-Mmb7MZpHnFY, ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt, linux-tegra-u79uwXL29TY76Z2rM5mHXA, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote: > The task was to fix a warning which was shown while compiling a driver > called NVEC. I wrote a brief description about how to enable support for > a nVidya complaint embedded controller. Please note that NVIDIA is spelled/capitalized as NVIDIA. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed @ 2015-02-02 17:08 ` Stephen Warren 0 siblings, 0 replies; 8+ messages in thread From: Stephen Warren @ 2015-02-02 17:08 UTC (permalink / raw) To: Greg KH, varsharamt Cc: jak, marvin24, ac100, linux-tegra, devel, linux-kernel On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote: > The task was to fix a warning which was shown while compiling a driver > called NVEC. I wrote a brief description about how to enable support for > a nVidya complaint embedded controller. Please note that NVIDIA is spelled/capitalized as NVIDIA. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-02-02 17:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1422705282-17374-1-git-send-email-varsharamt91@gmail.com>
[not found] ` <1422705282-17374-1-git-send-email-varsharamt91-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-31 16:29 ` [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed Greg KH
2015-01-31 16:29 ` Greg KH
[not found] ` <20150131162913.GA23688-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-01-31 19:11 ` Julian Andres Klode
2015-01-31 19:11 ` Julian Andres Klode
2015-01-31 20:22 ` [PATCH] Warning that occured while compiling the nvec in3.19.0-rc5+ " Marc Dietrich
2015-01-31 20:22 ` Marc Dietrich
2015-02-02 17:08 ` [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ " Stephen Warren
2015-02-02 17:08 ` Stephen Warren
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.