From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Bhuvanchandra DV
<bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
stefan-XLVq0VzYD2Y@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: fsl-dspi: Remove possible memory leak of 'chip'
Date: Sat, 31 Jan 2015 19:46:48 +0300 [thread overview]
Message-ID: <20150131164648.GR6507@mwanda> (raw)
In-Reply-To: <1422722005-1616-1-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
On Sat, Jan 31, 2015 at 10:03:25PM +0530, Bhuvanchandra DV wrote:
> Move the check for spi->bits_per_word
> before allocation, to avoid memory leak.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Normally, you would give me a Reported-by: tag. Not a big deal either
way.
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Cc: broonie@kernel.org, stefan@agner.ch, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: fsl-dspi: Remove possible memory leak of 'chip'
Date: Sat, 31 Jan 2015 19:46:48 +0300 [thread overview]
Message-ID: <20150131164648.GR6507@mwanda> (raw)
In-Reply-To: <1422722005-1616-1-git-send-email-bhuvanchandra.dv@toradex.com>
On Sat, Jan 31, 2015 at 10:03:25PM +0530, Bhuvanchandra DV wrote:
> Move the check for spi->bits_per_word
> before allocation, to avoid memory leak.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Normally, you would give me a Reported-by: tag. Not a big deal either
way.
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
regards,
dan carpenter
next prev parent reply other threads:[~2015-01-31 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 16:33 [PATCH] spi: fsl-dspi: Remove possible memory leak of 'chip' Bhuvanchandra DV
2015-01-31 16:33 ` Bhuvanchandra DV
[not found] ` <1422722005-1616-1-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2015-01-31 16:46 ` Dan Carpenter [this message]
2015-01-31 16:46 ` Dan Carpenter
2015-02-02 20:23 ` Mark Brown
2015-02-02 20:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150131164648.GR6507@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.