From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Semen Protsenko <semen.protsenko@globallogic.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf
Date: Mon, 2 Feb 2015 09:08:27 -0800 [thread overview]
Message-ID: <20150202170827.GD9418@atomide.com> (raw)
In-Reply-To: <54C60A3A.1090008@ti.com>
* Roger Quadros <rogerq@ti.com> [150126 01:38]:
> On 24/01/15 22:28, Semen Protsenko wrote:
> > Some GPMC_CONFIG7 register bits marked as "RESERVED", means they
> > shouldn't be overwritten. A typical approach to handle such bits called
> > "Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf()
> > utilizes RMW technique, but implemented incorrectly. Due to obvious typo
> > in code read register value is being rewritten by another value, which
> > leads to loss of read RESERVED bits. This patch fixes this.
> >
> > While at it, replace magic numbers with named constants to improve code
> > readability.
> >
> > Signed-off-by: Semen Protsenko <semen.protsenko@globallogic.com>
>
> This is much nicer.
>
> Acked-by: Roger Quadros <rogerq@ti.com>
Roger will queue this so:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2015-02-02 17:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-24 20:28 [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf Semen Protsenko
2015-01-24 20:28 ` [PATCH 2/3] ARM: OMAP2+: gpmc: make gpmc_cs_get_name() static Semen Protsenko
2015-01-26 9:20 ` Roger Quadros
2015-01-26 9:20 ` Roger Quadros
2015-02-02 17:07 ` Tony Lindgren
2015-01-24 20:28 ` [PATCH 3/3] ARM: OMAP2+: gpmc: Do not modify LIMITEDADDRESS on new architectures Semen Protsenko
2015-01-26 9:50 ` Roger Quadros
2015-01-26 9:50 ` Roger Quadros
2015-01-26 13:07 ` Sam Protsenko
2015-01-26 15:46 ` Roger Quadros
2015-01-26 15:46 ` Roger Quadros
2015-01-26 9:34 ` [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf Roger Quadros
2015-01-26 9:34 ` Roger Quadros
2015-02-02 17:08 ` Tony Lindgren [this message]
2015-02-03 9:30 ` Roger Quadros
2015-02-03 9:30 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202170827.GD9418@atomide.com \
--to=tony@atomide.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=semen.protsenko@globallogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.