From: Roger Quadros <rogerq@ti.com>
To: Semen Protsenko <semen.protsenko@globallogic.com>,
Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: OMAP2+: gpmc: make gpmc_cs_get_name() static
Date: Mon, 26 Jan 2015 11:20:24 +0200 [thread overview]
Message-ID: <54C606D8.4080904@ti.com> (raw)
In-Reply-To: <1422131320-1018-2-git-send-email-semen.protsenko@globallogic.com>
On 24/01/15 22:28, Semen Protsenko wrote:
> Fix sparse warning:
> warning: symbol 'gpmc_cs_get_name' was not declared. Should it be static?
>
> Signed-off-by: Semen Protsenko <semen.protsenko@globallogic.com>
Acked-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
> ---
> drivers/memory/omap-gpmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index 10eb4ac..db77adb 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -668,7 +668,7 @@ static void gpmc_cs_set_name(int cs, const char *name)
> gpmc->name = name;
> }
>
> -const char *gpmc_cs_get_name(int cs)
> +static const char *gpmc_cs_get_name(int cs)
> {
> struct gpmc_cs_data *gpmc = &gpmc_cs[cs];
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Semen Protsenko <semen.protsenko@globallogic.com>,
Tony Lindgren <tony@atomide.com>
Cc: <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] ARM: OMAP2+: gpmc: make gpmc_cs_get_name() static
Date: Mon, 26 Jan 2015 11:20:24 +0200 [thread overview]
Message-ID: <54C606D8.4080904@ti.com> (raw)
In-Reply-To: <1422131320-1018-2-git-send-email-semen.protsenko@globallogic.com>
On 24/01/15 22:28, Semen Protsenko wrote:
> Fix sparse warning:
> warning: symbol 'gpmc_cs_get_name' was not declared. Should it be static?
>
> Signed-off-by: Semen Protsenko <semen.protsenko@globallogic.com>
Acked-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
> ---
> drivers/memory/omap-gpmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index 10eb4ac..db77adb 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -668,7 +668,7 @@ static void gpmc_cs_set_name(int cs, const char *name)
> gpmc->name = name;
> }
>
> -const char *gpmc_cs_get_name(int cs)
> +static const char *gpmc_cs_get_name(int cs)
> {
> struct gpmc_cs_data *gpmc = &gpmc_cs[cs];
>
>
next prev parent reply other threads:[~2015-01-26 9:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-24 20:28 [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf Semen Protsenko
2015-01-24 20:28 ` [PATCH 2/3] ARM: OMAP2+: gpmc: make gpmc_cs_get_name() static Semen Protsenko
2015-01-26 9:20 ` Roger Quadros [this message]
2015-01-26 9:20 ` Roger Quadros
2015-02-02 17:07 ` Tony Lindgren
2015-01-24 20:28 ` [PATCH 3/3] ARM: OMAP2+: gpmc: Do not modify LIMITEDADDRESS on new architectures Semen Protsenko
2015-01-26 9:50 ` Roger Quadros
2015-01-26 9:50 ` Roger Quadros
2015-01-26 13:07 ` Sam Protsenko
2015-01-26 15:46 ` Roger Quadros
2015-01-26 15:46 ` Roger Quadros
2015-01-26 9:34 ` [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf Roger Quadros
2015-01-26 9:34 ` Roger Quadros
2015-02-02 17:08 ` Tony Lindgren
2015-02-03 9:30 ` Roger Quadros
2015-02-03 9:30 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C606D8.4080904@ti.com \
--to=rogerq@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=semen.protsenko@globallogic.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.