From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>,
Peter Hutterer <peter.hutterer@who-t.net>,
linux-input <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: MT - Add support for balanced slot assignment
Date: Mon, 2 Feb 2015 09:12:57 -0800 [thread overview]
Message-ID: <20150202171257.GA23909@dtor-ws> (raw)
In-Reply-To: <20150202153253.GA8608@mail.corp.redhat.com>
On Mon, Feb 02, 2015 at 10:32:53AM -0500, Benjamin Tissoires wrote:
> On Feb 01 2015 or thereabouts, Henrik Rydberg wrote:
> > Hi Benjamin,
> >
> > > Tested this morning, and yes, it solves the problem.
> > > I assumed that the dmax was in mm, and used "10 * priv->x_res", which
> > > seemed to do the trick:
> > > - tapping with two fingers side by side triggered the jumps
> > > - in the general case (switching from the index to the thumb to
> > > click), the jumps disappeared.
> >
> > Great, thanks for testing.
> >
> > > Maybe we should also add a doc telling which units the dmax should be.
> >
> > I added an enhanced description, which hopefully clarifies the units
> > of dmax.
> >
> > > When you'll sign this, you can add my tested-by.
> >
> > Done, and tested against Linus' master. I take it you have a patch on
> > this coming up as well?
>
> Yep. I have a one line patch to enable the feature in synaptics. I will
> send it as soon as Dmitry take this one.
I did so please send yours in.
--
Dmitry
prev parent reply other threads:[~2015-02-02 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 19:52 [PATCH] Input: MT - Add support for balanced slot assignment Henrik Rydberg
2015-01-22 20:02 ` Dmitry Torokhov
2015-01-22 20:24 ` Henrik Rydberg
2015-01-23 1:30 ` Peter Hutterer
2015-01-26 16:56 ` Benjamin Tissoires
2015-02-01 9:03 ` Henrik Rydberg
2015-02-02 15:32 ` Benjamin Tissoires
2015-02-02 17:12 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202171257.GA23909@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.