From: Tony Lindgren <tony@atomide.com>
To: Matthijs van Duin <matthijsvanduin@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Brian Hutchinson <b.hutchman@gmail.com>
Subject: Re: [PATCH 4/4] ARM: dts: Add minimal support for dm8168-evm
Date: Mon, 2 Feb 2015 09:44:18 -0800 [thread overview]
Message-ID: <20150202174416.GE9418@atomide.com> (raw)
In-Reply-To: <CAALWOA9gSegCofYF-csg_2zdRkz=W5g8UAOqBbrA-NG0-oR1ww@mail.gmail.com>
* Matthijs van Duin <matthijsvanduin@gmail.com> [150128 13:46]:
> On 26 January 2015 at 16:58, Tony Lindgren <tony@atomide.com> wrote:
> > See earlier I was assuming copy paste issues from dm814x to dm816x
>
> Ahh, you thought the 816x was 814x-derived... yes I can imagine that
> will have led to some confusion.
>
> > I'm pretty sure I verified the that the audio_pll_clk1 is hardwwired
> > to 32KiHz by looking at it with a scope on the clkout pin.
>
> Yeah it comes straight from the "rtcdivider" so it'll produce
> 0.0016384 * devosc.
Not much about "rtcdivider" in the dm816x TRM..
> The global clock structure overview in the TRM (figure 2-6) actually
> correctly marks the former-audio-fapll clocks (except audio5 := osc0,
> yielding sysclk22 after divider) but you already need to know what the
> hell is going on to recognize that.
That seems to be in the dm814x TRM. OK so it looks like in
mainline kernel drivers/clk/ti/fapll.c we can then fix the hardcoded
value in ti_fapll_synth_recalc_rate() to return the rate of fd->clk_ref
multiplied 0.0016384 instead of 32768.
And we probably should add what you're explaining to the comments
also to make some sense out of it :)
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: dts: Add minimal support for dm8168-evm
Date: Mon, 2 Feb 2015 09:44:18 -0800 [thread overview]
Message-ID: <20150202174416.GE9418@atomide.com> (raw)
In-Reply-To: <CAALWOA9gSegCofYF-csg_2zdRkz=W5g8UAOqBbrA-NG0-oR1ww@mail.gmail.com>
* Matthijs van Duin <matthijsvanduin@gmail.com> [150128 13:46]:
> On 26 January 2015 at 16:58, Tony Lindgren <tony@atomide.com> wrote:
> > See earlier I was assuming copy paste issues from dm814x to dm816x
>
> Ahh, you thought the 816x was 814x-derived... yes I can imagine that
> will have led to some confusion.
>
> > I'm pretty sure I verified the that the audio_pll_clk1 is hardwwired
> > to 32KiHz by looking at it with a scope on the clkout pin.
>
> Yeah it comes straight from the "rtcdivider" so it'll produce
> 0.0016384 * devosc.
Not much about "rtcdivider" in the dm816x TRM..
> The global clock structure overview in the TRM (figure 2-6) actually
> correctly marks the former-audio-fapll clocks (except audio5 := osc0,
> yielding sysclk22 after divider) but you already need to know what the
> hell is going on to recognize that.
That seems to be in the dm814x TRM. OK so it looks like in
mainline kernel drivers/clk/ti/fapll.c we can then fix the hardcoded
value in ti_fapll_synth_recalc_rate() to return the rate of fd->clk_ref
multiplied 0.0016384 instead of 32768.
And we probably should add what you're explaining to the comments
also to make some sense out of it :)
Regards,
Tony
next prev parent reply other threads:[~2015-02-02 17:47 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 23:37 [PATCH 0/4] Device tree related changes to boot dm816x Tony Lindgren
2015-01-13 23:37 ` Tony Lindgren
2015-01-13 23:37 ` [PATCH 1/4] ARM: OMAP2+: Add board-generic.c entry for ti81xx Tony Lindgren
2015-01-13 23:37 ` Tony Lindgren
2015-01-14 13:51 ` Sergei Shtylyov
2015-01-14 13:51 ` Sergei Shtylyov
2015-01-15 0:07 ` Tony Lindgren
2015-01-15 0:07 ` Tony Lindgren
2015-01-19 19:18 ` Tony Lindgren
2015-01-19 19:18 ` Tony Lindgren
2015-01-19 20:42 ` Felipe Balbi
2015-01-19 20:42 ` Felipe Balbi
2015-01-19 21:05 ` Tony Lindgren
2015-01-19 21:05 ` Tony Lindgren
2015-01-19 21:10 ` Felipe Balbi
2015-01-19 21:10 ` Felipe Balbi
2015-01-13 23:37 ` [PATCH 2/4] ARM: dts: Add basic dm816x device tree configuration Tony Lindgren
2015-01-13 23:37 ` Tony Lindgren
2015-01-15 21:23 ` Suman Anna
2015-01-15 21:23 ` Suman Anna
2015-01-15 22:59 ` Tony Lindgren
2015-01-15 22:59 ` Tony Lindgren
2015-01-17 16:41 ` Tony Lindgren
2015-01-17 16:41 ` Tony Lindgren
2015-01-13 23:37 ` [PATCH 3/4] ARM: dts: Add basic clocks for dm816x Tony Lindgren
2015-01-13 23:37 ` Tony Lindgren
2015-01-13 23:37 ` [PATCH 4/4] ARM: dts: Add minimal support for dm8168-evm Tony Lindgren
2015-01-13 23:37 ` Tony Lindgren
2015-01-17 16:47 ` Tony Lindgren
2015-01-17 16:47 ` Tony Lindgren
2015-01-17 17:51 ` Matthijs van Duin
2015-01-17 17:51 ` Matthijs van Duin
2015-01-17 18:14 ` Tony Lindgren
2015-01-17 18:14 ` Tony Lindgren
2015-01-17 22:37 ` Matthijs van Duin
2015-01-17 22:37 ` Matthijs van Duin
2015-01-19 17:29 ` Tony Lindgren
2015-01-19 17:29 ` Tony Lindgren
2015-01-22 3:17 ` Matthijs van Duin
2015-01-22 3:17 ` Matthijs van Duin
2015-01-23 16:47 ` Tony Lindgren
2015-01-23 16:47 ` Tony Lindgren
2015-01-25 8:34 ` Matthijs van Duin
2015-01-25 8:34 ` Matthijs van Duin
2015-01-26 15:58 ` Tony Lindgren
2015-01-26 15:58 ` Tony Lindgren
2015-01-28 21:43 ` Matthijs van Duin
2015-01-28 21:43 ` Matthijs van Duin
2015-02-02 17:44 ` Tony Lindgren [this message]
2015-02-02 17:44 ` Tony Lindgren
2015-02-03 5:51 ` Matthijs van Duin
2015-02-03 5:51 ` Matthijs van Duin
2015-01-28 17:04 ` Tony Lindgren
2015-01-28 17:04 ` Tony Lindgren
2015-02-01 1:51 ` Matthijs van Duin
2015-02-01 1:51 ` Matthijs van Duin
2015-02-02 16:09 ` Tony Lindgren
2015-02-02 16:09 ` Tony Lindgren
2015-03-18 0:06 ` Tony Lindgren
2015-03-18 0:06 ` Tony Lindgren
2015-03-18 8:32 ` Matthijs van Duin
2015-03-18 8:32 ` Matthijs van Duin
2015-03-18 16:54 ` Tony Lindgren
2015-03-18 16:54 ` Tony Lindgren
2015-03-19 5:13 ` Matthijs van Duin
2015-03-19 5:13 ` Matthijs van Duin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202174416.GE9418@atomide.com \
--to=tony@atomide.com \
--cc=b.hutchman@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=matthijsvanduin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.