From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: jroedel-l3A5Bk7waGM@public.gmane.org,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: [PATCH 3/5] iommu: Limit iommu_attach/detach_device to devices with their own group
Date: Tue, 3 Feb 2015 13:25:07 +0100 [thread overview]
Message-ID: <20150203122506.GC15068@ulmo.nvidia.com> (raw)
In-Reply-To: <1422317339-22620-4-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1000 bytes --]
On Tue, Jan 27, 2015 at 01:08:57AM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
>
> This patch changes the behavior of the iommu_attach_device
> and iommu_detach_device functions. With this change these
> functions only work on devices that have their own group.
> For all other devices the iommu_group_attach/detach
> functions must be used.
>
> Signed-off-by: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
> ---
> drivers/iommu/iommu.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++----
> 1 file changed, 59 insertions(+), 4 deletions(-)
Sorry for my ignorance, but I don't understand what IOMMU groups are
supposed to be or how to make use of them. It seems like a common idiom
is to simply allocate a new group and add a device to it in the IOMMU's
->add_device() callback, but I fail to see the reason for that.
Can anybody point me to documentation about this? I've looked and I did
not find anything.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org,
Will Deacon <will.deacon@arm.com>, Kukjin Kim <kgene@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Heiko Stuebner <heiko@sntech.de>, Hiroshi Doyu <hdoyu@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, Robin Murphy <robin.murphy@arm.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
jroedel@suse.de
Subject: Re: [PATCH 3/5] iommu: Limit iommu_attach/detach_device to devices with their own group
Date: Tue, 3 Feb 2015 13:25:07 +0100 [thread overview]
Message-ID: <20150203122506.GC15068@ulmo.nvidia.com> (raw)
In-Reply-To: <1422317339-22620-4-git-send-email-joro@8bytes.org>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
On Tue, Jan 27, 2015 at 01:08:57AM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> This patch changes the behavior of the iommu_attach_device
> and iommu_detach_device functions. With this change these
> functions only work on devices that have their own group.
> For all other devices the iommu_group_attach/detach
> functions must be used.
>
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/iommu.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++----
> 1 file changed, 59 insertions(+), 4 deletions(-)
Sorry for my ignorance, but I don't understand what IOMMU groups are
supposed to be or how to make use of them. It seems like a common idiom
is to simply allocate a new group and add a device to it in the IOMMU's
->add_device() callback, but I fail to see the reason for that.
Can anybody point me to documentation about this? I've looked and I did
not find anything.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-02-03 12:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 0:08 [RFC PATCH 0/5] iommu: Introduce default domains for iommu groups Joerg Roedel
2015-01-27 0:08 ` Joerg Roedel
[not found] ` <1422317339-22620-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-01-27 0:08 ` [PATCH 1/5] iommu: Add default domain to iommu-groups Joerg Roedel
2015-01-27 0:08 ` Joerg Roedel
2015-01-27 0:08 ` [PATCH 2/5] iommu: Allocate a default domain for iommu groups Joerg Roedel
2015-01-27 0:08 ` Joerg Roedel
[not found] ` <1422317339-22620-3-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-01-28 14:30 ` Will Deacon
2015-01-28 14:30 ` Will Deacon
[not found] ` <20150128143006.GQ1569-5wv7dgnIgG8@public.gmane.org>
2015-01-28 15:11 ` Robin Murphy
2015-01-28 15:11 ` Robin Murphy
2015-01-30 12:25 ` Joerg Roedel
2015-01-30 12:25 ` Joerg Roedel
2015-01-27 0:08 ` [PATCH 3/5] iommu: Limit iommu_attach/detach_device to devices with their own group Joerg Roedel
2015-01-27 0:08 ` Joerg Roedel
[not found] ` <1422317339-22620-4-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-01-28 14:35 ` Will Deacon
2015-01-28 14:35 ` Will Deacon
[not found] ` <20150128143523.GR1569-5wv7dgnIgG8@public.gmane.org>
2015-01-30 12:28 ` Joerg Roedel
2015-01-30 12:28 ` Joerg Roedel
[not found] ` <20150130122814.GC3702-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-02-02 16:45 ` Will Deacon
2015-02-02 16:45 ` Will Deacon
2015-02-03 12:25 ` Thierry Reding [this message]
2015-02-03 12:25 ` Thierry Reding
[not found] ` <20150203122506.GC15068-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2015-02-03 12:59 ` Joerg Roedel
2015-02-03 12:59 ` Joerg Roedel
2015-01-27 0:08 ` [PATCH 4/5] iommu: Make sure a device is always attached to a domain Joerg Roedel
2015-01-27 0:08 ` Joerg Roedel
[not found] ` <1422317339-22620-5-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-01-28 14:38 ` Will Deacon
2015-01-28 14:38 ` Will Deacon
[not found] ` <20150128143852.GS1569-5wv7dgnIgG8@public.gmane.org>
2015-01-30 12:29 ` Joerg Roedel
2015-01-30 12:29 ` Joerg Roedel
2015-01-27 0:08 ` [PATCH 5/5] iommu: Add iommu_get_domain_for_dev function Joerg Roedel
2015-01-27 0:08 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150203122506.GC15068@ulmo.nvidia.com \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=jroedel-l3A5Bk7waGM@public.gmane.org \
--cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.