From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Max Perepelitsyn <mperepelitsyn@gmail.com>
Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm7xxfb: make smtc_scr_info static
Date: Tue, 03 Feb 2015 14:16:01 +0000 [thread overview]
Message-ID: <20150203140401.GA12697@sudip-PC> (raw)
In-Reply-To: <1422953068-12072-1-git-send-email-mperepelitsyn@gmail.com>
On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote:
> This symbol is never used anywhere else besides sm7xxfb.c
Hi Greg,
do i need to do anything about this patch? maybe a tested-by or reviewed-by?
regards
sudip
>
> Signed-off-by: Max Perepelitsyn <mperepelitsyn@gmail.com>
> ---
> drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
> index 2ae9fd0..72036c2 100644
> --- a/drivers/staging/sm7xxfb/sm7xxfb.c
> +++ b/drivers/staging/sm7xxfb/sm7xxfb.c
> @@ -111,7 +111,7 @@ static struct vesa_mode vesa_mode_table[] = {
> {"0x31B", 1280, 1024, 24},
> };
>
> -struct screen_info smtc_scr_info;
> +static struct screen_info smtc_scr_info;
>
> /* process command line options, get vga parameter */
> static int __init sm7xx_vga_setup(char *options)
> --
> 2.2.2
>
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Max Perepelitsyn <mperepelitsyn@gmail.com>
Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm7xxfb: make smtc_scr_info static
Date: Tue, 3 Feb 2015 19:34:01 +0530 [thread overview]
Message-ID: <20150203140401.GA12697@sudip-PC> (raw)
In-Reply-To: <1422953068-12072-1-git-send-email-mperepelitsyn@gmail.com>
On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote:
> This symbol is never used anywhere else besides sm7xxfb.c
Hi Greg,
do i need to do anything about this patch? maybe a tested-by or reviewed-by?
regards
sudip
>
> Signed-off-by: Max Perepelitsyn <mperepelitsyn@gmail.com>
> ---
> drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
> index 2ae9fd0..72036c2 100644
> --- a/drivers/staging/sm7xxfb/sm7xxfb.c
> +++ b/drivers/staging/sm7xxfb/sm7xxfb.c
> @@ -111,7 +111,7 @@ static struct vesa_mode vesa_mode_table[] = {
> {"0x31B", 1280, 1024, 24},
> };
>
> -struct screen_info smtc_scr_info;
> +static struct screen_info smtc_scr_info;
>
> /* process command line options, get vga parameter */
> static int __init sm7xx_vga_setup(char *options)
> --
> 2.2.2
>
next prev parent reply other threads:[~2015-02-03 14:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 8:44 [PATCH] staging: sm7xxfb: make smtc_scr_info static Max Perepelitsyn
2015-02-03 8:44 ` Max Perepelitsyn
2015-02-03 14:04 ` Sudip Mukherjee [this message]
2015-02-03 14:16 ` Sudip Mukherjee
2015-02-03 15:38 ` Greg KH
2015-02-03 15:38 ` Greg KH
2015-02-03 17:32 ` Sudip Mukherjee
2015-02-03 17:44 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150203140401.GA12697@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mperepelitsyn@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.