From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Sebastian Andrzej Siewior
<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Benoit Cousson <bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Peter Meerwald <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Brad Griffis <bgriffis-l0cyMroinI0@public.gmane.org>,
Paul Gortmaker
<paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>,
Sanjeev Sharma
<sanjeev_sharma-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>,
Jan Kardell <jan.kardell-KSZdJiTw9mzQT0dZR+AlfA@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v6 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler
Date: Tue, 3 Feb 2015 11:49:56 -0800 [thread overview]
Message-ID: <20150203194956.GD20256@dtor-ws> (raw)
In-Reply-To: <54CB1604.9030709-l0cyMroinI0@public.gmane.org>
On Fri, Jan 30, 2015 at 10:56:28AM +0530, Vignesh R wrote:
>
>
> On Wednesday 07 January 2015 11:19 AM, Vignesh R wrote:
> > From: Brad Griffis <bgriffis-l0cyMroinI0@public.gmane.org>
> >
> > TSC interrupt handler had udelay to avoid reporting of false pen-up
> > interrupt to user space. This patch implements workaround suggesting in
> > Advisory 1.0.31 of silicon errata for am335x, thus eliminating udelay
> > and touchscreen lag. This also improves performance of touchscreen and
> > eliminates sudden jump of cursor at touch release.
> >
> > IDLECONFIG and CHARGECONFIG registers are to be configured
> > with same values in order to eliminate false pen-up events. This
> > workaround may result in false pen-down to be detected, hence considerable
> > charge step delay needs to be added. The charge delay is set to 0xB000
> > (in terms of ADC clock cycles) by default.
> >
> > TSC steps are disabled at the end of every sampling cycle and EOS bit is
> > set. Once the EOS bit is set, the TSC steps need to be re-enabled to begin
> > next sampling cycle.
> >
> > Signed-off-by: Brad Griffis <bgriffis-l0cyMroinI0@public.gmane.org>
> > [vigneshr-l0cyMroinI0@public.gmane.org: Ported the patch from v3.12 to v3.19rc1]
> >
> > Signed-off-by: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
> > ---
>
> Ping... Can somebody pick this patch series if there are no more comments??
Yes, I picked up everything but patch #3 as I assume Lee will merge it
through MFD tree.
Thanks.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Vignesh R <vigneshr@ti.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Samuel Ortiz <sameo@linux.intel.com>,
Brad Griffis <bgriffis@ti.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Sanjeev Sharma <sanjeev_sharma@mentor.com>,
Jan Kardell <jan.kardell@telliq.com>, Felipe Balbi <balbi@ti.com>,
Wolfram Sang <wsa@the-dreams.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-iio@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v6 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler
Date: Tue, 3 Feb 2015 11:49:56 -0800 [thread overview]
Message-ID: <20150203194956.GD20256@dtor-ws> (raw)
In-Reply-To: <54CB1604.9030709@ti.com>
On Fri, Jan 30, 2015 at 10:56:28AM +0530, Vignesh R wrote:
>
>
> On Wednesday 07 January 2015 11:19 AM, Vignesh R wrote:
> > From: Brad Griffis <bgriffis@ti.com>
> >
> > TSC interrupt handler had udelay to avoid reporting of false pen-up
> > interrupt to user space. This patch implements workaround suggesting in
> > Advisory 1.0.31 of silicon errata for am335x, thus eliminating udelay
> > and touchscreen lag. This also improves performance of touchscreen and
> > eliminates sudden jump of cursor at touch release.
> >
> > IDLECONFIG and CHARGECONFIG registers are to be configured
> > with same values in order to eliminate false pen-up events. This
> > workaround may result in false pen-down to be detected, hence considerable
> > charge step delay needs to be added. The charge delay is set to 0xB000
> > (in terms of ADC clock cycles) by default.
> >
> > TSC steps are disabled at the end of every sampling cycle and EOS bit is
> > set. Once the EOS bit is set, the TSC steps need to be re-enabled to begin
> > next sampling cycle.
> >
> > Signed-off-by: Brad Griffis <bgriffis@ti.com>
> > [vigneshr@ti.com: Ported the patch from v3.12 to v3.19rc1]
> >
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > ---
>
> Ping... Can somebody pick this patch series if there are no more comments??
Yes, I picked up everything but patch #3 as I assume Lee will merge it
through MFD tree.
Thanks.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler
Date: Tue, 3 Feb 2015 11:49:56 -0800 [thread overview]
Message-ID: <20150203194956.GD20256@dtor-ws> (raw)
In-Reply-To: <54CB1604.9030709@ti.com>
On Fri, Jan 30, 2015 at 10:56:28AM +0530, Vignesh R wrote:
>
>
> On Wednesday 07 January 2015 11:19 AM, Vignesh R wrote:
> > From: Brad Griffis <bgriffis@ti.com>
> >
> > TSC interrupt handler had udelay to avoid reporting of false pen-up
> > interrupt to user space. This patch implements workaround suggesting in
> > Advisory 1.0.31 of silicon errata for am335x, thus eliminating udelay
> > and touchscreen lag. This also improves performance of touchscreen and
> > eliminates sudden jump of cursor at touch release.
> >
> > IDLECONFIG and CHARGECONFIG registers are to be configured
> > with same values in order to eliminate false pen-up events. This
> > workaround may result in false pen-down to be detected, hence considerable
> > charge step delay needs to be added. The charge delay is set to 0xB000
> > (in terms of ADC clock cycles) by default.
> >
> > TSC steps are disabled at the end of every sampling cycle and EOS bit is
> > set. Once the EOS bit is set, the TSC steps need to be re-enabled to begin
> > next sampling cycle.
> >
> > Signed-off-by: Brad Griffis <bgriffis@ti.com>
> > [vigneshr at ti.com: Ported the patch from v3.12 to v3.19rc1]
> >
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > ---
>
> Ping... Can somebody pick this patch series if there are no more comments??
Yes, I picked up everything but patch #3 as I assume Lee will merge it
through MFD tree.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-02-03 19:49 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 5:49 [PATCH v6 0/6] Touchscreen performance related fixes Vignesh R
2015-01-07 5:49 ` Vignesh R
2015-01-07 5:49 ` Vignesh R
2015-01-07 5:49 ` [PATCH v6 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
2015-01-07 5:49 ` Vignesh R
2015-01-07 5:49 ` Vignesh R
2015-01-07 5:49 ` [PATCH v6 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
2015-01-07 5:49 ` Vignesh R
2015-01-07 5:49 ` Vignesh R
2015-01-30 5:26 ` Vignesh R
2015-01-30 5:26 ` Vignesh R
2015-01-30 5:26 ` Vignesh R
[not found] ` <54CB1604.9030709-l0cyMroinI0@public.gmane.org>
2015-02-03 19:49 ` Dmitry Torokhov [this message]
2015-02-03 19:49 ` Dmitry Torokhov
2015-02-03 19:49 ` Dmitry Torokhov
2015-01-07 5:49 ` [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save Vignesh R
2015-01-07 5:49 ` Vignesh R
2015-01-07 5:49 ` Vignesh R
[not found] ` <1420609779-11156-4-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2015-01-20 11:53 ` Lee Jones
2015-01-20 11:53 ` Lee Jones
2015-01-20 11:53 ` Lee Jones
2015-01-20 12:40 ` R, Vignesh
2015-01-20 12:40 ` R, Vignesh
2015-01-20 12:40 ` R, Vignesh
2015-01-20 16:04 ` Lee Jones
2015-01-20 16:04 ` Lee Jones
2015-01-20 16:04 ` Lee Jones
2015-01-21 10:14 ` Vignesh R
2015-01-21 10:14 ` Vignesh R
2015-01-21 10:14 ` Vignesh R
2015-02-05 6:21 ` Vignesh R
2015-02-05 6:21 ` Vignesh R
2015-02-05 6:21 ` Vignesh R
[not found] ` <54D30BE5.4070906-l0cyMroinI0@public.gmane.org>
2015-02-25 4:07 ` Vignesh R
2015-02-25 4:07 ` Vignesh R
2015-02-25 4:07 ` Vignesh R
2015-02-25 7:17 ` Lee Jones
2015-02-25 7:17 ` Lee Jones
2015-02-25 7:17 ` Lee Jones
2015-01-07 5:49 ` [PATCH v6 4/6] input: touchscreen: ti_am335x_tsc: Read charge delay from DT Vignesh R
2015-01-07 5:49 ` Vignesh R
2015-01-07 5:49 ` Vignesh R
2015-01-07 5:49 ` [PATCH v6 5/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC Vignesh R
2015-01-07 5:49 ` Vignesh R
2015-01-07 5:49 ` Vignesh R
2015-01-07 5:49 ` [PATCH v6 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering Vignesh R
2015-01-07 5:49 ` Vignesh R
2015-01-07 5:49 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150203194956.GD20256@dtor-ws \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=bgriffis-l0cyMroinI0@public.gmane.org \
--cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jan.kardell-KSZdJiTw9mzQT0dZR+AlfA@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=sanjeev_sharma-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=vigneshr-l0cyMroinI0@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.