[PATCH] tty/sysrq: fix sparse warnings

[PATCH] tty/sysrq: fix sparse warnings

[Lad Prabhakar]

From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>

this patch fixes following sparse warnings:
sysrq.c:58:16: warning: symbol 'platform_sysrq_reset_seq' was not declared. Should it be static?
sysrq.c:59:5: warning: symbol 'sysrq_reset_downtime_ms' was not declared. Should it be static?

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
 Found this issue on linux-next (gcc  version 4.8.2,
 sparse version  0.4.5-rc1)and applies on top linux-next.

 drivers/tty/sysrq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index 259a4d5..d272a37 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -55,8 +55,8 @@
 static int __read_mostly sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE;
 static bool __read_mostly sysrq_always_enabled;
 
-unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
-int sysrq_reset_downtime_ms __weak;
+static unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
+static int sysrq_reset_downtime_ms __weak;
 
 static bool sysrq_on(void)
 {
-- 
1.9.1

Re: [PATCH] tty/sysrq: fix sparse warnings

[Greg Kroah-Hartman]

On Wed, Feb 04, 2015 at 06:27:31PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>

Why put your name in a different order than is normally used?  Please
just switch it around, tools don't like ',' all that much.

thanks,

greg k-h

Re: [PATCH] tty/sysrq: fix sparse warnings

[Lad, Prabhakar]

Hi Greg,

On Wed, Feb 4, 2015 at 6:32 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Wed, Feb 04, 2015 at 06:27:31PM +0000, Lad Prabhakar wrote:
>> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> Why put your name in a different order than is normally used?  Please
> just switch it around, tools don't like ',' all that much.
>
I usually follow the same way, but will take care of it next time.

Cheers,
--Prabhakar Lad

Re: [PATCH] tty/sysrq: fix sparse warnings

[Lad, Prabhakar]

On Wed, Feb 4, 2015 at 6:27 PM, Lad Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch fixes following sparse warnings:
> sysrq.c:58:16: warning: symbol 'platform_sysrq_reset_seq' was not declared. Should it be static?
> sysrq.c:59:5: warning: symbol 'sysrq_reset_downtime_ms' was not declared. Should it be static?
>
Sorry for the nose please drop this patch, it causes build failure,

drivers/tty/sysrq.c:58:23: error: weak declaration of
‘platform_sysrq_reset_seq’ must be public
 static unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
                       ^
drivers/tty/sysrq.c:59:12: error: weak declaration of
‘sysrq_reset_downtime_ms’ must be public
 static int sysrq_reset_downtime_ms __weak;
            ^
Cheers,
--Prabhakar Lad

> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
>  Found this issue on linux-next (gcc  version 4.8.2,
>  sparse version  0.4.5-rc1)and applies on top linux-next.
>
>  drivers/tty/sysrq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index 259a4d5..d272a37 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -55,8 +55,8 @@
>  static int __read_mostly sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE;
>  static bool __read_mostly sysrq_always_enabled;
>
> -unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
> -int sysrq_reset_downtime_ms __weak;
> +static unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
> +static int sysrq_reset_downtime_ms __weak;
>
>  static bool sysrq_on(void)
>  {
> --
> 1.9.1
>