From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: kvm@vger.kernel.org, mst@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH for-3.19] vhost/net: fix up num_buffers endian-ness
Date: Wed, 4 Feb 2015 23:45:36 +0000 [thread overview]
Message-ID: <20150204234536.GL29656@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20150204.135942.127858058517785730.davem@davemloft.net>
On Wed, Feb 04, 2015 at 01:59:42PM -0800, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
> Date: Tue, 3 Feb 2015 11:07:06 +0200
>
> > In virtio 1.0 mode, when mergeable buffers are enabled on a big-endian
> > host, num_buffers wasn't byte-swapped correctly, so large incoming
> > packets got corrupted.
> >
> > To fix, fill it in within hdr - this also makes sure it gets
> > the correct type.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Applied.
FWIW, conflict with iov_iter patches is trivial; once it shows up in
your kernel.org tree I can either rebase the series or just push
#merge-candidate - whichever you prefer. Linus usually prefers the
second variant, but then he seriously dislikes rebasing of any sort;
I've no idea what your preferences are in that area...
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: mst@redhat.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, cornelia.huck@de.ibm.com,
rusty@rustcorp.com.au
Subject: Re: [PATCH for-3.19] vhost/net: fix up num_buffers endian-ness
Date: Wed, 4 Feb 2015 23:45:36 +0000 [thread overview]
Message-ID: <20150204234536.GL29656@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20150204.135942.127858058517785730.davem@davemloft.net>
On Wed, Feb 04, 2015 at 01:59:42PM -0800, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
> Date: Tue, 3 Feb 2015 11:07:06 +0200
>
> > In virtio 1.0 mode, when mergeable buffers are enabled on a big-endian
> > host, num_buffers wasn't byte-swapped correctly, so large incoming
> > packets got corrupted.
> >
> > To fix, fill it in within hdr - this also makes sure it gets
> > the correct type.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Applied.
FWIW, conflict with iov_iter patches is trivial; once it shows up in
your kernel.org tree I can either rebase the series or just push
#merge-candidate - whichever you prefer. Linus usually prefers the
second variant, but then he seriously dislikes rebasing of any sort;
I've no idea what your preferences are in that area...
next prev parent reply other threads:[~2015-02-04 23:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 9:07 [PATCH for-3.19] vhost/net: fix up num_buffers endian-ness Michael S. Tsirkin
2015-02-03 9:07 ` Michael S. Tsirkin
2015-02-04 21:59 ` David Miller
2015-02-04 21:59 ` David Miller
2015-02-04 23:45 ` Al Viro [this message]
2015-02-04 23:45 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204234536.GL29656@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.