From: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
To: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
Cc: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Jon Masters <jonathan-Zp4isUonpHBD60Wz+7aTrA@public.gmane.org>,
Laszlo Ersek <lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-efi <linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Ricardo Neri
<ricardo.neri-calderon-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH v2] efi, x86: Add a "debug" option to the efi= cmdline
Date: Thu, 5 Feb 2015 11:44:41 +0100 [thread overview]
Message-ID: <20150205104441.GC23980@pd.tnic> (raw)
In-Reply-To: <20150205084139.GA23146-je1gSBvt1Tc/CGXRbJeUwh/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
From: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>
Subject: [PATCH v2] efi, x86: Add a "debug" option to the efi= cmdline
... and hide the memory regions dump behind it. Make it default-off.
Signed-off-by: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>
Link: http://lkml.kernel.org/r/20141209095843.GA3990-fF5Pk5pvG8Y@public.gmane.org
Acked-by: Laszlo Ersek <lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Acked-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
Documentation/kernel-parameters.txt | 3 ++-
arch/x86/platform/efi/efi.c | 5 ++++-
include/linux/efi.h | 1 +
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 176d4fe4f076..101ab5601c2d 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -1024,7 +1024,7 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
Format: {"off" | "on" | "skip[mbr]"}
efi= [EFI]
- Format: { "old_map", "nochunk", "noruntime" }
+ Format: { "old_map", "nochunk", "noruntime", "debug" }
old_map [X86-64]: switch to the old ioremap-based EFI
runtime services mapping. 32-bit still uses this one by
default.
@@ -1032,6 +1032,7 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
boot stub, as chunking can cause problems with some
firmware implementations.
noruntime : disable EFI runtime services support
+ debug: enable misc debug output
efi_no_storage_paranoia [EFI; X86]
Using this parameter you can use more than 50% of
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index dbc8627a5cdf..e859d56ce9f8 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -491,7 +491,8 @@ void __init efi_init(void)
if (efi_memmap_init())
return;
- print_efi_memmap();
+ if (efi_enabled(EFI_DBG))
+ print_efi_memmap();
}
void __init efi_late_init(void)
@@ -939,6 +940,8 @@ static int __init arch_parse_efi_cmdline(char *str)
{
if (parse_option_str(str, "old_map"))
set_bit(EFI_OLD_MEMMAP, &efi.flags);
+ if (parse_option_str(str, "debug"))
+ set_bit(EFI_DBG, &efi.flags);
return 0;
}
diff --git a/include/linux/efi.h b/include/linux/efi.h
index 0238d612750e..14cec75d7e74 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -940,6 +940,7 @@ extern int __init efi_setup_pcdp_console(char *);
#define EFI_64BIT 5 /* Is the firmware 64-bit? */
#define EFI_PARAVIRT 6 /* Access is via a paravirt interface */
#define EFI_ARCH_1 7 /* First arch-specific bit */
+#define EFI_DBG 8 /* Print additional debug info at runtime */
#ifdef CONFIG_EFI
/*
--
2.2.0.33.gc18b867
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Matt Fleming <matt@console-pimps.org>
Cc: Dave Young <dyoung@redhat.com>,
Jon Masters <jonathan@jonmasters.org>,
Laszlo Ersek <lersek@redhat.com>,
linux-efi <linux-efi@vger.kernel.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Matt Fleming <matt.fleming@intel.com>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] efi, x86: Add a "debug" option to the efi= cmdline
Date: Thu, 5 Feb 2015 11:44:41 +0100 [thread overview]
Message-ID: <20150205104441.GC23980@pd.tnic> (raw)
In-Reply-To: <20150205084139.GA23146@dhcp-16-198.nay.redhat.com>
From: Borislav Petkov <bp@suse.de>
Subject: [PATCH v2] efi, x86: Add a "debug" option to the efi= cmdline
... and hide the memory regions dump behind it. Make it default-off.
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: http://lkml.kernel.org/r/20141209095843.GA3990@pd.tnic
Acked-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Dave Young <dyoung@redhat.com>
---
Documentation/kernel-parameters.txt | 3 ++-
arch/x86/platform/efi/efi.c | 5 ++++-
include/linux/efi.h | 1 +
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 176d4fe4f076..101ab5601c2d 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -1024,7 +1024,7 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
Format: {"off" | "on" | "skip[mbr]"}
efi= [EFI]
- Format: { "old_map", "nochunk", "noruntime" }
+ Format: { "old_map", "nochunk", "noruntime", "debug" }
old_map [X86-64]: switch to the old ioremap-based EFI
runtime services mapping. 32-bit still uses this one by
default.
@@ -1032,6 +1032,7 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
boot stub, as chunking can cause problems with some
firmware implementations.
noruntime : disable EFI runtime services support
+ debug: enable misc debug output
efi_no_storage_paranoia [EFI; X86]
Using this parameter you can use more than 50% of
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index dbc8627a5cdf..e859d56ce9f8 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -491,7 +491,8 @@ void __init efi_init(void)
if (efi_memmap_init())
return;
- print_efi_memmap();
+ if (efi_enabled(EFI_DBG))
+ print_efi_memmap();
}
void __init efi_late_init(void)
@@ -939,6 +940,8 @@ static int __init arch_parse_efi_cmdline(char *str)
{
if (parse_option_str(str, "old_map"))
set_bit(EFI_OLD_MEMMAP, &efi.flags);
+ if (parse_option_str(str, "debug"))
+ set_bit(EFI_DBG, &efi.flags);
return 0;
}
diff --git a/include/linux/efi.h b/include/linux/efi.h
index 0238d612750e..14cec75d7e74 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -940,6 +940,7 @@ extern int __init efi_setup_pcdp_console(char *);
#define EFI_64BIT 5 /* Is the firmware 64-bit? */
#define EFI_PARAVIRT 6 /* Access is via a paravirt interface */
#define EFI_ARCH_1 7 /* First arch-specific bit */
+#define EFI_DBG 8 /* Print additional debug info at runtime */
#ifdef CONFIG_EFI
/*
--
2.2.0.33.gc18b867
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-02-05 10:44 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 9:58 Shorten efi regions output Borislav Petkov
2014-12-09 9:58 ` Borislav Petkov
[not found] ` <20141209095843.GA3990-fF5Pk5pvG8Y@public.gmane.org>
2014-12-09 12:42 ` Ard Biesheuvel
2014-12-09 12:42 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_F+o6NKb5JJ8ZQ7AJbjvASeQF1YcuUXv8seOMa5oaxgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-09 12:48 ` Borislav Petkov
2014-12-09 12:48 ` Borislav Petkov
2014-12-09 15:35 ` Laszlo Ersek
2014-12-09 15:35 ` Laszlo Ersek
[not found] ` <548716C5.6000506-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-12-09 16:45 ` Borislav Petkov
2014-12-09 16:45 ` Borislav Petkov
2014-12-10 2:17 ` Dave Young
2014-12-10 2:17 ` Dave Young
[not found] ` <20141210021741.GA3280-4/PLUo9XfK+sDdueE5tM26fLeoKvNuZc@public.gmane.org>
2014-12-10 10:46 ` Borislav Petkov
2014-12-10 10:46 ` Borislav Petkov
[not found] ` <20141210104627.GA17053-fF5Pk5pvG8Y@public.gmane.org>
2015-01-05 14:03 ` Matt Fleming
2015-01-05 14:03 ` Matt Fleming
2015-01-05 15:00 ` Laszlo Ersek
2015-01-21 5:48 ` Jon Masters
[not found] ` <54BF3DCA.4070708-Zp4isUonpHBD60Wz+7aTrA@public.gmane.org>
2015-01-21 10:06 ` Borislav Petkov
2015-01-21 10:06 ` Borislav Petkov
2015-01-26 10:49 ` Matt Fleming
[not found] ` <20150126104936.GB3320-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-01-30 16:43 ` [PATCH] efi, x86: Add a "debug" option to the efi= cmdline Borislav Petkov
2015-01-30 16:43 ` Borislav Petkov
[not found] ` <20150130164309.GG1451-fF5Pk5pvG8Y@public.gmane.org>
2015-01-30 16:58 ` Laszlo Ersek
2015-01-30 16:58 ` Laszlo Ersek
2015-01-30 18:06 ` Randy Dunlap
2015-01-30 18:06 ` Randy Dunlap
[not found] ` <54CBC815.5060502-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-01-30 21:17 ` Borislav Petkov
2015-01-30 21:17 ` Borislav Petkov
2015-02-04 12:18 ` Parmeshwr Prasad
2015-02-04 12:18 ` Parmeshwr Prasad
2015-02-05 3:18 ` Dave Young
2015-02-05 3:18 ` Dave Young
[not found] ` <20150205031846.GA1903-4/PLUo9XfK/1wF9wiOj0lkEOCMrvLtNR@public.gmane.org>
2015-02-05 8:11 ` Borislav Petkov
2015-02-05 8:11 ` Borislav Petkov
[not found] ` <20150205081143.GA23980-fF5Pk5pvG8Y@public.gmane.org>
2015-02-05 8:41 ` Dave Young
2015-02-05 8:41 ` Dave Young
[not found] ` <20150205084139.GA23146-je1gSBvt1Tc/CGXRbJeUwh/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2015-02-05 10:44 ` Borislav Petkov [this message]
2015-02-05 10:44 ` [PATCH v2] " Borislav Petkov
[not found] ` <20150205104441.GC23980-fF5Pk5pvG8Y@public.gmane.org>
2015-02-05 12:45 ` Parmeshwr Prasad
2015-02-05 12:45 ` Parmeshwr Prasad
2015-02-05 14:28 ` Borislav Petkov
[not found] ` <20150205142858.GH23980-fF5Pk5pvG8Y@public.gmane.org>
2015-02-06 6:00 ` Parmeshwr Prasad
2015-02-06 6:00 ` Parmeshwr Prasad
[not found] ` <20150206060007.GA26758-uSknhY0EtF8ok8EplQz5xE1Vg53cnbg30E9HWUfgJXw@public.gmane.org>
2015-02-06 10:49 ` Borislav Petkov
2015-02-06 10:49 ` Borislav Petkov
2015-02-24 22:33 ` Matt Fleming
2015-02-24 22:33 ` Matt Fleming
2015-04-02 12:27 ` [tip:core/efi] x86/efi: " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205104441.GC23980@pd.tnic \
--to=bp-gina5biwoiwzqb+pc5nmwq@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jonathan-Zp4isUonpHBD60Wz+7aTrA@public.gmane.org \
--cc=lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=ricardo.neri-calderon-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.