All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Greg Thelen <gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Konstantin Khlebnikov
	<khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
	Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
	<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
	Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>,
	Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
	Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [RFC] Making memcg track ownership per address_space or anon_vma
Date: Thu, 5 Feb 2015 17:25:22 -0500	[thread overview]
Message-ID: <20150205222522.GA10580@htj.dyndns.org> (raw)
In-Reply-To: <xr93siekt3p3.fsf-aSPv4SP+Du0KgorLzL7FmE7CuiCeIGUxQQ4Iyu8u01E@public.gmane.org>

Hey,

On Thu, Feb 05, 2015 at 02:05:19PM -0800, Greg Thelen wrote:
> >  	A
> >  	+-B    (usage=2M lim=3M min=2M hosted_usage=2M)
> >  	  +-C  (usage=0  lim=2M min=1M shared_usage=2M)
> >  	  +-D  (usage=0  lim=2M min=1M shared_usage=2M)
> >  	  \-E  (usage=0  lim=2M min=0)
...
> Maybe, but I want to understand more about how pressure works in the
> child.  As C (or D) allocates non shared memory does it perform reclaim
> to ensure that its (C.usage + C.shared_usage < C.lim).  Given C's

Yes.

> shared_usage is linked into B.LRU it wouldn't be naturally reclaimable
> by C.  Are you thinking that charge failures on cgroups with non zero
> shared_usage would, as needed, induce reclaim of parent's hosted_usage?

Hmmm.... I'm not really sure but why not?  If we properly account for
the low protection when pushing inodes to the parent, I don't think
it'd break anything.  IOW, allow the amount beyond the sum of low
limits to be reclaimed when one of the sharers is under pressure.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Greg Thelen <gthelen@google.com>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>, Cgroups <cgroups@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jan Kara <jack@suse.cz>, Dave Chinner <david@fromorbit.com>,
	Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@infradead.org>,
	Li Zefan <lizefan@huawei.com>, Hugh Dickins <hughd@google.com>
Subject: Re: [RFC] Making memcg track ownership per address_space or anon_vma
Date: Thu, 5 Feb 2015 17:25:22 -0500	[thread overview]
Message-ID: <20150205222522.GA10580@htj.dyndns.org> (raw)
In-Reply-To: <xr93siekt3p3.fsf@gthelen.mtv.corp.google.com>

Hey,

On Thu, Feb 05, 2015 at 02:05:19PM -0800, Greg Thelen wrote:
> >  	A
> >  	+-B    (usage=2M lim=3M min=2M hosted_usage=2M)
> >  	  +-C  (usage=0  lim=2M min=1M shared_usage=2M)
> >  	  +-D  (usage=0  lim=2M min=1M shared_usage=2M)
> >  	  \-E  (usage=0  lim=2M min=0)
...
> Maybe, but I want to understand more about how pressure works in the
> child.  As C (or D) allocates non shared memory does it perform reclaim
> to ensure that its (C.usage + C.shared_usage < C.lim).  Given C's

Yes.

> shared_usage is linked into B.LRU it wouldn't be naturally reclaimable
> by C.  Are you thinking that charge failures on cgroups with non zero
> shared_usage would, as needed, induce reclaim of parent's hosted_usage?

Hmmm.... I'm not really sure but why not?  If we properly account for
the low protection when pushing inodes to the parent, I don't think
it'd break anything.  IOW, allow the amount beyond the sum of low
limits to be reclaimed when one of the sharers is under pressure.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Greg Thelen <gthelen@google.com>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>, Cgroups <cgroups@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jan Kara <jack@suse.cz>, Dave Chinner <david@fromorbit.com>,
	Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@infradead.org>,
	Li Zefan <lizefan@huawei.com>, Hugh Dickins <hughd@google.com>
Subject: Re: [RFC] Making memcg track ownership per address_space or anon_vma
Date: Thu, 5 Feb 2015 17:25:22 -0500	[thread overview]
Message-ID: <20150205222522.GA10580@htj.dyndns.org> (raw)
In-Reply-To: <xr93siekt3p3.fsf@gthelen.mtv.corp.google.com>

Hey,

On Thu, Feb 05, 2015 at 02:05:19PM -0800, Greg Thelen wrote:
> >  	A
> >  	+-B    (usage=2M lim=3M min=2M hosted_usage=2M)
> >  	  +-C  (usage=0  lim=2M min=1M shared_usage=2M)
> >  	  +-D  (usage=0  lim=2M min=1M shared_usage=2M)
> >  	  \-E  (usage=0  lim=2M min=0)
...
> Maybe, but I want to understand more about how pressure works in the
> child.  As C (or D) allocates non shared memory does it perform reclaim
> to ensure that its (C.usage + C.shared_usage < C.lim).  Given C's

Yes.

> shared_usage is linked into B.LRU it wouldn't be naturally reclaimable
> by C.  Are you thinking that charge failures on cgroups with non zero
> shared_usage would, as needed, induce reclaim of parent's hosted_usage?

Hmmm.... I'm not really sure but why not?  If we properly account for
the low protection when pushing inodes to the parent, I don't think
it'd break anything.  IOW, allow the amount beyond the sum of low
limits to be reclaimed when one of the sharers is under pressure.

Thanks.

-- 
tejun

  parent reply	other threads:[~2015-02-05 22:25 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30  4:43 [RFC] Making memcg track ownership per address_space or anon_vma Tejun Heo
2015-01-30  4:43 ` Tejun Heo
2015-01-30  5:55 ` Greg Thelen
2015-01-30  5:55   ` Greg Thelen
2015-01-30  6:27   ` Tejun Heo
2015-01-30  6:27     ` Tejun Heo
     [not found]     ` <20150130062737.GB25699-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2015-01-30 16:07       ` Tejun Heo
2015-01-30 16:07         ` Tejun Heo
2015-01-30 16:07         ` Tejun Heo
2015-02-02 19:26         ` Konstantin Khlebnikov
2015-02-02 19:26           ` Konstantin Khlebnikov
2015-02-02 19:46           ` Tejun Heo
2015-02-02 19:46             ` Tejun Heo
2015-02-03 23:30             ` Greg Thelen
2015-02-03 23:30               ` Greg Thelen
2015-02-04 10:49               ` Konstantin Khlebnikov
2015-02-04 10:49                 ` Konstantin Khlebnikov
2015-02-04 17:15                 ` Tejun Heo
2015-02-04 17:15                   ` Tejun Heo
2015-02-04 17:58                   ` Konstantin Khlebnikov
2015-02-04 17:58                     ` Konstantin Khlebnikov
     [not found]                     ` <54D25DBD.5080009-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org>
2015-02-04 18:28                       ` Tejun Heo
2015-02-04 18:28                         ` Tejun Heo
2015-02-04 18:28                         ` Tejun Heo
2015-02-04 17:06               ` Tejun Heo
2015-02-04 17:06                 ` Tejun Heo
     [not found]                 ` <20150204170656.GA18858-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2015-02-04 23:51                   ` Greg Thelen
2015-02-04 23:51                     ` Greg Thelen
2015-02-04 23:51                     ` Greg Thelen
2015-02-05 13:15                     ` Tejun Heo
2015-02-05 13:15                       ` Tejun Heo
2015-02-05 22:05                       ` Greg Thelen
2015-02-05 22:05                         ` Greg Thelen
     [not found]                         ` <xr93siekt3p3.fsf-aSPv4SP+Du0KgorLzL7FmE7CuiCeIGUxQQ4Iyu8u01E@public.gmane.org>
2015-02-05 22:25                           ` Tejun Heo [this message]
2015-02-05 22:25                             ` Tejun Heo
2015-02-05 22:25                             ` Tejun Heo
2015-02-06  0:03                             ` Greg Thelen
2015-02-06  0:03                               ` Greg Thelen
2015-02-06 14:17                               ` Tejun Heo
2015-02-06 14:17                                 ` Tejun Heo
2015-02-06 23:43                                 ` Greg Thelen
2015-02-06 23:43                                   ` Greg Thelen
     [not found]                                   ` <CAHH2K0bxvc34u1PugVQsSfxXhmN8qU6KRpiCWwOVBa6BPqMDOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-07 14:38                                     ` Tejun Heo
2015-02-07 14:38                                       ` Tejun Heo
2015-02-07 14:38                                       ` Tejun Heo
     [not found]                                       ` <20150207143839.GA9926-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2015-02-11  2:19                                         ` Tejun Heo
2015-02-11  2:19                                           ` Tejun Heo
2015-02-11  2:19                                           ` Tejun Heo
     [not found]                                           ` <20150211021906.GA21356-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-02-11  7:32                                             ` Jan Kara
2015-02-11  7:32                                               ` Jan Kara
2015-02-11  7:32                                               ` Jan Kara
2015-02-11 18:28                                             ` Greg Thelen
2015-02-11 18:28                                               ` Greg Thelen
2015-02-11 18:28                                               ` Greg Thelen
2015-02-11 20:33                                               ` Tejun Heo
2015-02-11 20:33                                                 ` Tejun Heo
     [not found]                                                 ` <20150211203359.GF21356-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-02-11 21:22                                                   ` Konstantin Khlebnikov
2015-02-11 21:22                                                     ` Konstantin Khlebnikov
2015-02-11 21:22                                                     ` Konstantin Khlebnikov
2015-02-11 21:46                                                     ` Tejun Heo
2015-02-11 21:46                                                       ` Tejun Heo
     [not found]                                                       ` <20150211214650.GA11920-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-02-11 21:57                                                         ` Konstantin Khlebnikov
2015-02-11 21:57                                                           ` Konstantin Khlebnikov
2015-02-11 21:57                                                           ` Konstantin Khlebnikov
     [not found]                                                           ` <CALYGNiPX89HsgUS8BrJvL_jW-EU95xezc7uPf=0Pm72qiUwp7A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-11 22:05                                                             ` Tejun Heo
2015-02-11 22:05                                                               ` Tejun Heo
2015-02-11 22:05                                                               ` Tejun Heo
     [not found]                                                               ` <20150211220530.GA12728-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-02-11 22:15                                                                 ` Konstantin Khlebnikov
2015-02-11 22:15                                                                   ` Konstantin Khlebnikov
2015-02-11 22:15                                                                   ` Konstantin Khlebnikov
2015-02-11 22:30                                                                   ` Tejun Heo
2015-02-11 22:30                                                                     ` Tejun Heo
2015-02-12  2:10                                                 ` Greg Thelen
2015-02-12  2:10                                                   ` Greg Thelen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150205222522.GA10580@htj.dyndns.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org \
    --cc=gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=jack-AlSwsSmVLrQ@public.gmane.org \
    --cc=khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.