From: Pavel Machek <pavel@ucw.cz>
To: Joe Perches <joe@perches.com>
Cc: Quentin Lambert <lambert.quentin@gmail.com>,
Ming Lei <ming.lei@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers/base: Remove unnecessary OOM message
Date: Fri, 06 Feb 2015 21:17:08 +0000 [thread overview]
Message-ID: <20150206211708.GA25967@amd> (raw)
In-Reply-To: <1423256670.4752.16.camel@perches.com>
On Fri 2015-02-06 13:04:30, Joe Perches wrote:
> On Fri, 2015-02-06 at 21:58 +0100, Pavel Machek wrote:
> > On Fri 2015-02-06 16:39:12, Quentin Lambert wrote:
> > > This patch fix checkpatch warnings concerning the possible
> > > duplication of an "out of memory" message.
> >
> > So, instead of nice and readable "not enough memory for clock..." we
> > get OOM, stackdump, and backtrace...? Not sure it is improvement.
>
> All allocs without __GFP_NOWARN already gets an OOM and stackdump.
> These are just unnecessary.
"These" being human readable messages or ugly stackdumps?
Read what I have said. Figuring out what allocation failed from
unreliable backtrace is not fun.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Joe Perches <joe@perches.com>
Cc: Quentin Lambert <lambert.quentin@gmail.com>,
Ming Lei <ming.lei@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers/base: Remove unnecessary OOM message
Date: Fri, 6 Feb 2015 22:17:08 +0100 [thread overview]
Message-ID: <20150206211708.GA25967@amd> (raw)
In-Reply-To: <1423256670.4752.16.camel@perches.com>
On Fri 2015-02-06 13:04:30, Joe Perches wrote:
> On Fri, 2015-02-06 at 21:58 +0100, Pavel Machek wrote:
> > On Fri 2015-02-06 16:39:12, Quentin Lambert wrote:
> > > This patch fix checkpatch warnings concerning the possible
> > > duplication of an "out of memory" message.
> >
> > So, instead of nice and readable "not enough memory for clock..." we
> > get OOM, stackdump, and backtrace...? Not sure it is improvement.
>
> All allocs without __GFP_NOWARN already gets an OOM and stackdump.
> These are just unnecessary.
"These" being human readable messages or ugly stackdumps?
Read what I have said. Figuring out what allocation failed from
unreliable backtrace is not fun.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-02-06 21:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 15:39 [PATCH 1/1] drivers/base: Remove unnecessary OOM message Quentin Lambert
2015-02-06 15:39 ` Quentin Lambert
2015-02-06 20:58 ` Pavel Machek
2015-02-06 20:58 ` Pavel Machek
2015-02-06 21:04 ` Joe Perches
2015-02-06 21:04 ` Joe Perches
2015-02-06 21:17 ` Pavel Machek [this message]
2015-02-06 21:17 ` Pavel Machek
2015-02-07 10:24 ` Dan Carpenter
2015-02-07 10:24 ` Dan Carpenter
2015-02-08 23:28 ` Rafael J. Wysocki
2015-02-08 23:28 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150206211708.GA25967@amd \
--to=pavel@ucw.cz \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lambert.quentin@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.