All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Tom Huynh <tom.huynh@freescale.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, acme@kernel.org,
	Andi Kleen <andi@firstfloor.org>,
	paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
	mingo@redhat.com
Subject: Re: [PATCH 1/3] perf/e6500: Make event translations available in sysfs
Date: Mon, 9 Feb 2015 14:25:57 +0100	[thread overview]
Message-ID: <20150209132557.GA8099@gmail.com> (raw)
In-Reply-To: <20150209121132.GB3952@krava.redhat.com>


* Jiri Olsa <jolsa@redhat.com> wrote:

> On Mon, Feb 09, 2015 at 11:07:38AM +0100, Ingo Molnar wrote:
> > 
> > * Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > On Fri, Feb 06, 2015 at 04:43:54PM -0600, Tom Huynh wrote:
> > > >  arch/powerpc/perf/e6500-events-list.h         | 289 ++++++++++++++++++++++++++
> > > 
> > > That's a lot of events to stuff in the kernel, would a 
> > > userspace list not be more convenient?
> > > 
> > > ISTR there being various discussions on providing support 
> > > for that in tools/perf, Jiri?
> > 
> > As long as it's in a single well organized place in tools/, 
> > I'd be fine with that solution as well.
> > 
> > What doesn't work very well is disjunct, disorganized, 
> > inconsistent event descriptions all across the tooling and 
> > platform landscape - putting static tables into sysfs is a 
> > marked improvement over that, despite its memory usage.
> 
> the last version is in here:
> http://marc.info/?l=linux-kernel&m=140676269017820&w=2
> 
> AFAIK Andi is setting up the download area as discussed 
> in the thread and should repost at some point

I'll NAK any external 'download area' (and I told that Andi 
before): tools/perf/event-tables/ or so is a good enough 
'download area' with fast enough update cycles.

If any 'update' of event descriptions is needed it can 
happen through the distro package mechanism, or via a 
simple 'git pull' if it's compiled directly.

Lets not overengineer this with any dependence on an 
external site and with a separate update mechanism - lets 
just get the tables into tools/ and see it from there...

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Andi Kleen <andi@firstfloor.org>,
	Tom Huynh <tom.huynh@freescale.com>,
	benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
	mingo@redhat.com, acme@kernel.org, Kim.Phillips@freescale.com,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] perf/e6500: Make event translations available in sysfs
Date: Mon, 9 Feb 2015 14:25:57 +0100	[thread overview]
Message-ID: <20150209132557.GA8099@gmail.com> (raw)
In-Reply-To: <20150209121132.GB3952@krava.redhat.com>


* Jiri Olsa <jolsa@redhat.com> wrote:

> On Mon, Feb 09, 2015 at 11:07:38AM +0100, Ingo Molnar wrote:
> > 
> > * Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > On Fri, Feb 06, 2015 at 04:43:54PM -0600, Tom Huynh wrote:
> > > >  arch/powerpc/perf/e6500-events-list.h         | 289 ++++++++++++++++++++++++++
> > > 
> > > That's a lot of events to stuff in the kernel, would a 
> > > userspace list not be more convenient?
> > > 
> > > ISTR there being various discussions on providing support 
> > > for that in tools/perf, Jiri?
> > 
> > As long as it's in a single well organized place in tools/, 
> > I'd be fine with that solution as well.
> > 
> > What doesn't work very well is disjunct, disorganized, 
> > inconsistent event descriptions all across the tooling and 
> > platform landscape - putting static tables into sysfs is a 
> > marked improvement over that, despite its memory usage.
> 
> the last version is in here:
> http://marc.info/?l=linux-kernel&m=140676269017820&w=2
> 
> AFAIK Andi is setting up the download area as discussed 
> in the thread and should repost at some point

I'll NAK any external 'download area' (and I told that Andi 
before): tools/perf/event-tables/ or so is a good enough 
'download area' with fast enough update cycles.

If any 'update' of event descriptions is needed it can 
happen through the distro package mechanism, or via a 
simple 'git pull' if it's compiled directly.

Lets not overengineer this with any dependence on an 
external site and with a separate update mechanism - lets 
just get the tables into tools/ and see it from there...

Thanks,

	Ingo

  reply	other threads:[~2015-02-09 13:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-06 22:43 [PATCH 0/3] Add e6500 perf events to sysfs and update perf doc Tom Huynh
2015-02-06 22:43 ` Tom Huynh
2015-02-06 22:43 ` [PATCH 1/3] perf/e6500: Make event translations available in sysfs Tom Huynh
2015-02-06 22:43   ` Tom Huynh
2015-02-09 10:02   ` Peter Zijlstra
2015-02-09 10:02     ` Peter Zijlstra
2015-02-09 10:07     ` Ingo Molnar
2015-02-09 10:07       ` Ingo Molnar
2015-02-09 12:11       ` Jiri Olsa
2015-02-09 12:11         ` Jiri Olsa
2015-02-09 13:25         ` Ingo Molnar [this message]
2015-02-09 13:25           ` Ingo Molnar
2015-02-09 20:40           ` Andi Kleen
2015-02-09 20:40             ` Andi Kleen
2015-02-11  0:19             ` Scott Wood
2015-02-11  0:19               ` Scott Wood
2015-02-18 20:56               ` Ingo Molnar
2015-02-18 20:56                 ` Ingo Molnar
2015-02-18 21:31                 ` Andi Kleen
2015-02-18 21:31                   ` Andi Kleen
2015-02-16 16:10             ` Tom Huynh
2015-02-16 16:10               ` Tom Huynh
2015-03-27 21:34               ` Kim Phillips
2015-03-27 21:34                 ` Kim Phillips
2015-03-28  0:32                 ` Andi Kleen
2015-03-28  0:32                   ` Andi Kleen
2015-02-06 22:43 ` [PATCH 2/3] perf/e6500: Create a sysfs format entry for e6500 events Tom Huynh
2015-02-06 22:43   ` Tom Huynh
2015-02-06 22:43 ` [PATCH 3/3] perf/doc: Update perf_event_attr struct Tom Huynh
2015-02-06 22:43   ` Tom Huynh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150209132557.GA8099@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=tom.huynh@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.