[PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

[PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

[Olaf Hering]

It is already used in the runlevel script and the service file.  It is
supposed to replace XENSTORED_TRACE= boolean, which cant be easily
supported in the xenstored.service file.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---

This was ignored for 4.5.0, it should be backported to 4.5.1.


 tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
index c12fc8a..f0fa98d 100644
--- a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
+++ b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
@@ -21,6 +21,14 @@
 #XENSTORED=@XENSTORED@
 
 ## Type: string
+## Default: ""
+#
+# Additional commandline arguments to start xenstored,
+# like "--trace-file /var/log/xen/xenstored-trace.log"
+# See "@sbindir@/xenstored --help" for possible options.
+XENSTORED_ARGS=
+
+## Type: string
 ## Default: Not defined, tracing off
 #
 # Log xenstored messages

Re: [PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

[Olaf Hering]

Ping?

On Tue, Feb 03, Olaf Hering wrote:

> It is already used in the runlevel script and the service file.  It is
> supposed to replace XENSTORED_TRACE= boolean, which cant be easily
> supported in the xenstored.service file.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
> 
> This was ignored for 4.5.0, it should be backported to 4.5.1.
> 
> 
>  tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> index c12fc8a..f0fa98d 100644
> --- a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> +++ b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> @@ -21,6 +21,14 @@
>  #XENSTORED=@XENSTORED@
>  
>  ## Type: string
> +## Default: ""
> +#
> +# Additional commandline arguments to start xenstored,
> +# like "--trace-file /var/log/xen/xenstored-trace.log"
> +# See "@sbindir@/xenstored --help" for possible options.
> +XENSTORED_ARGS=
> +
> +## Type: string
>  ## Default: Not defined, tracing off
>  #
>  # Log xenstored messages

Re: [PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

[Ian Jackson]

Olaf Hering writes ("[PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file."):
> It is already used in the runlevel script and the service file.  It is
> supposed to replace XENSTORED_TRACE= boolean, which cant be easily
> supported in the xenstored.service file.

I haven't gone through all the history again, but I think the last
time this came up I objected to the idea that XENSTORED_TRACE was
being deprecated.

I don't object to XENSTORED_ARGS as an additional variable.  So I
think this could be addressed by (a) not saying in the commit message
that XENSTORED_TRACE is being replaced and (b) using a different
example (or no) example in the comment.

Thanks,
Ian.

Re: [PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

[Olaf Hering]

On Fri, Feb 13, Ian Jackson wrote:

> Olaf Hering writes ("[PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file."):
> > It is already used in the runlevel script and the service file.  It is
> > supposed to replace XENSTORED_TRACE= boolean, which cant be easily
> > supported in the xenstored.service file.
> 
> I haven't gone through all the history again, but I think the last
> time this came up I objected to the idea that XENSTORED_TRACE was
> being deprecated.
> 
> I don't object to XENSTORED_ARGS as an additional variable.  So I
> think this could be addressed by (a) not saying in the commit message
> that XENSTORED_TRACE is being replaced and (b) using a different
> example (or no) example in the comment.

Ok, I will adjust the commit message and resend along with other pending
tools changes.

Olaf