[PATCH] packagegroup-arago-base-tisdk: Make psplash conditional with splash feature

[PATCH] packagegroup-arago-base-tisdk: Make psplash conditional with splash feature

[Sam Nelson]

- This is meant to avoid error message with headless distribution

Signed-off-by: Sam Nelson <sam.nelson@ti.com>
---
 .../packagegroups/packagegroup-arago-base-tisdk.bb |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk.bb
index 7652622..7b71aa4 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk.bb
@@ -1,6 +1,6 @@
 DESCRIPTION = "Additional packages beyond console packages shared by TI SDKs"
 LICENSE = "MIT"
-PR = "r15"
+PR = "r16"
 
 inherit packagegroup
 
@@ -12,7 +12,7 @@ RDEPENDS_${PN} = "\
     libpcre \
     iptables \
     iperf \
-    psplash \
+    ${@base_contains('DISTRO_FEATURES', 'splash', 'psplash', '',d)} \
     arago-gpl-notice \
     arago-feed-config \
     nfs-utils-client \
-- 
1.7.9.5

Re: [PATCH] packagegroup-arago-base-tisdk: Make psplash conditional with splash feature

[Denys Dmytriyenko]

On Tue, Feb 10, 2015 at 11:01:15AM -0500, Sam Nelson wrote:
> - This is meant to avoid error message with headless distribution
> 
> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> ---
>  .../packagegroups/packagegroup-arago-base-tisdk.bb |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk.bb
> index 7652622..7b71aa4 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base-tisdk.bb
> @@ -1,6 +1,6 @@
>  DESCRIPTION = "Additional packages beyond console packages shared by TI SDKs"
>  LICENSE = "MIT"
> -PR = "r15"
> +PR = "r16"
>  
>  inherit packagegroup
>  
> @@ -12,7 +12,7 @@ RDEPENDS_${PN} = "\
>      libpcre \
>      iptables \
>      iperf \
> -    psplash \
> +    ${@base_contains('DISTRO_FEATURES', 'splash', 'psplash', '',d)} \

There's no "splash" in DISTRO_FEATURES. There is one in IMAGE_FEATURES though, 
which we don't use, but probably should.


>      arago-gpl-notice \
>      arago-feed-config \
>      nfs-utils-client \
> -- 
> 1.7.9.5
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] packagegroup-arago-base-tisdk: Make psplash conditional with splash feature

[Cooper Jr., Franklin]

Splash is not a distro feature we use so this will essentially remove it from all devices.

You can either put this in a packagegroup that isn't included for headless filesystems. But pick one that makes sense.
You can conditional include or not include psplash depending on machines.
You can use machine features and check for touchscreen. Although some kind of generic "display" machine feature would be better. But it currently doesn't exist.
Or you can add splash as a distro feature for the various branding files excluding yours.


> -----Original Message-----
> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> bounces@arago-project.org] On Behalf Of Nelson, Sam
> Sent: Tuesday, February 10, 2015 10:01 AM
> To: meta-arago@arago-project.org
> Subject: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make psplash
> conditional with splash feature
> 
> - This is meant to avoid error message with headless distribution
> 
> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> ---
>  .../packagegroups/packagegroup-arago-base-tisdk.bb |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> arago-base-tisdk.bb b/meta-arago-distro/recipes-
> core/packagegroups/packagegroup-arago-base-tisdk.bb
> index 7652622..7b71aa4 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> base-tisdk.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> base-tisdk.bb
> @@ -1,6 +1,6 @@
>  DESCRIPTION = "Additional packages beyond console packages shared by TI
> SDKs"
>  LICENSE = "MIT"
> -PR = "r15"
> +PR = "r16"
> 
>  inherit packagegroup
> 
> @@ -12,7 +12,7 @@ RDEPENDS_${PN} = "\
>      libpcre \
>      iptables \
>      iperf \
> -    psplash \
> +    ${@base_contains('DISTRO_FEATURES', 'splash', 'psplash', '',d)} \
>      arago-gpl-notice \
>      arago-feed-config \
>      nfs-utils-client \
> --
> 1.7.9.5
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] packagegroup-arago-base-tisdk: Make psplash conditional with splash feature

[Nelson, Sam]

> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Tuesday, February 10, 2015 11:16 AM
> To: Nelson, Sam
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make
> psplash conditional with splash feature
> 
> On Tue, Feb 10, 2015 at 11:01:15AM -0500, Sam Nelson wrote:
> > - This is meant to avoid error message with headless distribution
> >
> > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > ---
> >  .../packagegroups/packagegroup-arago-base-tisdk.bb |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> arago-base-tisdk.bb b/meta-arago-distro/recipes-
> core/packagegroups/packagegroup-arago-base-tisdk.bb
> > index 7652622..7b71aa4 100644
> > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> base-tisdk.bb
> > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> base-tisdk.bb
> > @@ -1,6 +1,6 @@
> >  DESCRIPTION = "Additional packages beyond console packages shared by TI
> SDKs"
> >  LICENSE = "MIT"
> > -PR = "r15"
> > +PR = "r16"
> >
> >  inherit packagegroup
> >
> > @@ -12,7 +12,7 @@ RDEPENDS_${PN} = "\
> >      libpcre \
> >      iptables \
> >      iperf \
> > -    psplash \
> > +    ${@base_contains('DISTRO_FEATURES', 'splash', 'psplash', '',d)} \
> 
> There's no "splash" in DISTRO_FEATURES. There is one in IMAGE_FEATURES
> though,
> which we don't use, but probably should.
[Sam] Thanks. I will make it depend on IMAGE_FEATURES.
> 
> 
> >      arago-gpl-notice \
> >      arago-feed-config \
> >      nfs-utils-client \
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] packagegroup-arago-base-tisdk: Make psplash conditional with splash feature

[Nelson, Sam]

> -----Original Message-----
> From: Cooper Jr., Franklin
> Sent: Tuesday, February 10, 2015 11:16 AM
> To: Nelson, Sam; meta-arago@arago-project.org
> Subject: RE: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make
> psplash conditional with splash feature
> 
> Splash is not a distro feature we use so this will essentially remove it from all
> devices.
> 
> You can either put this in a packagegroup that isn't included for headless
> filesystems. But pick one that makes sense.
> You can conditional include or not include psplash depending on machines.
> You can use machine features and check for touchscreen. Although some kind
> of generic "display" machine feature would be better. But it currently doesn't
> exist.
> Or you can add splash as a distro feature for the various branding files
> excluding yours.
[Sam] Do you see any issues using the "IMAGE_FEATURES" instead? Core-image-base include splash by default ( so all products will include psplash). And I am thinking of removing it for Keystone using branding file and can be done for any other headless distribution similarly.

> 
> 
> > -----Original Message-----
> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > bounces@arago-project.org] On Behalf Of Nelson, Sam
> > Sent: Tuesday, February 10, 2015 10:01 AM
> > To: meta-arago@arago-project.org
> > Subject: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make psplash
> > conditional with splash feature
> >
> > - This is meant to avoid error message with headless distribution
> >
> > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > ---
> >  .../packagegroups/packagegroup-arago-base-tisdk.bb |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > arago-base-tisdk.bb b/meta-arago-distro/recipes-
> > core/packagegroups/packagegroup-arago-base-tisdk.bb
> > index 7652622..7b71aa4 100644
> > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> > base-tisdk.bb
> > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> > base-tisdk.bb
> > @@ -1,6 +1,6 @@
> >  DESCRIPTION = "Additional packages beyond console packages shared by TI
> > SDKs"
> >  LICENSE = "MIT"
> > -PR = "r15"
> > +PR = "r16"
> >
> >  inherit packagegroup
> >
> > @@ -12,7 +12,7 @@ RDEPENDS_${PN} = "\
> >      libpcre \
> >      iptables \
> >      iperf \
> > -    psplash \
> > +    ${@base_contains('DISTRO_FEATURES', 'splash', 'psplash', '',d)} \
> >      arago-gpl-notice \
> >      arago-feed-config \
> >      nfs-utils-client \
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] packagegroup-arago-base-tisdk: Make psplash conditional with splash feature

[Denys Dmytriyenko]

On Tue, Feb 10, 2015 at 04:30:57PM +0000, Nelson, Sam wrote:
> 
> 
> > -----Original Message-----
> > From: Cooper Jr., Franklin
> > Sent: Tuesday, February 10, 2015 11:16 AM
> > To: Nelson, Sam; meta-arago@arago-project.org
> > Subject: RE: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make
> > psplash conditional with splash feature
> > 
> > Splash is not a distro feature we use so this will essentially remove it from all
> > devices.
> > 
> > You can either put this in a packagegroup that isn't included for headless
> > filesystems. But pick one that makes sense.
> > You can conditional include or not include psplash depending on machines.
> > You can use machine features and check for touchscreen. Although some kind
> > of generic "display" machine feature would be better. But it currently doesn't
> > exist.
> > Or you can add splash as a distro feature for the various branding files
> > excluding yours.

> [Sam] Do you see any issues using the "IMAGE_FEATURES" instead? 
> Core-image-base include splash by default ( so all products will include 
> psplash).

That's the wrong assumption.


> And I am thinking of removing it for Keystone using branding file 
> and can be done for any other headless distribution similarly.

Won't work due to above.


> > > -----Original Message-----
> > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > bounces@arago-project.org] On Behalf Of Nelson, Sam
> > > Sent: Tuesday, February 10, 2015 10:01 AM
> > > To: meta-arago@arago-project.org
> > > Subject: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make psplash
> > > conditional with splash feature
> > >
> > > - This is meant to avoid error message with headless distribution
> > >
> > > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > > ---
> > >  .../packagegroups/packagegroup-arago-base-tisdk.bb |    4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > > arago-base-tisdk.bb b/meta-arago-distro/recipes-
> > > core/packagegroups/packagegroup-arago-base-tisdk.bb
> > > index 7652622..7b71aa4 100644
> > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> > > base-tisdk.bb
> > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> > > base-tisdk.bb
> > > @@ -1,6 +1,6 @@
> > >  DESCRIPTION = "Additional packages beyond console packages shared by TI
> > > SDKs"
> > >  LICENSE = "MIT"
> > > -PR = "r15"
> > > +PR = "r16"
> > >
> > >  inherit packagegroup
> > >
> > > @@ -12,7 +12,7 @@ RDEPENDS_${PN} = "\
> > >      libpcre \
> > >      iptables \
> > >      iperf \
> > > -    psplash \
> > > +    ${@base_contains('DISTRO_FEATURES', 'splash', 'psplash', '',d)} \
> > >      arago-gpl-notice \
> > >      arago-feed-config \
> > >      nfs-utils-client \
> > > --
> > > 1.7.9.5
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] packagegroup-arago-base-tisdk: Make psplash conditional with splash feature

[Nelson, Sam]

> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Tuesday, February 10, 2015 11:37 AM
> To: Nelson, Sam
> Cc: Cooper Jr., Franklin; meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make
> psplash conditional with splash feature
> 
> On Tue, Feb 10, 2015 at 04:30:57PM +0000, Nelson, Sam wrote:
> >
> >
> > > -----Original Message-----
> > > From: Cooper Jr., Franklin
> > > Sent: Tuesday, February 10, 2015 11:16 AM
> > > To: Nelson, Sam; meta-arago@arago-project.org
> > > Subject: RE: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make
> > > psplash conditional with splash feature
> > >
> > > Splash is not a distro feature we use so this will essentially remove it from
> all
> > > devices.
> > >
> > > You can either put this in a packagegroup that isn't included for headless
> > > filesystems. But pick one that makes sense.
> > > You can conditional include or not include psplash depending on machines.
> > > You can use machine features and check for touchscreen. Although some
> kind
> > > of generic "display" machine feature would be better. But it currently
> doesn't
> > > exist.
> > > Or you can add splash as a distro feature for the various branding files
> > > excluding yours.
> 
> > [Sam] Do you see any issues using the "IMAGE_FEATURES" instead?
> > Core-image-base include splash by default ( so all products will include
> > psplash).
> 
> That's the wrong assumption.
> 
[Sam] Ok.  Thanks for the clarification. Is there any other alternative suggestion?  
> 
> > And I am thinking of removing it for Keystone using branding file
> > and can be done for any other headless distribution similarly.
> 
> Won't work due to above.
> 
> 
> > > > -----Original Message-----
> > > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > > bounces@arago-project.org] On Behalf Of Nelson, Sam
> > > > Sent: Tuesday, February 10, 2015 10:01 AM
> > > > To: meta-arago@arago-project.org
> > > > Subject: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make
> psplash
> > > > conditional with splash feature
> > > >
> > > > - This is meant to avoid error message with headless distribution
> > > >
> > > > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > > > ---
> > > >  .../packagegroups/packagegroup-arago-base-tisdk.bb |    4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > > > arago-base-tisdk.bb b/meta-arago-distro/recipes-
> > > > core/packagegroups/packagegroup-arago-base-tisdk.bb
> > > > index 7652622..7b71aa4 100644
> > > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> > > > base-tisdk.bb
> > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> arago-
> > > > base-tisdk.bb
> > > > @@ -1,6 +1,6 @@
> > > >  DESCRIPTION = "Additional packages beyond console packages shared by
> TI
> > > > SDKs"
> > > >  LICENSE = "MIT"
> > > > -PR = "r15"
> > > > +PR = "r16"
> > > >
> > > >  inherit packagegroup
> > > >
> > > > @@ -12,7 +12,7 @@ RDEPENDS_${PN} = "\
> > > >      libpcre \
> > > >      iptables \
> > > >      iperf \
> > > > -    psplash \
> > > > +    ${@base_contains('DISTRO_FEATURES', 'splash', 'psplash', '',d)} \
> > > >      arago-gpl-notice \
> > > >      arago-feed-config \
> > > >      nfs-utils-client \
> > > > --
> > > > 1.7.9.5
> > > >
> > > > _______________________________________________
> > > > meta-arago mailing list
> > > > meta-arago@arago-project.org
> > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] packagegroup-arago-base-tisdk: Make psplash conditional with splash feature

[Cooper Jr., Franklin]

> -----Original Message-----
> From: Nelson, Sam
> Sent: Tuesday, February 10, 2015 10:43 AM
> To: Dmytriyenko, Denys
> Cc: Cooper Jr., Franklin; meta-arago@arago-project.org
> Subject: RE: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make
> psplash conditional with splash feature
> 
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Tuesday, February 10, 2015 11:37 AM
> > To: Nelson, Sam
> > Cc: Cooper Jr., Franklin; meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make
> > psplash conditional with splash feature
> >
> > On Tue, Feb 10, 2015 at 04:30:57PM +0000, Nelson, Sam wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Cooper Jr., Franklin
> > > > Sent: Tuesday, February 10, 2015 11:16 AM
> > > > To: Nelson, Sam; meta-arago@arago-project.org
> > > > Subject: RE: [meta-arago] [PATCH] packagegroup-arago-base-tisdk:
> > > > Make psplash conditional with splash feature
> > > >
> > > > Splash is not a distro feature we use so this will essentially
> > > > remove it from
> > all
> > > > devices.
> > > >
> > > > You can either put this in a packagegroup that isn't included for
> > > > headless filesystems. But pick one that makes sense.
> > > > You can conditional include or not include psplash depending on
> machines.
> > > > You can use machine features and check for touchscreen. Although
> > > > some
> > kind
> > > > of generic "display" machine feature would be better. But it
> > > > currently
> > doesn't
> > > > exist.
> > > > Or you can add splash as a distro feature for the various branding
> > > > files excluding yours.
> >
> > > [Sam] Do you see any issues using the "IMAGE_FEATURES" instead?
> > > Core-image-base include splash by default ( so all products will
> > > include psplash).
[Franklin] I've never used it and don't really understand the purpose but if Denys recommends it then I'm sure its not a bad option.
> >
> > That's the wrong assumption.
> >
> [Sam] Ok.  Thanks for the clarification. Is there any other alternative
> suggestion?
> >
> > > And I am thinking of removing it for Keystone using branding file
> > > and can be done for any other headless distribution similarly.
> >
> > Won't work due to above.
> >
> >
> > > > > -----Original Message-----
> > > > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > > > bounces@arago-project.org] On Behalf Of Nelson, Sam
> > > > > Sent: Tuesday, February 10, 2015 10:01 AM
> > > > > To: meta-arago@arago-project.org
> > > > > Subject: [meta-arago] [PATCH] packagegroup-arago-base-tisdk:
> > > > > Make
> > psplash
> > > > > conditional with splash feature
> > > > >
> > > > > - This is meant to avoid error message with headless
> > > > > distribution
> > > > >
> > > > > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > > > > ---
> > > > >  .../packagegroups/packagegroup-arago-base-tisdk.bb |    4 ++--
> > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git
> > > > > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > > > > arago-base-tisdk.bb b/meta-arago-distro/recipes-
> > > > > core/packagegroups/packagegroup-arago-base-tisdk.bb
> > > > > index 7652622..7b71aa4 100644
> > > > > ---
> > > > > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arag
> > > > > o-
> > > > > base-tisdk.bb
> > > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > arago-
> > > > > base-tisdk.bb
> > > > > @@ -1,6 +1,6 @@
> > > > >  DESCRIPTION = "Additional packages beyond console packages
> > > > > shared by
> > TI
> > > > > SDKs"
> > > > >  LICENSE = "MIT"
> > > > > -PR = "r15"
> > > > > +PR = "r16"
> > > > >
> > > > >  inherit packagegroup
> > > > >
> > > > > @@ -12,7 +12,7 @@ RDEPENDS_${PN} = "\
> > > > >      libpcre \
> > > > >      iptables \
> > > > >      iperf \
> > > > > -    psplash \
> > > > > +    ${@base_contains('DISTRO_FEATURES', 'splash', 'psplash',
> > > > > + '',d)} \
> > > > >      arago-gpl-notice \
> > > > >      arago-feed-config \
> > > > >      nfs-utils-client \
> > > > > --
> > > > > 1.7.9.5
> > > > >
> > > > > _______________________________________________
> > > > > meta-arago mailing list
> > > > > meta-arago@arago-project.org
> > > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] packagegroup-arago-base-tisdk: Make psplash conditional with splash feature

[Denys Dmytriyenko]

On Tue, Feb 10, 2015 at 11:43:29AM -0500, Nelson, Sam wrote:
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Tuesday, February 10, 2015 11:37 AM
> > To: Nelson, Sam
> > Cc: Cooper Jr., Franklin; meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make
> > psplash conditional with splash feature
> > 
> > On Tue, Feb 10, 2015 at 04:30:57PM +0000, Nelson, Sam wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Cooper Jr., Franklin
> > > > Sent: Tuesday, February 10, 2015 11:16 AM
> > > > To: Nelson, Sam; meta-arago@arago-project.org
> > > > Subject: RE: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make
> > > > psplash conditional with splash feature
> > > >
> > > > Splash is not a distro feature we use so this will essentially remove it from
> > all
> > > > devices.
> > > >
> > > > You can either put this in a packagegroup that isn't included for headless
> > > > filesystems. But pick one that makes sense.
> > > > You can conditional include or not include psplash depending on machines.
> > > > You can use machine features and check for touchscreen. Although some
> > kind
> > > > of generic "display" machine feature would be better. But it currently
> > doesn't
> > > > exist.
> > > > Or you can add splash as a distro feature for the various branding files
> > > > excluding yours.
> > 
> > > [Sam] Do you see any issues using the "IMAGE_FEATURES" instead?
> > > Core-image-base include splash by default ( so all products will include
> > > psplash).
> > 
> > That's the wrong assumption.
> > 
> [Sam] Ok.  Thanks for the clarification. Is there any other alternative suggestion?  

We don't use core-image-base.bb from oe-core, so we need to enable "splash" 
IMAGE_FEATURES in our image recipes. See the patch I just sent and provide 
feedback.


> > > And I am thinking of removing it for Keystone using branding file
> > > and can be done for any other headless distribution similarly.
> > 
> > Won't work due to above.
> > 
> > 
> > > > > -----Original Message-----
> > > > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > > > > bounces@arago-project.org] On Behalf Of Nelson, Sam
> > > > > Sent: Tuesday, February 10, 2015 10:01 AM
> > > > > To: meta-arago@arago-project.org
> > > > > Subject: [meta-arago] [PATCH] packagegroup-arago-base-tisdk: Make
> > psplash
> > > > > conditional with splash feature
> > > > >
> > > > > - This is meant to avoid error message with headless distribution
> > > > >
> > > > > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > > > > ---
> > > > >  .../packagegroups/packagegroup-arago-base-tisdk.bb |    4 ++--
> > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > > > > arago-base-tisdk.bb b/meta-arago-distro/recipes-
> > > > > core/packagegroups/packagegroup-arago-base-tisdk.bb
> > > > > index 7652622..7b71aa4 100644
> > > > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> > > > > base-tisdk.bb
> > > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > arago-
> > > > > base-tisdk.bb
> > > > > @@ -1,6 +1,6 @@
> > > > >  DESCRIPTION = "Additional packages beyond console packages shared by
> > TI
> > > > > SDKs"
> > > > >  LICENSE = "MIT"
> > > > > -PR = "r15"
> > > > > +PR = "r16"
> > > > >
> > > > >  inherit packagegroup
> > > > >
> > > > > @@ -12,7 +12,7 @@ RDEPENDS_${PN} = "\
> > > > >      libpcre \
> > > > >      iptables \
> > > > >      iperf \
> > > > > -    psplash \
> > > > > +    ${@base_contains('DISTRO_FEATURES', 'splash', 'psplash', '',d)} \
> > > > >      arago-gpl-notice \
> > > > >      arago-feed-config \
> > > > >      nfs-utils-client \
> > > > > --
> > > > > 1.7.9.5
> > > > >
> > > > > _______________________________________________
> > > > > meta-arago mailing list
> > > > > meta-arago@arago-project.org
> > > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago