Re: [PATCH 1/2] dfe-lld: Add recipe for Digital Radio Front end low level driver & test code

[Denys Dmytriyenko <denys@ti.com>]

Two comments, although not very critical:

1. dfe-lld-test defpends on iqn2-lld, which gets added in the second patch. I 
understand that iqn2-lld depends on dfe-lld, so the proper way to break it 
into patches and ensure bisectability, is to submit dfe-lld-test recipe 
separately as a third patch after dfe-lld and iqn2-lld/test.

2. Since you are only building for k2l, do you want to set a more stricter 
COMPATIBLE_MACHINE as "k2l-evm"?

-- 
Denys


On Mon, Feb 02, 2015 at 10:55:23AM -0500, Sam Nelson wrote:
> - Provides low level driver for Digital Radio front end
> - Supports device k2l
> 
> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> ---
>  recipes-bsp/dfe-lld/dfe-lld-test_git.bb |   18 ++++++++++++++++++
>  recipes-bsp/dfe-lld/dfe-lld.inc         |   13 +++++++++++++
>  recipes-bsp/dfe-lld/dfe-lld_git.bb      |   15 +++++++++++++++
>  3 files changed, 46 insertions(+)
>  create mode 100644 recipes-bsp/dfe-lld/dfe-lld-test_git.bb
>  create mode 100644 recipes-bsp/dfe-lld/dfe-lld.inc
>  create mode 100644 recipes-bsp/dfe-lld/dfe-lld_git.bb
> 
> diff --git a/recipes-bsp/dfe-lld/dfe-lld-test_git.bb b/recipes-bsp/dfe-lld/dfe-lld-test_git.bb
> new file mode 100644
> index 0000000..acaaf63
> --- /dev/null
> +++ b/recipes-bsp/dfe-lld/dfe-lld-test_git.bb
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "TI Digital Radio Front End lld test application"
> +
> +DEPENDS = "common-csl-ip dfe-lld iqn2-lld"
> +
> +include dfe-lld.inc
> +
> +EXTRA_OEMAKE = "-f makefile_armv7 PDK_INSTALL_PATH=${STAGING_INCDIR} DFE_SRC_DIR=${S}"
> +
> +do_compile () {
> +#   Now build the lld in the updated directory
> +	oe_runmake clean DEVICE=k2l
> +	oe_runmake tests DEVICE=k2l
> +	oe_runmake tests DEVICE=k2l USEDYNAMIC_LIB=yes
> +}
> +
> +do_install () {
> +	oe_runmake installbin INSTALL_BIN_BASE_DIR=${D}/${bindir}
> +}
> diff --git a/recipes-bsp/dfe-lld/dfe-lld.inc b/recipes-bsp/dfe-lld/dfe-lld.inc
> new file mode 100644
> index 0000000..b1e42e7
> --- /dev/null
> +++ b/recipes-bsp/dfe-lld/dfe-lld.inc
> @@ -0,0 +1,13 @@
> +LICENSE = "BSD-3-Clause"
> +
> +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=1f4217b705bf98762a302fd720649dcc"
> +BRANCH = "master"
> +SRC_URI = "git://git.ti.com/keystone-rtos/dfe-lld.git;destsuffix=git/ti/drv/dfe;protocol=git;branch=${BRANCH}"
> +# The following commit correspond to DEV.DFE_LLD.01.00.00.03C
> +SRCREV = "ed20e87d3676e3e05ce2b78179b504a05083ad15"
> +
> +PV = "1.0.0.3"
> +
> +COMPATIBLE_MACHINE = "keystone"
> +
> +S = "${WORKDIR}/git/ti/drv/dfe"
> diff --git a/recipes-bsp/dfe-lld/dfe-lld_git.bb b/recipes-bsp/dfe-lld/dfe-lld_git.bb
> new file mode 100644
> index 0000000..a2477ca
> --- /dev/null
> +++ b/recipes-bsp/dfe-lld/dfe-lld_git.bb
> @@ -0,0 +1,15 @@
> +DESCRIPTION = "Digital Radio Front End low level driver"
> +
> +DEPENDS = "common-csl-ip"
> +
> +include dfe-lld.inc
> +
> +EXTRA_OEMAKE = "-f makefile_armv7 PDK_INSTALL_PATH=${STAGING_INCDIR}"
> +
> +do_compile () {
> +	oe_runmake lib DEVICE=k2l
> +}
> +
> +do_install () {
> +	oe_runmake install INSTALL_INC_BASE_DIR=${D}/${includedir} INSTALL_LIB_BASE_DIR=${D}${libdir}
> +}
> -- 
> 1.7.9.5
> 
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti