From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers
Date: Tue, 10 Feb 2015 23:07:51 +0100 [thread overview]
Message-ID: <201502102307.51740.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5CYHKCUXyCGzuRaYt_o=ucSmZBwsc8mF84HqaA-+QX15g@mail.gmail.com>
On Tuesday, February 10, 2015 at 10:54:52 PM, Fabio Estevam wrote:
> Hi Stefan,
>
> On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> > thanks this is very helpful. I built the linux-next for my Duckbill and
> > add the SSP2 section from imx28-evk.dts into imx28-duckbill.dts.
> >
> > Without my patch i get the following for HW_CLKCTRL_FRAC0:
> >
> > ./memwatch -a 0x800401B0
> >
> > 0x800401b0: 0x5e5b5513
> >
> > With my patch i get:
> >
> > ./memwatch -a 0x800401B0
> >
> > 0x800401b0: 0x5e1b5513
> >
> > So it looks like a problem in my patch.
>
> Yes, let's try to get the same value HW_CLKCTRL_FRAC0.
>
> > I orded such a flash chip, but it will take some time until i can use it
> > with my hardware.
>
> Thanks for doing this.
>
> Maybe if you find out a way to fix the calculation of
> HW_CLKCTRL_FRAC0, then I can test it on my board.
Hi,
the difference is this 0x40 bit, right ? That's _STABLE bit, so it means
the clock are not stable, right ? Why would that happen in the first place?
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
Sascha Hauer <kernel@pengutronix.de>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
Shawn Guo <shawn.guo@linaro.org>,
Mike Turquette <mturquette@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>, Zhi Li <lznuaa@gmail.com>
Subject: Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers
Date: Tue, 10 Feb 2015 23:07:51 +0100 [thread overview]
Message-ID: <201502102307.51740.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5CYHKCUXyCGzuRaYt_o=ucSmZBwsc8mF84HqaA-+QX15g@mail.gmail.com>
On Tuesday, February 10, 2015 at 10:54:52 PM, Fabio Estevam wrote:
> Hi Stefan,
>
> On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> > thanks this is very helpful. I built the linux-next for my Duckbill and
> > add the SSP2 section from imx28-evk.dts into imx28-duckbill.dts.
> >
> > Without my patch i get the following for HW_CLKCTRL_FRAC0:
> >
> > ./memwatch -a 0x800401B0
> >
> > 0x800401b0: 0x5e5b5513
> >
> > With my patch i get:
> >
> > ./memwatch -a 0x800401B0
> >
> > 0x800401b0: 0x5e1b5513
> >
> > So it looks like a problem in my patch.
>
> Yes, let's try to get the same value HW_CLKCTRL_FRAC0.
>
> > I orded such a flash chip, but it will take some time until i can use it
> > with my hardware.
>
> Thanks for doing this.
>
> Maybe if you find out a way to fix the calculation of
> HW_CLKCTRL_FRAC0, then I can test it on my board.
Hi,
the difference is this 0x40 bit, right ? That's _STABLE bit, so it means
the clock are not stable, right ? Why would that happen in the first place?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-02-10 22:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 19:20 [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers Stefan Wahren
2015-01-30 19:20 ` Stefan Wahren
2015-01-30 19:28 ` Fabio Estevam
2015-01-30 19:28 ` Fabio Estevam
2015-02-03 21:08 ` Mike Turquette
2015-02-03 21:08 ` Mike Turquette
2015-02-10 12:52 ` Fabio Estevam
2015-02-10 12:52 ` Fabio Estevam
2015-02-10 13:05 ` Stefan Wahren
2015-02-10 13:05 ` Stefan Wahren
2015-02-10 13:09 ` Fabio Estevam
2015-02-10 13:09 ` Fabio Estevam
2015-02-10 13:55 ` Stefan Wahren
2015-02-10 13:55 ` Stefan Wahren
2015-02-10 15:06 ` Fabio Estevam
2015-02-10 15:06 ` Fabio Estevam
2015-02-10 21:24 ` Stefan Wahren
2015-02-10 21:24 ` Stefan Wahren
2015-02-10 21:54 ` Fabio Estevam
2015-02-10 21:54 ` Fabio Estevam
2015-02-10 22:07 ` Marek Vasut [this message]
2015-02-10 22:07 ` Marek Vasut
2015-02-11 2:24 ` Mike Turquette
2015-02-11 2:24 ` Mike Turquette
2015-02-11 16:58 ` Fabio Estevam
2015-02-11 16:58 ` Fabio Estevam
2015-02-11 20:31 ` Stefan Wahren
2015-02-11 20:31 ` Stefan Wahren
2015-02-11 21:10 ` Fabio Estevam
2015-02-11 21:10 ` Fabio Estevam
2015-02-12 18:59 ` Stefan Wahren
2015-02-12 18:59 ` Stefan Wahren
2015-02-12 19:08 ` Fabio Estevam
2015-02-12 19:08 ` Fabio Estevam
2015-02-16 20:24 ` Stefan Wahren
2015-02-16 20:24 ` Stefan Wahren
2015-02-17 8:09 ` Marek Vasut
2015-02-17 8:09 ` Marek Vasut
2015-02-20 11:09 ` Stefan Wahren
2015-02-20 11:09 ` Stefan Wahren
-- strict thread matches above, loose matches on Subject: below --
2015-01-30 19:14 Stefan Wahren
2015-01-30 19:14 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201502102307.51740.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.