From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC] simple_char: New infrastructure to simplify chardev management
Date: Wed, 11 Feb 2015 08:44:59 +0800 [thread overview]
Message-ID: <20150211004459.GA30746@kroah.com> (raw)
In-Reply-To: <d3ab93173d51cebf00dd2263fd0ce9f8cd6258f7.1423609645.git.luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
On Tue, Feb 10, 2015 at 03:44:05PM -0800, Andy Lutomirski wrote:
> This isn't adequately tested, and I don't have a demonstration (yet).
> It's here for review for whether it's a good idea in the first place
> and for weather the fully_dynamic mechanism is a good idea.
>
> The current character device interfaces are IMO awful.
That's a total understatement. Redoing the char interface has been in
my todo list for a decade now. It's the complexity that happens to be
used by just a handful of drivers that have prevented me from doing the
rework in the past. Creating a "new" interface that we then port code
to is a very good idea, as it can happen over time in a much more
orderly way.
And we can throw the kernel-janitors people at it once it's working, to
convert the rest of the tree, providing them a useful outlet for their
need for patch cleanups :)
So yes, I'm all for this, thanks so much for looking into this. I'm at
a conference this week, but will go over it on the plane home and give
you some review comments.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Arnd Bergmann <arnd@arndb.de>, Jiri Kosina <jkosina@suse.cz>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [RFC] simple_char: New infrastructure to simplify chardev management
Date: Wed, 11 Feb 2015 08:44:59 +0800 [thread overview]
Message-ID: <20150211004459.GA30746@kroah.com> (raw)
In-Reply-To: <d3ab93173d51cebf00dd2263fd0ce9f8cd6258f7.1423609645.git.luto@amacapital.net>
On Tue, Feb 10, 2015 at 03:44:05PM -0800, Andy Lutomirski wrote:
> This isn't adequately tested, and I don't have a demonstration (yet).
> It's here for review for whether it's a good idea in the first place
> and for weather the fully_dynamic mechanism is a good idea.
>
> The current character device interfaces are IMO awful.
That's a total understatement. Redoing the char interface has been in
my todo list for a decade now. It's the complexity that happens to be
used by just a handful of drivers that have prevented me from doing the
rework in the past. Creating a "new" interface that we then port code
to is a very good idea, as it can happen over time in a much more
orderly way.
And we can throw the kernel-janitors people at it once it's working, to
convert the rest of the tree, providing them a useful outlet for their
need for patch cleanups :)
So yes, I'm all for this, thanks so much for looking into this. I'm at
a conference this week, but will go over it on the plane home and give
you some review comments.
greg k-h
next prev parent reply other threads:[~2015-02-11 0:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 23:44 [RFC] simple_char: New infrastructure to simplify chardev management Andy Lutomirski
2015-02-10 23:44 ` Andy Lutomirski
[not found] ` <d3ab93173d51cebf00dd2263fd0ce9f8cd6258f7.1423609645.git.luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
2015-02-11 0:44 ` Greg Kroah-Hartman [this message]
2015-02-11 0:44 ` Greg Kroah-Hartman
[not found] ` <20150211004459.GA30746-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-02-11 20:04 ` Andy Lutomirski
2015-02-11 20:04 ` Andy Lutomirski
2015-02-11 10:10 ` Jiri Kosina
2015-02-11 10:10 ` Jiri Kosina
2015-03-27 8:45 ` Christoph Hellwig
2015-03-27 8:45 ` Christoph Hellwig
2015-04-23 8:25 ` Greg Kroah-Hartman
2015-04-23 8:25 ` Greg Kroah-Hartman
2015-04-23 9:34 ` David Herrmann
2015-04-23 9:34 ` David Herrmann
2015-03-26 0:16 ` Andy Lutomirski
[not found] ` <CALCETrUXgqAY1MzMP80W_YC-zCi3nostJE2sLA+X_U0Xu6hoFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-26 9:26 ` Greg Kroah-Hartman
2015-03-26 9:26 ` Greg Kroah-Hartman
2015-10-11 7:26 ` Christoph Hellwig
2015-10-11 7:26 ` Christoph Hellwig
[not found] ` <20151011072605.GA28986-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-10-12 20:02 ` Andy Lutomirski
2015-10-12 20:02 ` Andy Lutomirski
-- strict thread matches above, loose matches on Subject: below --
2015-03-26 7:30 Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150211004459.GA30746@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=jkosina-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.