From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: zynq: Add linux, stdout-path and stdout-path
Date: Wed, 11 Feb 2015 12:40:27 +0000 [thread overview]
Message-ID: <20150211124027.GH9154@leverpostej> (raw)
In-Reply-To: <ea777ffbffea442e3bc69fe11183811772a5716e.1423657710.git.michal.simek@xilinx.com>
On Wed, Feb 11, 2015 at 12:29:02PM +0000, Michal Simek wrote:
> parallella - Use reference instead of hardcoded path
> (linux,stdout-path)
>
> stdout-path is used by bootloader to identify console.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> U-Boot driver model requires stdout-path.
> ---
> arch/arm/boot/dts/zynq-parallella.dts | 3 ++-
> arch/arm/boot/dts/zynq-zc702.dts | 2 ++
> arch/arm/boot/dts/zynq-zc706.dts | 2 ++
> arch/arm/boot/dts/zynq-zed.dts | 2 ++
> arch/arm/boot/dts/zynq-zybo.dts | 2 ++
> 5 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts
> index 6a5f51daa708..45228a427006 100644
> --- a/arch/arm/boot/dts/zynq-parallella.dts
> +++ b/arch/arm/boot/dts/zynq-parallella.dts
> @@ -35,7 +35,8 @@
>
> chosen {
> bootargs = "console=ttyPS0,115200 earlyprintk root=/dev/mmcblk0p2 rootfstype=ext4 rw rootwait";
> - linux,stdout-path = "/amba/serial at e0001000";
> + linux,stdout-path = &uart1;
> + stdout-path = &uart1;
Given that you added aliases in the last patch, you can use that to
refer to the serial:
stdout-path - "serial0:115200n8";
With or without the alias you can encode the UART configuration here
too:
stdout-path = "/amba/serial at e0001000:115200n8"
Which makes the expected configuration explicit without relying on the
Linux-specific bootargs.
Is there any reason to keep linux,stdout-path?
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org"
<monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>,
"Josh Cartwright" <josh.cartwright-acOepvfBmUk@public.gmane.org>,
"Steffen Trumtrar"
<s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Rob Herring"
<robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Peter Crosthwaite"
<peter.crosthwaite-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Pawel Moll" <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
"Ian Campbell"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"Russell King" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"Sören Brinkmann"
<soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] ARM: dts: zynq: Add linux,stdout-path and stdout-path
Date: Wed, 11 Feb 2015 12:40:27 +0000 [thread overview]
Message-ID: <20150211124027.GH9154@leverpostej> (raw)
In-Reply-To: <ea777ffbffea442e3bc69fe11183811772a5716e.1423657710.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
On Wed, Feb 11, 2015 at 12:29:02PM +0000, Michal Simek wrote:
> parallella - Use reference instead of hardcoded path
> (linux,stdout-path)
>
> stdout-path is used by bootloader to identify console.
>
> Signed-off-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> ---
>
> U-Boot driver model requires stdout-path.
> ---
> arch/arm/boot/dts/zynq-parallella.dts | 3 ++-
> arch/arm/boot/dts/zynq-zc702.dts | 2 ++
> arch/arm/boot/dts/zynq-zc706.dts | 2 ++
> arch/arm/boot/dts/zynq-zed.dts | 2 ++
> arch/arm/boot/dts/zynq-zybo.dts | 2 ++
> 5 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts
> index 6a5f51daa708..45228a427006 100644
> --- a/arch/arm/boot/dts/zynq-parallella.dts
> +++ b/arch/arm/boot/dts/zynq-parallella.dts
> @@ -35,7 +35,8 @@
>
> chosen {
> bootargs = "console=ttyPS0,115200 earlyprintk root=/dev/mmcblk0p2 rootfstype=ext4 rw rootwait";
> - linux,stdout-path = "/amba/serial@e0001000";
> + linux,stdout-path = &uart1;
> + stdout-path = &uart1;
Given that you added aliases in the last patch, you can use that to
refer to the serial:
stdout-path - "serial0:115200n8";
With or without the alias you can encode the UART configuration here
too:
stdout-path = "/amba/serial@e0001000:115200n8"
Which makes the expected configuration explicit without relying on the
Linux-specific bootargs.
Is there any reason to keep linux,stdout-path?
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"monstr@monstr.eu" <monstr@monstr.eu>,
"Josh Cartwright" <josh.cartwright@ni.com>,
"Steffen Trumtrar" <s.trumtrar@pengutronix.de>,
"Rob Herring" <robherring2@gmail.com>,
"Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <Pawel.Moll@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Russell King" <linux@arm.linux.org.uk>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ARM: dts: zynq: Add linux,stdout-path and stdout-path
Date: Wed, 11 Feb 2015 12:40:27 +0000 [thread overview]
Message-ID: <20150211124027.GH9154@leverpostej> (raw)
In-Reply-To: <ea777ffbffea442e3bc69fe11183811772a5716e.1423657710.git.michal.simek@xilinx.com>
On Wed, Feb 11, 2015 at 12:29:02PM +0000, Michal Simek wrote:
> parallella - Use reference instead of hardcoded path
> (linux,stdout-path)
>
> stdout-path is used by bootloader to identify console.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> U-Boot driver model requires stdout-path.
> ---
> arch/arm/boot/dts/zynq-parallella.dts | 3 ++-
> arch/arm/boot/dts/zynq-zc702.dts | 2 ++
> arch/arm/boot/dts/zynq-zc706.dts | 2 ++
> arch/arm/boot/dts/zynq-zed.dts | 2 ++
> arch/arm/boot/dts/zynq-zybo.dts | 2 ++
> 5 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts
> index 6a5f51daa708..45228a427006 100644
> --- a/arch/arm/boot/dts/zynq-parallella.dts
> +++ b/arch/arm/boot/dts/zynq-parallella.dts
> @@ -35,7 +35,8 @@
>
> chosen {
> bootargs = "console=ttyPS0,115200 earlyprintk root=/dev/mmcblk0p2 rootfstype=ext4 rw rootwait";
> - linux,stdout-path = "/amba/serial@e0001000";
> + linux,stdout-path = &uart1;
> + stdout-path = &uart1;
Given that you added aliases in the last patch, you can use that to
refer to the serial:
stdout-path - "serial0:115200n8";
With or without the alias you can encode the UART configuration here
too:
stdout-path = "/amba/serial@e0001000:115200n8"
Which makes the expected configuration explicit without relying on the
Linux-specific bootargs.
Is there any reason to keep linux,stdout-path?
Thanks,
Mark.
next prev parent reply other threads:[~2015-02-11 12:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 12:29 [PATCH 1/2] ARM: dts: zynq: Add missing alias node for zybo and parallella Michal Simek
2015-02-11 12:29 ` Michal Simek
2015-02-11 12:29 ` [PATCH 2/2] ARM: dts: zynq: Add linux,stdout-path and stdout-path Michal Simek
2015-02-11 12:29 ` Michal Simek
2015-02-11 12:40 ` Mark Rutland [this message]
2015-02-11 12:40 ` Mark Rutland
2015-02-11 12:40 ` Mark Rutland
2015-02-11 14:25 ` [PATCH 2/2] ARM: dts: zynq: Add linux, stdout-path " Michal Simek
2015-02-11 14:25 ` [PATCH 2/2] ARM: dts: zynq: Add linux,stdout-path " Michal Simek
2015-02-11 18:18 ` [PATCH 2/2] ARM: dts: zynq: Add linux, stdout-path " Andreas Färber
2015-02-11 18:18 ` Andreas Färber
2015-02-12 9:36 ` Michal Simek
2015-02-12 9:36 ` Michal Simek
[not found] ` <54DB663E.4060605@xilinx.com>
2015-02-12 9:38 ` Michal Simek
2015-02-12 9:38 ` [PATCH 2/2] ARM: dts: zynq: Add linux,stdout-path " Michal Simek
2015-02-12 9:38 ` [PATCH 2/2] ARM: dts: zynq: Add linux, stdout-path " Michal Simek
2015-02-11 17:22 ` [PATCH 1/2] ARM: dts: zynq: Add missing alias node for zybo and parallella Andreas Färber
2015-02-11 17:22 ` Andreas Färber
2015-02-11 17:22 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150211124027.GH9154@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.