From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] nfsd: fix comparison in fh_fsid_match()
Date: Wed, 11 Feb 2015 14:03:19 +0000 [thread overview]
Message-ID: <20150211140319.GO5206@mwanda> (raw)
In-Reply-To: <20150211132119.GA10377@lst.de>
On Wed, Feb 11, 2015 at 02:21:19PM +0100, Christoph Hellwig wrote:
> On Wed, Feb 11, 2015 at 04:08:32PM +0300, Dan Carpenter wrote:
> > We're supposed to be testing that the fh_fsid's match but because the
> > parenthesis are in the wrong place, then we only check the first
> > byte.
> >
> > Fixes: 9558f2500a20 ('nfsd: add fh_fsid_match helper')
>
> Thanks, this looks good. Is there an easy to setup way to check for
> these sorts of errors?
This is a Smatch check I wrote a couple years ago but it never found any
bugs until now so I didn't commit it. I have done. I'll push it out
later and Fengguang will eventually add it to the zero day tester bot.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] nfsd: fix comparison in fh_fsid_match()
Date: Wed, 11 Feb 2015 17:03:19 +0300 [thread overview]
Message-ID: <20150211140319.GO5206@mwanda> (raw)
In-Reply-To: <20150211132119.GA10377@lst.de>
On Wed, Feb 11, 2015 at 02:21:19PM +0100, Christoph Hellwig wrote:
> On Wed, Feb 11, 2015 at 04:08:32PM +0300, Dan Carpenter wrote:
> > We're supposed to be testing that the fh_fsid's match but because the
> > parenthesis are in the wrong place, then we only check the first
> > byte.
> >
> > Fixes: 9558f2500a20 ('nfsd: add fh_fsid_match helper')
>
> Thanks, this looks good. Is there an easy to setup way to check for
> these sorts of errors?
This is a Smatch check I wrote a couple years ago but it never found any
bugs until now so I didn't commit it. I have done. I'll push it out
later and Fengguang will eventually add it to the zero day tester bot.
regards,
dan carpenter
next prev parent reply other threads:[~2015-02-11 14:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 13:08 [patch] nfsd: fix comparison in fh_fsid_match() Dan Carpenter
2015-02-11 13:08 ` Dan Carpenter
2015-02-11 13:21 ` Christoph Hellwig
2015-02-11 13:21 ` Christoph Hellwig
2015-02-11 14:03 ` Dan Carpenter [this message]
2015-02-11 14:03 ` Dan Carpenter
2015-02-12 20:29 ` J. Bruce Fields
2015-02-12 20:29 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150211140319.GO5206@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bfields@fieldses.org \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.