From: Josh Boyer <jwboyer@fedoraproject.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check
Date: Wed, 11 Feb 2015 11:24:05 -0500 [thread overview]
Message-ID: <20150211162404.GA15522@hansolo.redhat.com> (raw)
The man page for pthread_attr_set_affinity_np states that _GNU_SOURCE must
be defined before pthread.h is included in order to get the proper function
declaration. Define this in the Makefile.
Without this defined, the feature check fails on a Fedora system with gcc5
and then the perf build later fails with conflicting prototypes for the
function.
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
---
tools/perf/config/feature-checks/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Full logs at:
http://koji.fedoraproject.org/koji/getfile?taskID=8895543&name=build.log
diff --git a/tools/perf/config/feature-checks/Makefile b/tools/perf/config/feature-checks/Makefile
index 42ac05aaf8ac..b32ff3372514 100644
--- a/tools/perf/config/feature-checks/Makefile
+++ b/tools/perf/config/feature-checks/Makefile
@@ -49,7 +49,7 @@ test-hello.bin:
$(BUILD)
test-pthread-attr-setaffinity-np.bin:
- $(BUILD) -Werror -lpthread
+ $(BUILD) -D_GNU_SOURCE -Werror -lpthread
test-stackprotector-all.bin:
$(BUILD) -Werror -fstack-protector-all
--
2.1.0
next reply other threads:[~2015-02-11 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 16:24 Josh Boyer [this message]
2015-02-11 20:39 ` [PATCH] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check Arnaldo Carvalho de Melo
2015-02-18 18:30 ` [tip:perf/core] " tip-bot for Josh Boyer
2015-03-01 16:49 ` [tip:perf/urgent] " tip-bot for Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150211162404.GA15522@hansolo.redhat.com \
--to=jwboyer@fedoraproject.org \
--cc=Vineet.Gupta1@synopsys.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.