All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Josh Boyer <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: jwboyer@fedoraproject.org, Vineet.Gupta1@synopsys.com,
	mingo@kernel.org, jolsa@kernel.org, a.p.zijlstra@chello.nl,
	tglx@linutronix.de, acme@redhat.com, hpa@zytor.com,
	linux-kernel@vger.kernel.org
Subject: [tip:perf/urgent] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check
Date: Sun, 1 Mar 2015 08:49:44 -0800	[thread overview]
Message-ID: <tip-8eb733829cd17b9b66971f08110df7224d391d65@git.kernel.org> (raw)
In-Reply-To: <20150211162404.GA15522@hansolo.redhat.com>

Commit-ID:  8eb733829cd17b9b66971f08110df7224d391d65
Gitweb:     http://git.kernel.org/tip/8eb733829cd17b9b66971f08110df7224d391d65
Author:     Josh Boyer <jwboyer@fedoraproject.org>
AuthorDate: Wed, 11 Feb 2015 11:24:05 -0500
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 25 Feb 2015 12:17:38 -0300

perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check

The man page for pthread_attr_set_affinity_np states that _GNU_SOURCE
must be defined before pthread.h is included in order to get the proper
function declaration.  Define this in the Makefile.

Without this defined, the feature check fails on a Fedora system with
gcc5 and then the perf build later fails with conflicting prototypes for
the function.

Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Link: http://lkml.kernel.org/r/20150211162404.GA15522@hansolo.redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/config/feature-checks/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/config/feature-checks/Makefile b/tools/perf/config/feature-checks/Makefile
index 42ac05a..b32ff33 100644
--- a/tools/perf/config/feature-checks/Makefile
+++ b/tools/perf/config/feature-checks/Makefile
@@ -49,7 +49,7 @@ test-hello.bin:
 	$(BUILD)
 
 test-pthread-attr-setaffinity-np.bin:
-	$(BUILD) -Werror -lpthread
+	$(BUILD) -D_GNU_SOURCE -Werror -lpthread
 
 test-stackprotector-all.bin:
 	$(BUILD) -Werror -fstack-protector-all

      parent reply	other threads:[~2015-03-01 16:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11 16:24 [PATCH] perf tools: Define _GNU_SOURCE on pthread_attr_setaffinity_np feature check Josh Boyer
2015-02-11 20:39 ` Arnaldo Carvalho de Melo
2015-02-18 18:30 ` [tip:perf/core] " tip-bot for Josh Boyer
2015-03-01 16:49 ` tip-bot for Josh Boyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-8eb733829cd17b9b66971f08110df7224d391d65@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@kernel.org \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.