All of lore.kernel.org
 help / color / mirror / Atom feed
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv6 2/2] INPUT: Introduce generic trigger/LED pairs to input LEDs
Date: Wed, 11 Feb 2015 19:11:42 +0100	[thread overview]
Message-ID: <20150211181142.GA29636@amd> (raw)
In-Reply-To: <20150210221105.GC26472@dtor-ws>

On Tue 2015-02-10 14:11:05, Dmitry Torokhov wrote:
> Hi Samuel,
> 
> On Fri, Jan 23, 2015 at 01:28:14PM +0100, Samuel Thibault wrote:
> > This permits to reassign input LEDs to something else than keyboard "leds"
> > state, by adding a trigger and a led for each input leds, the former being
> > triggered by EV_LED events, and the latter being by default triggered by the
> > former. The user can then make the LED use another trigger, including other LED
> > triggers of the same keyboard.
> > 
> > The hardware LEDs are now not actioned from the EV_LED event any more, but from
> > the per-device LED layer.
> > 
> > [ebroder at mokafive.com: Rebased to 3.2-rc1 or so, cleaned up some includes, and fixed some constants]
> > [akpm at linux-foundation.org: remove unneeded `extern', fix comment layout]
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > Signed-off-by: Evan Broder <evan@ebroder.net>
> > Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
> > Signed-off-by: John Crispin <blogic@openwrt.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> > Changed in this version:
> > - use drvdata instead of platform_data
> > - dropped CONFIG_INPUT_LEDS option
> > - compacted leds and triggers array allocation
> > - handle registration failure
> 
> This did not make the first batch, but I will try to get it into the
> 2nd.
> 
> Pavel, have you tried this version?

Not really, busy with other stuff, sorry. I promise to test -next once
it hits it :-).

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"David Herrmann" <dh.herrmann@gmail.com>,
	akpm@linux-foundation.org, jslaby@suse.cz,
	"Bryan Wu" <cooloney@gmail.com>,
	rpurdie@rpsys.net, linux-kernel@vger.kernel.org,
	"Evan Broder" <evan@ebroder.net>,
	"Arnaud Patard" <arnaud.patard@rtp-net.org>,
	"Peter Korsgaard" <jacmet@sunsite.dk>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Rob Clark" <robdclark@gmail.com>,
	"Niels de Vos" <devos@fedoraproject.org>,
	linux-arm-kernel@lists.infradead.org, blogic@openwrt.org,
	"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCHv6 2/2] INPUT: Introduce generic trigger/LED pairs to input LEDs
Date: Wed, 11 Feb 2015 19:11:42 +0100	[thread overview]
Message-ID: <20150211181142.GA29636@amd> (raw)
In-Reply-To: <20150210221105.GC26472@dtor-ws>

On Tue 2015-02-10 14:11:05, Dmitry Torokhov wrote:
> Hi Samuel,
> 
> On Fri, Jan 23, 2015 at 01:28:14PM +0100, Samuel Thibault wrote:
> > This permits to reassign input LEDs to something else than keyboard "leds"
> > state, by adding a trigger and a led for each input leds, the former being
> > triggered by EV_LED events, and the latter being by default triggered by the
> > former. The user can then make the LED use another trigger, including other LED
> > triggers of the same keyboard.
> > 
> > The hardware LEDs are now not actioned from the EV_LED event any more, but from
> > the per-device LED layer.
> > 
> > [ebroder@mokafive.com: Rebased to 3.2-rc1 or so, cleaned up some includes, and fixed some constants]
> > [akpm@linux-foundation.org: remove unneeded `extern', fix comment layout]
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > Signed-off-by: Evan Broder <evan@ebroder.net>
> > Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
> > Signed-off-by: John Crispin <blogic@openwrt.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> > Changed in this version:
> > - use drvdata instead of platform_data
> > - dropped CONFIG_INPUT_LEDS option
> > - compacted leds and triggers array allocation
> > - handle registration failure
> 
> This did not make the first batch, but I will try to get it into the
> 2nd.
> 
> Pavel, have you tried this version?

Not really, busy with other stuff, sorry. I promise to test -next once
it hits it :-).

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2015-02-11 18:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 12:28 [PATCHv6 2/2] INPUT: Introduce generic trigger/LED pairs to input LEDs Samuel Thibault
2015-01-23 12:28 ` Samuel Thibault
2015-02-10 22:11 ` Dmitry Torokhov
2015-02-10 22:11   ` Dmitry Torokhov
2015-02-11 18:11   ` Pavel Machek [this message]
2015-02-11 18:11     ` Pavel Machek
2015-02-17 18:50 ` Pavel Machek
2015-02-17 18:50   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150211181142.GA29636@amd \
    --to=pavel@ucw.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.