From: Tony Lindgren <tony@atomide.com>
To: Jon Hunter <jgchunter@gmail.com>
Cc: Paul Walmsley <paul@pwsan.com>,
"linux@arm.linux.org.uk >> Russell King" <linux@arm.linux.org.uk>,
"aaro.koskinen@iki.fi >> Aaro Koskinen" <aaro.koskinen@iki.fi>,
"khilman@deeprootsystems.com >> Kevin Hilman"
<khilman@deeprootsystems.com>,
linux-kernel@vger.kernel.org, Jon Hunter <jonathanh@nvidia.com>,
linux-omap@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
tuukka.tikkanen@linaro.org
Subject: Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs
Date: Wed, 11 Feb 2015 12:26:12 -0800 [thread overview]
Message-ID: <20150211202611.GF2531@atomide.com> (raw)
In-Reply-To: <54DB93DA.8050308@gmail.com>
* Jon Hunter <jgchunter@gmail.com> [150211 09:43]:
>
> Thinking about this some more, I don't understand the dependency on the
> DM_TIMER here. For an omap1 device, regardless of whether the DM_TIMERs
> are enable or not, the device should be able to enter low power if the
> 32K is enabled. Hence, shouldn't this have been !(CONFIG_OMAP_32K_TIMER)
> above?
Sounds about right, there are separate timers on omap1 and additional
gp timers. There's no 32KiHz timer on 1510 variants, including
720 and 730.
> Furthermore, you will get the above warning on a omap16xx only build if
> you disable DM_TIMERs and keep MPU_TIMER enabled, which should be a
> valid thing to do.
>
> Tony, I see you added the DM_TIMER dependency in commit
> be26a008414414c69a4ae9fe9877401c3ba62c5a. I understand your motivation,
> but why not just use !(CONFIG_OMAP_32K_TIMER) here? Bit 9 of the idlect1
> is only for the TIMCK clock that is used for the MPU timers and not the
> DM_TIMERs.
Hmm yes looks like you're right. That check be done based on
!CONFIG_OMAP_32K_TIMER like you're saying.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs
Date: Wed, 11 Feb 2015 12:26:12 -0800 [thread overview]
Message-ID: <20150211202611.GF2531@atomide.com> (raw)
In-Reply-To: <54DB93DA.8050308@gmail.com>
* Jon Hunter <jgchunter@gmail.com> [150211 09:43]:
>
> Thinking about this some more, I don't understand the dependency on the
> DM_TIMER here. For an omap1 device, regardless of whether the DM_TIMERs
> are enable or not, the device should be able to enter low power if the
> 32K is enabled. Hence, shouldn't this have been !(CONFIG_OMAP_32K_TIMER)
> above?
Sounds about right, there are separate timers on omap1 and additional
gp timers. There's no 32KiHz timer on 1510 variants, including
720 and 730.
> Furthermore, you will get the above warning on a omap16xx only build if
> you disable DM_TIMERs and keep MPU_TIMER enabled, which should be a
> valid thing to do.
>
> Tony, I see you added the DM_TIMER dependency in commit
> be26a008414414c69a4ae9fe9877401c3ba62c5a. I understand your motivation,
> but why not just use !(CONFIG_OMAP_32K_TIMER) here? Bit 9 of the idlect1
> is only for the TIMCK clock that is used for the MPU timers and not the
> DM_TIMERs.
Hmm yes looks like you're right. That check be done based on
!CONFIG_OMAP_32K_TIMER like you're saying.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Jon Hunter <jgchunter@gmail.com>
Cc: Paul Walmsley <paul@pwsan.com>, Jon Hunter <jonathanh@nvidia.com>,
linux-omap@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org,
"aaro.koskinen@iki.fi >> Aaro Koskinen" <aaro.koskinen@iki.fi>,
tuukka.tikkanen@linaro.org,
"khilman@deeprootsystems.com >> Kevin Hilman"
<khilman@deeprootsystems.com>,
"linux@arm.linux.org.uk >> Russell King" <linux@arm.linux.org.uk>
Subject: Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs
Date: Wed, 11 Feb 2015 12:26:12 -0800 [thread overview]
Message-ID: <20150211202611.GF2531@atomide.com> (raw)
In-Reply-To: <54DB93DA.8050308@gmail.com>
* Jon Hunter <jgchunter@gmail.com> [150211 09:43]:
>
> Thinking about this some more, I don't understand the dependency on the
> DM_TIMER here. For an omap1 device, regardless of whether the DM_TIMERs
> are enable or not, the device should be able to enter low power if the
> 32K is enabled. Hence, shouldn't this have been !(CONFIG_OMAP_32K_TIMER)
> above?
Sounds about right, there are separate timers on omap1 and additional
gp timers. There's no 32KiHz timer on 1510 variants, including
720 and 730.
> Furthermore, you will get the above warning on a omap16xx only build if
> you disable DM_TIMERs and keep MPU_TIMER enabled, which should be a
> valid thing to do.
>
> Tony, I see you added the DM_TIMER dependency in commit
> be26a008414414c69a4ae9fe9877401c3ba62c5a. I understand your motivation,
> but why not just use !(CONFIG_OMAP_32K_TIMER) here? Bit 9 of the idlect1
> is only for the TIMCK clock that is used for the MPU timers and not the
> DM_TIMERs.
Hmm yes looks like you're right. That check be done based on
!CONFIG_OMAP_32K_TIMER like you're saying.
Regards,
Tony
next prev parent reply other threads:[~2015-02-11 20:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 0:23 [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs Paul Walmsley
2015-02-07 0:23 ` Paul Walmsley
[not found] ` <54D9CFBC.3070405@nvidia.com>
2015-02-10 10:57 ` Jon Hunter
2015-02-10 10:57 ` Jon Hunter
2015-02-11 2:25 ` Paul Walmsley
2015-02-11 2:25 ` Paul Walmsley
2015-02-11 17:39 ` Jon Hunter
2015-02-11 17:39 ` Jon Hunter
2015-02-11 20:26 ` Tony Lindgren [this message]
2015-02-11 20:26 ` Tony Lindgren
2015-02-11 20:26 ` Tony Lindgren
2015-02-11 20:37 ` Tony Lindgren
2015-02-11 20:37 ` Tony Lindgren
2015-02-11 20:37 ` Tony Lindgren
2015-02-11 21:00 ` Paul Walmsley
2015-02-11 21:00 ` Paul Walmsley
2015-02-11 21:14 ` Tony Lindgren
2015-02-11 21:14 ` Tony Lindgren
2015-02-11 21:14 ` Tony Lindgren
2015-02-12 11:26 ` Jon Hunter
2015-02-12 11:26 ` Jon Hunter
2015-02-12 12:34 ` Jon Hunter
2015-02-12 12:34 ` Jon Hunter
2015-03-16 23:13 ` Tony Lindgren
2015-03-16 23:13 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150211202611.GF2531@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=jgchunter@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
--cc=tuukka.tikkanen@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.