From: Andrea Arcangeli <aarcange@redhat.com>
To: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
kirill@shutemov.name, mhocko@suse.cz, mgorman@suse.de,
rientjes@google.com, sasha.levin@oracle.com, hughd@google.com,
hannes@cmpxchg.org, vbabka@suse.cz, linux-kernel@vger.kernel.org,
riel@redhat.com
Subject: Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages
Date: Wed, 11 Feb 2015 23:16:00 +0100 [thread overview]
Message-ID: <20150211221600.GN11755@redhat.com> (raw)
In-Reply-To: <1423688635-4306-1-git-send-email-ebru.akagunduz@gmail.com>
On Wed, Feb 11, 2015 at 11:03:55PM +0200, Ebru Akagunduz wrote:
> Changes in v2:
> - Check zero pfn in release_pte_pages() (Andrea Arcangeli)
.. and in:
> @@ -2237,7 +2237,7 @@ static void __collapse_huge_page_copy(pte_t *pte, struct page *page,
> pte_t pteval = *_pte;
> struct page *src_page;
>
> - if (pte_none(pteval)) {
> + if (pte_none(pteval) || is_zero_pfn(pte_pfn(pteval))) {
> clear_user_highpage(page, address);
> add_mm_counter(vma->vm_mm, MM_ANONPAGES, 1);
> } else {
__collapse_huge_page_copy, both were needed as far as I can tell.
I haven't tested it but it's looking good.
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
kirill@shutemov.name, mhocko@suse.cz, mgorman@suse.de,
rientjes@google.com, sasha.levin@oracle.com, hughd@google.com,
hannes@cmpxchg.org, vbabka@suse.cz, linux-kernel@vger.kernel.org,
riel@redhat.com
Subject: Re: [PATCH v2] mm: incorporate zero pages into transparent huge pages
Date: Wed, 11 Feb 2015 23:16:00 +0100 [thread overview]
Message-ID: <20150211221600.GN11755@redhat.com> (raw)
In-Reply-To: <1423688635-4306-1-git-send-email-ebru.akagunduz@gmail.com>
On Wed, Feb 11, 2015 at 11:03:55PM +0200, Ebru Akagunduz wrote:
> Changes in v2:
> - Check zero pfn in release_pte_pages() (Andrea Arcangeli)
.. and in:
> @@ -2237,7 +2237,7 @@ static void __collapse_huge_page_copy(pte_t *pte, struct page *page,
> pte_t pteval = *_pte;
> struct page *src_page;
>
> - if (pte_none(pteval)) {
> + if (pte_none(pteval) || is_zero_pfn(pte_pfn(pteval))) {
> clear_user_highpage(page, address);
> add_mm_counter(vma->vm_mm, MM_ANONPAGES, 1);
> } else {
__collapse_huge_page_copy, both were needed as far as I can tell.
I haven't tested it but it's looking good.
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
next prev parent reply other threads:[~2015-02-11 22:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 21:03 [PATCH v2] mm: incorporate zero pages into transparent huge pages Ebru Akagunduz
2015-02-11 21:03 ` Ebru Akagunduz
2015-02-11 22:16 ` Andrea Arcangeli [this message]
2015-02-11 22:16 ` Andrea Arcangeli
2015-02-11 22:21 ` Kirill A. Shutemov
2015-02-11 22:21 ` Kirill A. Shutemov
2015-02-11 22:33 ` Andrea Arcangeli
2015-02-11 22:33 ` Andrea Arcangeli
2015-02-16 11:50 ` Vlastimil Babka
2015-02-16 11:50 ` Vlastimil Babka
2015-02-18 23:31 ` Andrew Morton
2015-02-18 23:31 ` Andrew Morton
2015-02-19 0:08 ` Rik van Riel
2015-02-19 0:08 ` Rik van Riel
2015-02-19 8:25 ` Vlastimil Babka
2015-02-19 8:25 ` Vlastimil Babka
2015-02-23 19:16 ` Andrew Morton
2015-02-23 19:16 ` Andrew Morton
2015-02-23 19:43 ` Rik van Riel
2015-02-23 19:43 ` Rik van Riel
2015-02-23 21:45 ` Vlastimil Babka
2015-02-23 21:45 ` Vlastimil Babka
2015-02-20 18:02 ` Andrea Arcangeli
2015-02-20 18:02 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150211221600.GN11755@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebru.akagunduz@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.