All of lore.kernel.org
 help / color / mirror / Atom feed
From: nsz@port70.net (Szabolcs Nagy)
To: linux-arm-kernel@lists.infradead.org
Subject: [musl] Re: [PATCHv3 00/24] ILP32 support in ARM64
Date: Thu, 12 Feb 2015 09:12:34 +0100	[thread overview]
Message-ID: <20150212081234.GL32724@port70.net> (raw)
In-Reply-To: <20150211190537.GK32724@port70.net>

* Szabolcs Nagy <nsz@port70.net> [2015-02-11 20:05:37 +0100]:
> 
> (i think this is also a problem if userspace code uses syscall(2) directly,
> libc cannot possibly know where to signextend and the kernel side does not
> do the fixup right now)
> 

nobody picked up this issue, is this resolved?

ie. if userspace calls syscall(SYS_foo,...) directly with 32bit
longs does it always work out correctly on the kernel side?

the sign extension is a problem for signed long arguments,
i only found these in the kernel:


fs/buffer.c:SYSCALL_DEFINE2(bdflush, int, func, long, data)

fs/open.c:SYSCALL_DEFINE2(truncate, const char __user *, path, long, length)

fs/aio.c:SYSCALL_DEFINE3(io_submit, aio_context_t, ctx_id, long, nr,
fs/aio.c-               struct iocb __user * __user *, iocbpp)

fs/aio.c:SYSCALL_DEFINE5(io_getevents, aio_context_t, ctx_id,
fs/aio.c-               long, min_nr,
fs/aio.c-               long, nr,

kernel/ptrace.c:SYSCALL_DEFINE4(ptrace, long, request, long, pid, unsigned long, addr,
kernel/ptrace.c-                unsigned long, data)

ipc/syscall.c:SYSCALL_DEFINE6(ipc, unsigned int, call, int, first, unsigned long, second,
ipc/syscall.c-          unsigned long, third, void __user *, ptr, long, fifth)

WARNING: multiple messages have this Message-ID (diff)
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com, Rich Felker <dalias@libc.org>,
	Andrew Pinski <apinski@cavium.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"pinskia@gmail.com" <pinskia@gmail.com>,
	"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
	Marcus Shawcroft <Marcus.Shawcroft@arm.com>
Subject: Re: [musl] Re: [PATCHv3 00/24] ILP32 support in ARM64
Date: Thu, 12 Feb 2015 09:12:34 +0100	[thread overview]
Message-ID: <20150212081234.GL32724@port70.net> (raw)
In-Reply-To: <20150211190537.GK32724@port70.net>

* Szabolcs Nagy <nsz@port70.net> [2015-02-11 20:05:37 +0100]:
> 
> (i think this is also a problem if userspace code uses syscall(2) directly,
> libc cannot possibly know where to signextend and the kernel side does not
> do the fixup right now)
> 

nobody picked up this issue, is this resolved?

ie. if userspace calls syscall(SYS_foo,...) directly with 32bit
longs does it always work out correctly on the kernel side?

the sign extension is a problem for signed long arguments,
i only found these in the kernel:


fs/buffer.c:SYSCALL_DEFINE2(bdflush, int, func, long, data)

fs/open.c:SYSCALL_DEFINE2(truncate, const char __user *, path, long, length)

fs/aio.c:SYSCALL_DEFINE3(io_submit, aio_context_t, ctx_id, long, nr,
fs/aio.c-               struct iocb __user * __user *, iocbpp)

fs/aio.c:SYSCALL_DEFINE5(io_getevents, aio_context_t, ctx_id,
fs/aio.c-               long, min_nr,
fs/aio.c-               long, nr,

kernel/ptrace.c:SYSCALL_DEFINE4(ptrace, long, request, long, pid, unsigned long, addr,
kernel/ptrace.c-                unsigned long, data)

ipc/syscall.c:SYSCALL_DEFINE6(ipc, unsigned int, call, int, first, unsigned long, second,
ipc/syscall.c-          unsigned long, third, void __user *, ptr, long, fifth)

  parent reply	other threads:[~2015-02-12  8:12 UTC|newest]

Thread overview: 154+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03 21:18 [PATCHv3 00/24] ILP32 support in ARM64 Andrew Pinski
2014-09-03 21:18 ` Andrew Pinski
2014-09-03 21:18 ` [PATCH 01/24] ARM64: Force LP64 to compile the kernel Andrew Pinski
2014-09-03 21:18   ` Andrew Pinski
2014-09-03 21:18 ` [PATCH 02/24] ARM64: Rename COMPAT to AARCH32_EL0 in Kconfig Andrew Pinski
2014-09-03 21:18   ` Andrew Pinski
2014-09-03 21:18 ` [PATCH 03/24] ARM64: Change some CONFIG_COMPAT over to use CONFIG_AARCH32_EL0 instead Andrew Pinski
2014-09-03 21:18   ` Andrew Pinski
2014-09-03 21:18 ` [PATCH 04/24] ARM64:ILP32: Set kernel_long to long long so we can reuse most of the same syscalls as LP64 Andrew Pinski
2014-09-03 21:18   ` Andrew Pinski
2014-09-03 21:18 ` [PATCH 05/24] ARM64:UAPI: Set the correct __BITS_PER_LONG for ILP32 Andrew Pinski
2014-09-03 21:18   ` Andrew Pinski
2014-09-03 21:19 ` [PATCH 06/24] Allow for some signal structures to be the same between a 32bit ABI and the 64bit ABI Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-03 21:19 ` [PATCH 07/24] ARM64:ILP32: Use the same size and layout of the signal structures for ILP32 as for LP64 Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-18  3:41   ` zhangjian
2014-09-18  3:41     ` zhangjian
2014-09-03 21:19 ` [PATCH 08/24] Allow a 32bit ABI to use the naming of the 64bit ABI syscalls to avoid confusion of not splitting the registers Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-04 10:11   ` Arnd Bergmann
2014-09-04 10:11     ` Arnd Bergmann
2014-10-01 12:42     ` Catalin Marinas
2014-10-01 12:42       ` Catalin Marinas
2014-10-01 14:00       ` Arnd Bergmann
2014-10-01 14:00         ` Arnd Bergmann
2014-10-02 11:19         ` Catalin Marinas
2014-10-02 11:19           ` Catalin Marinas
2014-09-03 21:19 ` [PATCH 09/24] ARM64:ILP32: Use the same syscall names as LP64 Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-10-01 12:48   ` Catalin Marinas
2014-10-01 12:48     ` Catalin Marinas
2014-09-03 21:19 ` [PATCH 10/24] ARM64: Introduce is_a32_task/is_a32_thread and TIF_AARCH32 and use them in the correct locations Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-03 21:19 ` [PATCH 11/24] ARM64: Add is_ilp32_compat_task and is_ilp32_compat_thread Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-03 21:19 ` [PATCH 12/24] ARM64:ILP32: COMPAT_USE_64BIT_TIME is true for ILP32 tasks Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-03 21:19 ` [PATCH 13/24] ARM64:ILP32: Use the non compat HWCAP for ILP32 Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-10-01 13:12   ` Catalin Marinas
2014-10-01 13:12     ` Catalin Marinas
2014-09-03 21:19 ` [PATCH 14/24] ARM64:ILP32 use the standard start_thread for ILP32 so the processor state is not AARCH32 Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-03 21:19 ` [PATCH 15/24] compat_binfmt_elf: coredump: Allow some core dump macros be overridden for compat Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-03 21:19 ` [PATCH 16/24] ARM64:ILP32: Support core dump for ILP32 Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-10-01 13:22   ` Catalin Marinas
2014-10-01 13:22     ` Catalin Marinas
2014-09-03 21:19 ` [PATCH 17/24] ARM64: Add loading of ILP32 binaries Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-03 21:19 ` [PATCH 18/24] ARM64: Add vdso for ILP32 and use it for the signal return Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-10 14:31   ` Christopher Covington
2014-09-10 14:31     ` Christopher Covington
2014-10-01 13:59   ` Catalin Marinas
2014-10-01 13:59     ` Catalin Marinas
2014-10-02 13:38   ` Catalin Marinas
2014-10-02 13:38     ` Catalin Marinas
2014-09-03 21:19 ` [PATCH 19/24] ptrace: Allow compat to use the native siginfo Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-10-02 14:13   ` Catalin Marinas
2014-10-02 14:13     ` Catalin Marinas
2014-09-03 21:19 ` [PATCH 20/24] ARM64:ILP32: The native siginfo is used instead of the compat siginfo Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-03 21:19 ` [PATCH 21/24] ARM64:ILP32: Use a seperate syscall table as a few syscalls need to be using the compat syscalls Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-10-02 15:23   ` Catalin Marinas
2014-10-02 15:23     ` Catalin Marinas
2014-10-02 15:46   ` Catalin Marinas
2014-10-02 15:46     ` Catalin Marinas
2014-09-03 21:19 ` [PATCH 22/24] ARM64:ILP32: Fix signal return for ILP32 when the user modified the signal stack Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-03 21:19 ` [PATCH 23/24] ARM64: Add ARM64_ILP32 to Kconfig Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-03 21:19 ` [PATCH 24/24] Add documentation about ARM64 ILP32 ABI Andrew Pinski
2014-09-03 21:19   ` Andrew Pinski
2014-09-04 10:01   ` Arnd Bergmann
2014-09-04 10:01     ` Arnd Bergmann
2014-10-02 15:52 ` [PATCHv3 00/24] ILP32 support in ARM64 Catalin Marinas
2014-10-02 15:52   ` Catalin Marinas
2015-02-10 18:13   ` Rich Felker
2015-02-10 18:13     ` Rich Felker
2015-02-11 17:39     ` Catalin Marinas
2015-02-11 17:39       ` Catalin Marinas
2015-02-11 19:05       ` [musl] " Szabolcs Nagy
2015-02-11 19:05         ` Szabolcs Nagy
2015-02-11 19:22         ` H.J. Lu
2015-02-11 19:22           ` H.J. Lu
2015-02-11 19:50         ` arnd at arndb.de
2015-02-11 19:50           ` arnd
2015-02-11 20:12           ` Rich Felker
2015-02-11 20:12             ` Rich Felker
     [not found]             ` <1383502854.512344.1423688575473.JavaMail.open-xchange@oxbaltgw09.schlund.de>
2015-02-11 21:09               ` arnd at arndb.de
2015-02-11 21:09                 ` arnd
2015-02-11 21:37               ` Rich Felker
2015-02-11 21:37                 ` Rich Felker
2015-02-16 17:20                 ` Arnd Bergmann
2015-02-16 17:20                   ` Arnd Bergmann
2015-02-16 17:51                   ` Rich Felker
2015-02-16 17:51                     ` Rich Felker
2015-02-16 19:38                     ` Arnd Bergmann
2015-02-16 19:38                       ` Arnd Bergmann
2015-02-12  8:12         ` Szabolcs Nagy [this message]
2015-02-12  8:12           ` Szabolcs Nagy
2015-02-12 17:07           ` Catalin Marinas
2015-02-12 17:07             ` Catalin Marinas
2015-02-11 19:21       ` Rich Felker
2015-02-11 19:21         ` Rich Felker
2015-02-12 18:17         ` Catalin Marinas
2015-02-12 18:17           ` Catalin Marinas
2015-02-12 18:59           ` arnd at arndb.de
2015-02-12 18:59             ` arnd
2015-02-13 13:33             ` Catalin Marinas
2015-02-13 13:33               ` Catalin Marinas
2015-02-13 16:30               ` Rich Felker
2015-02-13 16:30                 ` Rich Felker
2015-02-13 17:33                 ` Catalin Marinas
2015-02-13 17:33                   ` Catalin Marinas
2015-02-13 18:37                   ` Rich Felker
2015-02-13 18:37                     ` Rich Felker
2015-02-16 14:40                     ` Arnd Bergmann
2015-02-16 14:40                       ` Arnd Bergmann
2015-02-16 15:38                       ` Rich Felker
2015-02-16 15:38                         ` Rich Felker
2015-02-16 16:54                         ` Arnd Bergmann
2015-02-16 16:54                           ` Arnd Bergmann
2015-02-11 18:33     ` H.J. Lu
2015-02-11 18:33       ` H.J. Lu
2015-02-11 19:02       ` Rich Felker
2015-02-11 19:02         ` Rich Felker
2015-02-11 19:16         ` H.J. Lu
2015-02-11 19:16           ` H.J. Lu
2015-02-11 19:25           ` Rich Felker
2015-02-11 19:25             ` Rich Felker
2015-02-11 19:34             ` H.J. Lu
2015-02-11 19:34               ` H.J. Lu
2015-02-11 19:47               ` Rich Felker
2015-02-11 19:47                 ` Rich Felker
2015-02-11 19:57                 ` H.J. Lu
2015-02-11 19:57                   ` H.J. Lu
2015-02-11 20:15                   ` Andy Lutomirski
2015-02-11 20:15                     ` Andy Lutomirski
2015-02-12 15:50                     ` Catalin Marinas
2015-02-12 15:50                       ` Catalin Marinas
2015-02-12 16:13                       ` Rich Felker
2015-02-12 16:13                         ` Rich Felker
2015-02-12 16:30                       ` H.J. Lu
2015-02-12 16:30                         ` H.J. Lu
2015-02-12 17:00                         ` Rich Felker
2015-02-12 17:00                           ` Rich Felker
2015-02-11 21:41         ` Joseph Myers
2015-02-11 21:41           ` Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150212081234.GL32724@port70.net \
    --to=nsz@port70.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.