All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: kbuild-all@01.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH aa] userfaultfd: double_down_read() can be static
Date: Thu, 12 Feb 2015 16:54:04 +0800	[thread overview]
Message-ID: <20150212085404.GA52934@snb> (raw)
In-Reply-To: <201502121644.mekdzvbV%fengguang.wu@intel.com>

mm/userfaultfd.c:48:6: sparse: symbol 'double_down_read' was not declared. Should it be static?
mm/userfaultfd.c:67:6: sparse: symbol 'double_up_read' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 userfaultfd.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
index d1e89ef..88b2650 100644
--- a/mm/userfaultfd.c
+++ b/mm/userfaultfd.c
@@ -45,7 +45,7 @@ void double_pt_unlock(spinlock_t *ptl1,
 		spin_unlock(ptl2);
 }
 
-void double_down_read(struct rw_semaphore *mm1,
+static void double_down_read(struct rw_semaphore *mm1,
 		      struct rw_semaphore *mm2)
 	__acquires(mm1)
 	__acquires(mm2)
@@ -64,7 +64,7 @@ void double_down_read(struct rw_semaphore *mm1,
 		down_read_nested(mm2, SINGLE_DEPTH_NESTING);
 }
 
-void double_up_read(struct rw_semaphore *mm1,
+static void double_up_read(struct rw_semaphore *mm1,
 		    struct rw_semaphore *mm2)
 	__releases(mm1)
 	__releases(mm2)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <fengguang.wu@intel.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: kbuild-all@01.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH aa] userfaultfd: double_down_read() can be static
Date: Thu, 12 Feb 2015 16:54:04 +0800	[thread overview]
Message-ID: <20150212085404.GA52934@snb> (raw)
In-Reply-To: <201502121644.mekdzvbV%fengguang.wu@intel.com>

mm/userfaultfd.c:48:6: sparse: symbol 'double_down_read' was not declared. Should it be static?
mm/userfaultfd.c:67:6: sparse: symbol 'double_up_read' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 userfaultfd.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
index d1e89ef..88b2650 100644
--- a/mm/userfaultfd.c
+++ b/mm/userfaultfd.c
@@ -45,7 +45,7 @@ void double_pt_unlock(spinlock_t *ptl1,
 		spin_unlock(ptl2);
 }
 
-void double_down_read(struct rw_semaphore *mm1,
+static void double_down_read(struct rw_semaphore *mm1,
 		      struct rw_semaphore *mm2)
 	__acquires(mm1)
 	__acquires(mm2)
@@ -64,7 +64,7 @@ void double_down_read(struct rw_semaphore *mm1,
 		down_read_nested(mm2, SINGLE_DEPTH_NESTING);
 }
 
-void double_up_read(struct rw_semaphore *mm1,
+static void double_up_read(struct rw_semaphore *mm1,
 		    struct rw_semaphore *mm2)
 	__releases(mm1)
 	__releases(mm2)

  reply	other threads:[~2015-02-12  8:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12  8:54 [aa:userfault 17/19] mm/userfaultfd.c:48:6: sparse: symbol 'double_down_read' was not declared. Should it be static? kbuild test robot
2015-02-12  8:54 ` kbuild test robot
2015-02-12  8:54 ` kbuild test robot [this message]
2015-02-12  8:54   ` [PATCH aa] userfaultfd: double_down_read() can be static kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150212085404.GA52934@snb \
    --to=fengguang.wu@intel.com \
    --cc=aarcange@redhat.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.