From: Oleg Nesterov <oleg@redhat.com>
To: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Cc: jeremy@goop.org, kvm@vger.kernel.org, peterz@infradead.org,
virtualization@lists.linux-foundation.org,
paul.gortmaker@windriver.com, hpa@zytor.com, ak@linux.intel.com,
a.ryabinin@samsung.com, x86@kernel.org, borntraeger@de.ibm.com,
mingo@redhat.com, xen-devel@lists.xenproject.org,
paulmck@linux.vnet.ibm.com, riel@redhat.com,
konrad.wilk@oracle.com, dave@stgolabs.net,
sasha.levin@oracle.com, davej@redhat.com, tglx@linutronix.de,
waiman.long@hp.com, linux-kernel@vger.kernel.org,
pbonzini@redhat.com, akpm@linux-foundation.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH V3] x86 spinlock: Fix memory corruption on completing completions
Date: Thu, 12 Feb 2015 14:37:07 +0100 [thread overview]
Message-ID: <20150212133707.GA10232@redhat.com> (raw)
In-Reply-To: <1423741647-2156-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com>
On 02/12, Raghavendra K T wrote:
>
> @@ -772,7 +773,8 @@ __visible void kvm_lock_spinning(struct arch_spinlock *lock, __ticket_t want)
> * check again make sure it didn't become free while
> * we weren't looking.
> */
> - if (ACCESS_ONCE(lock->tickets.head) == want) {
> + head = ACCESS_ONCE(lock->tickets.head);
> + if (__tickets_equal(head, want)) {
> add_stats(TAKEN_SLOW_PICKUP, 1);
While at it, perhaps it makes sense to s/ACCESS_ONCE/READ_ONCE/ but this
is cosmetic.
We also need to change another user of enter_slow_path, xen_lock_spinning()
in arch/x86/xen/spinlock.c.
Other than that looks correct at first glance... but this is up to
maintainers.
Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
peterz@infradead.org, torvalds@linux-foundation.org,
konrad.wilk@oracle.com, pbonzini@redhat.com,
paulmck@linux.vnet.ibm.com, waiman.long@hp.com, davej@redhat.com,
x86@kernel.org, jeremy@goop.org, paul.gortmaker@windriver.com,
ak@linux.intel.com, jasowang@redhat.com,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
xen-devel@lists.xenproject.org, riel@redhat.com,
borntraeger@de.ibm.com, akpm@linux-foundation.org,
a.ryabinin@samsung.com, sasha.levin@oracle.com,
dave@stgolabs.net
Subject: Re: [PATCH V3] x86 spinlock: Fix memory corruption on completing completions
Date: Thu, 12 Feb 2015 14:37:07 +0100 [thread overview]
Message-ID: <20150212133707.GA10232@redhat.com> (raw)
In-Reply-To: <1423741647-2156-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com>
On 02/12, Raghavendra K T wrote:
>
> @@ -772,7 +773,8 @@ __visible void kvm_lock_spinning(struct arch_spinlock *lock, __ticket_t want)
> * check again make sure it didn't become free while
> * we weren't looking.
> */
> - if (ACCESS_ONCE(lock->tickets.head) == want) {
> + head = ACCESS_ONCE(lock->tickets.head);
> + if (__tickets_equal(head, want)) {
> add_stats(TAKEN_SLOW_PICKUP, 1);
While at it, perhaps it makes sense to s/ACCESS_ONCE/READ_ONCE/ but this
is cosmetic.
We also need to change another user of enter_slow_path, xen_lock_spinning()
in arch/x86/xen/spinlock.c.
Other than that looks correct at first glance... but this is up to
maintainers.
Oleg.
next prev parent reply other threads:[~2015-02-12 13:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 11:47 [PATCH V3] x86 spinlock: Fix memory corruption on completing completions Raghavendra K T
2015-02-12 11:47 ` Raghavendra K T
2015-02-12 11:47 ` Raghavendra K T
2015-02-12 13:37 ` Oleg Nesterov [this message]
2015-02-12 13:37 ` Oleg Nesterov
2015-02-12 14:21 ` Raghavendra K T
2015-02-12 14:21 ` Raghavendra K T
2015-02-12 14:21 ` Raghavendra K T
2015-02-12 13:37 ` Oleg Nesterov
2015-02-12 13:50 ` Oleg Nesterov
2015-02-12 13:50 ` Oleg Nesterov
2015-02-12 13:50 ` Oleg Nesterov
2015-02-12 14:23 ` Raghavendra K T
2015-02-12 14:23 ` Raghavendra K T
2015-02-12 14:23 ` Raghavendra K T
2015-02-12 14:02 ` Oleg Nesterov
2015-02-12 14:02 ` Oleg Nesterov
2015-02-12 14:25 ` Raghavendra K T
2015-02-12 14:25 ` Raghavendra K T
2015-02-12 14:25 ` Raghavendra K T
2015-02-12 14:02 ` Oleg Nesterov
2015-02-12 15:00 ` Peter Zijlstra
2015-02-12 15:00 ` Peter Zijlstra
2015-02-12 15:28 ` Raghavendra K T
2015-02-12 15:28 ` Raghavendra K T
2015-02-12 15:28 ` Raghavendra K T
2015-02-12 15:00 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2015-02-12 11:47 Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150212133707.GA10232@redhat.com \
--to=oleg@redhat.com \
--cc=a.ryabinin@samsung.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=dave@stgolabs.net \
--cc=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=waiman.long@hp.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.