From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Ondrej Kozina <okozina@redhat.com>,
dm-devel@redhat.com, "Alasdair G. Kergon" <agk@redhat.com>,
Milan Broz <mbroz@redhat.com>
Subject: Re: [PATCH 3/7] dm-crypt: avoid deadlock in mempools
Date: Fri, 13 Feb 2015 20:14:46 -0500 [thread overview]
Message-ID: <20150214011445.GA14223@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1502131708030.447@file01.intranet.prod.int.rdu2.redhat.com>
On Fri, Feb 13 2015 at 5:09P -0500,
Mikulas Patocka <mpatocka@redhat.com> wrote:
>
>
> On Fri, 13 Feb 2015, Mike Snitzer wrote:
>
> > * In order to not degrade performance with excessive locking, we try
> > - * non-blocking allocations without a mutex first and if it fails, we fallback
> > + * non-blocking allocation without a mutex first and if it fails, we fallback
> > * to a blocking allocation with a mutex.
> > */
> > static struct bio *crypt_alloc_buffer(struct dm_crypt_io *io, unsigned size)
>
> There are multiple allocations, so I would leave plural there.
Fixed, and tweaked the headers (already did that last time around so
nothing new, you just didn't pick up my headers for your v2). I pushed
your patchset to linux-next (for 3.21), see:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/log/?h=for-next
Ondrej and Milan, please let us know if you hit any problems with this
patchset and/or branch.
next prev parent reply other threads:[~2015-02-14 1:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 13:24 [PATCH 3/7] dm-crypt: avoid deadlock in mempools Mikulas Patocka
2015-02-13 21:16 ` Mike Snitzer
2015-02-13 22:09 ` Mikulas Patocka
2015-02-14 1:14 ` Mike Snitzer [this message]
2015-02-16 9:31 ` Milan Broz
2015-02-16 13:58 ` Mike Snitzer
2015-02-16 14:11 ` Ondrej Kozina
2015-02-16 16:29 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150214011445.GA14223@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mbroz@redhat.com \
--cc=mpatocka@redhat.com \
--cc=okozina@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.