* [Buildroot] [PATCH] rpi-firmware: keep fixup.dat and start.elf name
@ 2015-02-14 22:49 Frank Hunleth
2015-02-14 23:43 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Frank Hunleth @ 2015-02-14 22:49 UTC (permalink / raw)
To: buildroot
When enabling the RPi camera (start_x=1 in the config.txt), the start_x.elf
file needs to remain called start_x.elf. Installing it as start.elf
creates an image that won't boot. This change installs the files without
changing their names.
Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com>
---
package/rpi-firmware/rpi-firmware.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
index 03178d5..e526063 100644
--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -28,8 +28,8 @@ endif
define RPI_FIRMWARE_INSTALL_IMAGES_CMDS
$(INSTALL) -D -m 0644 $(@D)/boot/bootcode.bin $(BINARIES_DIR)/rpi-firmware/bootcode.bin
- $(INSTALL) -D -m 0644 $(@D)/boot/start$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).elf $(BINARIES_DIR)/rpi-firmware/start.elf
- $(INSTALL) -D -m 0644 $(@D)/boot/fixup$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).dat $(BINARIES_DIR)/rpi-firmware/fixup.dat
+ $(INSTALL) -D -m 0644 $(@D)/boot/start$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).elf $(BINARIES_DIR)/rpi-firmware/start$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).elf
+ $(INSTALL) -D -m 0644 $(@D)/boot/fixup$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).dat $(BINARIES_DIR)/rpi-firmware/fixup$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).dat
$(INSTALL) -D -m 0644 package/rpi-firmware/config.txt $(BINARIES_DIR)/rpi-firmware/config.txt
$(INSTALL) -D -m 0644 package/rpi-firmware/cmdline.txt $(BINARIES_DIR)/rpi-firmware/cmdline.txt
$(RPI_FIRMWARE_INSTALL_DTB)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] rpi-firmware: keep fixup.dat and start.elf name
2015-02-14 22:49 [Buildroot] [PATCH] rpi-firmware: keep fixup.dat and start.elf name Frank Hunleth
@ 2015-02-14 23:43 ` Yann E. MORIN
2015-02-15 0:45 ` Frank Hunleth
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2015-02-14 23:43 UTC (permalink / raw)
To: buildroot
Frank, All,
On 2015-02-14 17:49 -0500, Frank Hunleth spake thusly:
> When enabling the RPi camera (start_x=1 in the config.txt), the start_x.elf
> file needs to remain called start_x.elf. Installing it as start.elf
> creates an image that won't boot. This change installs the files without
> changing their names.
>
> Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com>
NAK.
I just tried booting my RPi (model B, the original) with just start_x.elf
and fixup_x.dat (instead of start.elf and fixup.dat), and it does not
boot.
So, clearly, that's not the proper fix.
Regards,
Yann E. MORIN.
> ---
> package/rpi-firmware/rpi-firmware.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index 03178d5..e526063 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -28,8 +28,8 @@ endif
>
> define RPI_FIRMWARE_INSTALL_IMAGES_CMDS
> $(INSTALL) -D -m 0644 $(@D)/boot/bootcode.bin $(BINARIES_DIR)/rpi-firmware/bootcode.bin
> - $(INSTALL) -D -m 0644 $(@D)/boot/start$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).elf $(BINARIES_DIR)/rpi-firmware/start.elf
> - $(INSTALL) -D -m 0644 $(@D)/boot/fixup$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).dat $(BINARIES_DIR)/rpi-firmware/fixup.dat
> + $(INSTALL) -D -m 0644 $(@D)/boot/start$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).elf $(BINARIES_DIR)/rpi-firmware/start$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).elf
> + $(INSTALL) -D -m 0644 $(@D)/boot/fixup$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).dat $(BINARIES_DIR)/rpi-firmware/fixup$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).dat
> $(INSTALL) -D -m 0644 package/rpi-firmware/config.txt $(BINARIES_DIR)/rpi-firmware/config.txt
> $(INSTALL) -D -m 0644 package/rpi-firmware/cmdline.txt $(BINARIES_DIR)/rpi-firmware/cmdline.txt
> $(RPI_FIRMWARE_INSTALL_DTB)
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] rpi-firmware: keep fixup.dat and start.elf name
2015-02-14 23:43 ` Yann E. MORIN
@ 2015-02-15 0:45 ` Frank Hunleth
2015-02-15 1:25 ` Frank Hunleth
0 siblings, 1 reply; 4+ messages in thread
From: Frank Hunleth @ 2015-02-15 0:45 UTC (permalink / raw)
To: buildroot
Yann,
On Sat, Feb 14, 2015 at 6:43 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Frank, All,
>
> On 2015-02-14 17:49 -0500, Frank Hunleth spake thusly:
>> When enabling the RPi camera (start_x=1 in the config.txt), the start_x.elf
>> file needs to remain called start_x.elf. Installing it as start.elf
>> creates an image that won't boot. This change installs the files without
>> changing their names.
>>
>> Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com>
>
> NAK.
>
> I just tried booting my RPi (model B, the original) with just start_x.elf
> and fixup_x.dat (instead of start.elf and fixup.dat), and it does not
> boot.
Did you put "start_x=1" in your config.txt?
> So, clearly, that's not the proper fix.
Here's what I'm seeing:
no start_x=1, start_x.elf renamed as start.elf -> boots, but no camera
no start_x=1, start_x.elf -> doesn't boot (your setup, I think)
start_x=1, start.elf -> doesn't boot
start_x=1, start_x.elf -> boots and camera works
I'm certainly open to other solutions. Well, I guess that I'd prefer
to not rename start.elf back to start_x.elf in a post build step, but
if there's another option, I'd take it. The Raspberry Pi docs that
I've found so far on this seem pretty light.
Thanks,
Frank
>
> Regards,
> Yann E. MORIN.
>
>> ---
>> package/rpi-firmware/rpi-firmware.mk | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
>> index 03178d5..e526063 100644
>> --- a/package/rpi-firmware/rpi-firmware.mk
>> +++ b/package/rpi-firmware/rpi-firmware.mk
>> @@ -28,8 +28,8 @@ endif
>>
>> define RPI_FIRMWARE_INSTALL_IMAGES_CMDS
>> $(INSTALL) -D -m 0644 $(@D)/boot/bootcode.bin $(BINARIES_DIR)/rpi-firmware/bootcode.bin
>> - $(INSTALL) -D -m 0644 $(@D)/boot/start$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).elf $(BINARIES_DIR)/rpi-firmware/start.elf
>> - $(INSTALL) -D -m 0644 $(@D)/boot/fixup$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).dat $(BINARIES_DIR)/rpi-firmware/fixup.dat
>> + $(INSTALL) -D -m 0644 $(@D)/boot/start$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).elf $(BINARIES_DIR)/rpi-firmware/start$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).elf
>> + $(INSTALL) -D -m 0644 $(@D)/boot/fixup$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).dat $(BINARIES_DIR)/rpi-firmware/fixup$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).dat
>> $(INSTALL) -D -m 0644 package/rpi-firmware/config.txt $(BINARIES_DIR)/rpi-firmware/config.txt
>> $(INSTALL) -D -m 0644 package/rpi-firmware/cmdline.txt $(BINARIES_DIR)/rpi-firmware/cmdline.txt
>> $(RPI_FIRMWARE_INSTALL_DTB)
>> --
>> 1.9.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
--
Frank Hunleth
Troodon Software LLC
Embedded Software Development
http://troodon-software.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] rpi-firmware: keep fixup.dat and start.elf name
2015-02-15 0:45 ` Frank Hunleth
@ 2015-02-15 1:25 ` Frank Hunleth
0 siblings, 0 replies; 4+ messages in thread
From: Frank Hunleth @ 2015-02-15 1:25 UTC (permalink / raw)
To: buildroot
Yann,
On Sat, Feb 14, 2015 at 7:45 PM, Frank Hunleth
<fhunleth@troodon-software.com> wrote:
> Yann,
>
> On Sat, Feb 14, 2015 at 6:43 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>> Frank, All,
>>
>> On 2015-02-14 17:49 -0500, Frank Hunleth spake thusly:
>>> When enabling the RPi camera (start_x=1 in the config.txt), the start_x.elf
>>> file needs to remain called start_x.elf. Installing it as start.elf
>>> creates an image that won't boot. This change installs the files without
>>> changing their names.
>>>
>>> Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com>
>>
>> NAK.
>>
>> I just tried booting my RPi (model B, the original) with just start_x.elf
>> and fixup_x.dat (instead of start.elf and fixup.dat), and it does not
>> boot.
>
> Did you put "start_x=1" in your config.txt?
>
>> So, clearly, that's not the proper fix.
>
> Here's what I'm seeing:
>
> no start_x=1, start_x.elf renamed as start.elf -> boots, but no camera
I just retested this configuration, and the camera is working now.
Sigh. That means that I don't need the patch that I just submitted. I
have no clue how I was able to reproduce the issue a few times, but
now I can't. Anyway, thanks for checking it out so quickly and sorry
for the noise.
Frank
> no start_x=1, start_x.elf -> doesn't boot (your setup, I think)
> start_x=1, start.elf -> doesn't boot
> start_x=1, start_x.elf -> boots and camera works
>
> I'm certainly open to other solutions. Well, I guess that I'd prefer
> to not rename start.elf back to start_x.elf in a post build step, but
> if there's another option, I'd take it. The Raspberry Pi docs that
> I've found so far on this seem pretty light.
>
> Thanks,
> Frank
>
>>
>> Regards,
>> Yann E. MORIN.
>>
>>> ---
>>> package/rpi-firmware/rpi-firmware.mk | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
>>> index 03178d5..e526063 100644
>>> --- a/package/rpi-firmware/rpi-firmware.mk
>>> +++ b/package/rpi-firmware/rpi-firmware.mk
>>> @@ -28,8 +28,8 @@ endif
>>>
>>> define RPI_FIRMWARE_INSTALL_IMAGES_CMDS
>>> $(INSTALL) -D -m 0644 $(@D)/boot/bootcode.bin $(BINARIES_DIR)/rpi-firmware/bootcode.bin
>>> - $(INSTALL) -D -m 0644 $(@D)/boot/start$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).elf $(BINARIES_DIR)/rpi-firmware/start.elf
>>> - $(INSTALL) -D -m 0644 $(@D)/boot/fixup$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).dat $(BINARIES_DIR)/rpi-firmware/fixup.dat
>>> + $(INSTALL) -D -m 0644 $(@D)/boot/start$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).elf $(BINARIES_DIR)/rpi-firmware/start$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).elf
>>> + $(INSTALL) -D -m 0644 $(@D)/boot/fixup$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).dat $(BINARIES_DIR)/rpi-firmware/fixup$(BR2_PACKAGE_RPI_FIRMWARE_BOOT).dat
>>> $(INSTALL) -D -m 0644 package/rpi-firmware/config.txt $(BINARIES_DIR)/rpi-firmware/config.txt
>>> $(INSTALL) -D -m 0644 package/rpi-firmware/cmdline.txt $(BINARIES_DIR)/rpi-firmware/cmdline.txt
>>> $(RPI_FIRMWARE_INSTALL_DTB)
>>> --
>>> 1.9.1
>>>
>>> _______________________________________________
>>> buildroot mailing list
>>> buildroot at busybox.net
>>> http://lists.busybox.net/mailman/listinfo/buildroot
>>
>> --
>> .-----------------.--------------------.------------------.--------------------.
>> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
>> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
>> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
>> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
>> '------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-15 1:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-14 22:49 [Buildroot] [PATCH] rpi-firmware: keep fixup.dat and start.elf name Frank Hunleth
2015-02-14 23:43 ` Yann E. MORIN
2015-02-15 0:45 ` Frank Hunleth
2015-02-15 1:25 ` Frank Hunleth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.