All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: lkp@lists.01.org
Subject: Re: [sched] BUG: kernel boot hang
Date: Sun, 15 Feb 2015 16:46:22 +0100	[thread overview]
Message-ID: <20150215154620.GC8838@lerouge> (raw)
In-Reply-To: <1423986208.5538.5.camel@intel.com>

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

On Sun, Feb 15, 2015 at 03:43:28PM +0800, Huang Ying wrote:
> FYI, we noticed the below changes on
> 
> commit a18b5d01819235629289212ad428a5ee2b40f0d9 ("sched: Fix missing preemption opportunity")

Huang,

Can you please test the following patch and check if it still crashes?

Thanks.


diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index c017a5f..a6d4d6c 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2879,7 +2879,7 @@ void __sched schedule_preempt_disabled(void)
 	preempt_disable();
 }
 
-static void preempt_schedule_common(void)
+static void __sched notrace preempt_schedule_common(void)
 {
 	do {
 		preempt_count_add(PREEMPT_ACTIVE);


WARNING: multiple messages have this Message-ID (diff)
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, LKP ML <lkp@01.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [LKP] [sched] BUG: kernel boot hang
Date: Sun, 15 Feb 2015 16:46:22 +0100	[thread overview]
Message-ID: <20150215154620.GC8838@lerouge> (raw)
In-Reply-To: <1423986208.5538.5.camel@intel.com>

On Sun, Feb 15, 2015 at 03:43:28PM +0800, Huang Ying wrote:
> FYI, we noticed the below changes on
> 
> commit a18b5d01819235629289212ad428a5ee2b40f0d9 ("sched: Fix missing preemption opportunity")

Huang,

Can you please test the following patch and check if it still crashes?

Thanks.


diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index c017a5f..a6d4d6c 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2879,7 +2879,7 @@ void __sched schedule_preempt_disabled(void)
 	preempt_disable();
 }
 
-static void preempt_schedule_common(void)
+static void __sched notrace preempt_schedule_common(void)
 {
 	do {
 		preempt_count_add(PREEMPT_ACTIVE);


  parent reply	other threads:[~2015-02-15 15:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-15  7:43 [sched] BUG: kernel boot hang Huang Ying
2015-02-15  7:43 ` [LKP] " Huang Ying
2015-02-15 15:31 ` Frederic Weisbecker
2015-02-15 15:31   ` [LKP] " Frederic Weisbecker
2015-02-15 15:38 ` Frederic Weisbecker
2015-02-15 15:38   ` [LKP] " Frederic Weisbecker
2015-02-15 15:46 ` Frederic Weisbecker [this message]
2015-02-15 15:46   ` Frederic Weisbecker
2015-02-15 18:18   ` Steven Rostedt
2015-02-15 18:18     ` [LKP] " Steven Rostedt
2015-02-16 15:07     ` Peter Zijlstra
2015-02-16 15:07       ` [LKP] " Peter Zijlstra
2015-02-16 18:22       ` Frederic Weisbecker
2015-02-16 18:22         ` [LKP] " Frederic Weisbecker
2015-02-16 18:34         ` Steven Rostedt
2015-02-16 18:34           ` [LKP] " Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150215154620.GC8838@lerouge \
    --to=fweisbec@gmail.com \
    --cc=lkp@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.