Recent commit introduces compiler Error in some platforms

Recent commit introduces compiler Error in some platforms

[Luis de Bethencourt]

Hi all,

As can be seen in Han's build log:
http://hverkuil.home.xs4all.nl/logs/Saturday.log

The recent commit bc0c5aa35ac88342831933ca7758ead62d9bae2b introduces a
compiler error in some platforms.

/home/hans/work/build/media_build/v4l/ir-hix5hd2.c: In function 'hix5hd2_ir_config':
/home/hans/work/build/media_build/v4l/ir-hix5hd2.c:95:2: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
  writel_relaxed(0x01, priv->base + IR_ENABLE);
  ^

Better than reverting, what would be a good solution for this problem?
I am happy to implment it once I know what is the right direction.

>From what I see that commit mentions that the function is now available from
include/asm-generic/io.h, but this isn't included.

Thanks,
Luis

Re: Recent commit introduces compiler Error in some platforms

[Hans Verkuil]

On 02/16/2015 01:18 PM, Luis de Bethencourt wrote:
> Hi all,
> 
> As can be seen in Han's build log:
> http://hverkuil.home.xs4all.nl/logs/Saturday.log
> 
> The recent commit bc0c5aa35ac88342831933ca7758ead62d9bae2b introduces a
> compiler error in some platforms.
> 
> /home/hans/work/build/media_build/v4l/ir-hix5hd2.c: In function 'hix5hd2_ir_config':
> /home/hans/work/build/media_build/v4l/ir-hix5hd2.c:95:2: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
>   writel_relaxed(0x01, priv->base + IR_ENABLE);
>   ^
> 
> Better than reverting, what would be a good solution for this problem?
> I am happy to implment it once I know what is the right direction.
> 
> From what I see that commit mentions that the function is now available from
> include/asm-generic/io.h, but this isn't included.

I've just fixed the media_build repository to handle this. Do a git pull and
it should compile again (only tested against kernel 3.18).

Regards,

	Hans

> Thanks,
> Luis
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: Recent commit introduces compiler Error in some platforms

[Luis de Bethencourt]

On Mon, Feb 16, 2015 at 01:36:43PM +0100, Hans Verkuil wrote:
> On 02/16/2015 01:18 PM, Luis de Bethencourt wrote:
> > Hi all,
> > 
> > As can be seen in Han's build log:
> > http://hverkuil.home.xs4all.nl/logs/Saturday.log
> > 
> > The recent commit bc0c5aa35ac88342831933ca7758ead62d9bae2b introduces a
> > compiler error in some platforms.
> > 
> > /home/hans/work/build/media_build/v4l/ir-hix5hd2.c: In function 'hix5hd2_ir_config':
> > /home/hans/work/build/media_build/v4l/ir-hix5hd2.c:95:2: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
> >   writel_relaxed(0x01, priv->base + IR_ENABLE);
> >   ^
> > 
> > Better than reverting, what would be a good solution for this problem?
> > I am happy to implment it once I know what is the right direction.
> > 
> > From what I see that commit mentions that the function is now available from
> > include/asm-generic/io.h, but this isn't included.
> 
> I've just fixed the media_build repository to handle this. Do a git pull and
> it should compile again (only tested against kernel 3.18).
> 
> Regards,
> 
> 	Hans
> 

Great! Nice to know this is already fixed.

Thanks,
Luis

> > Thanks,
> > Luis
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
>