From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Ondrej Kozina <okozina@redhat.com>,
dm-devel@redhat.com, "Alasdair G. Kergon" <agk@redhat.com>,
Milan Broz <mbroz@redhat.com>
Subject: Re: [PATCH 6/7] dm-crypt: make it possible to disable offload to thread
Date: Mon, 16 Feb 2015 09:08:48 -0500 [thread overview]
Message-ID: <20150216140848.GA20303@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1502130826050.6449@file01.intranet.prod.int.rdu2.redhat.com>
On Fri, Feb 13 2015 at 8:27am -0500,
Mikulas Patocka <mpatocka@redhat.com> wrote:
> There are some situation where offloading bios to a thread degrades
> performance twice, so we make an option to disable this feature. The
> feature can be disabled by passing performance_no_offload as an optional
> table argument performance_no_offload.
>
> We increase target version to 14 so that userspace can be aware of this
> feature.
>
> The default is to offload bios because for CFQ it is benefical to do so.
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
I changed the option to 'submit_writes_from_encrypt_threads', see:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-for-3.20&id=70a296ba4bfff0355fd57d29ad607ad79590635d
I'm open to other names for this option but felt your original
'performance_no_offload' was too opaque to users.
prev parent reply other threads:[~2015-02-16 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 13:27 [PATCH 6/7] dm-crypt: make it possible to disable offload to thread Mikulas Patocka
2015-02-16 14:08 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216140848.GA20303@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mbroz@redhat.com \
--cc=mpatocka@redhat.com \
--cc=okozina@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.