From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] pm: at91: pm_suspend: add the WFI instruction support for ARMv7
Date: Tue, 17 Feb 2015 11:22:55 +0100 [thread overview]
Message-ID: <20150217102255.GB11529@piout.net> (raw)
In-Reply-To: <1423709486-8382-1-git-send-email-wenyou.yang@atmel.com>
On 12/02/2015 at 10:51:26 +0800, Wenyou Yang wrote :
> Add the WFI instruction to make the cpu to the idle state.
> In the meanwhile, disable the processor's clock.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/mach-at91/pm_suspend.S | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index bebe3de..1c7256a 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -51,6 +51,24 @@ tmp2 .req r5
> beq 1b
> .endm
>
> +/*
> + * Put the processor to enter the idle state
> + */
> + .macro at91_cpu_idle
> +
> +#if defined(CONFIG_CPU_V7)
> + mov tmp1, #AT91_PMC_PCK
> + str tmp1, [pmc, #AT91_PMC_SCDR]
> +
> + dsb
> +
> + wfi @ Wait For Interrupt
> +#else
> + mcr p15, 0, tmp1, c7, c0, 4
> +#endif
> +
> + .endm
> +
> .text
>
> /*
> @@ -120,7 +138,7 @@ skip_disable_main_clock:
> ldr pmc, .pmc_base
>
> /* Wait for interrupt */
> - mcr p15, 0, tmp1, c7, c0, 4
> + at91_cpu_idle
>
> ldr r0, .pm_mode
> tst r0, #AT91_PM_SLOW_CLOCK
> --
> 1.7.9.5
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: nicolas.ferre@atmel.com, linux@maxim.org.za,
linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, sylvain.rochet@finsecur.com,
patrice.vilchez@atmel.com, sergei.shtylyov@cogentembedded.com,
mark.rutland@arm.com, lorenzo.pieralisi@arm.com
Subject: Re: [PATCH 1/3] pm: at91: pm_suspend: add the WFI instruction support for ARMv7
Date: Tue, 17 Feb 2015 11:22:55 +0100 [thread overview]
Message-ID: <20150217102255.GB11529@piout.net> (raw)
In-Reply-To: <1423709486-8382-1-git-send-email-wenyou.yang@atmel.com>
On 12/02/2015 at 10:51:26 +0800, Wenyou Yang wrote :
> Add the WFI instruction to make the cpu to the idle state.
> In the meanwhile, disable the processor's clock.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/mach-at91/pm_suspend.S | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index bebe3de..1c7256a 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -51,6 +51,24 @@ tmp2 .req r5
> beq 1b
> .endm
>
> +/*
> + * Put the processor to enter the idle state
> + */
> + .macro at91_cpu_idle
> +
> +#if defined(CONFIG_CPU_V7)
> + mov tmp1, #AT91_PMC_PCK
> + str tmp1, [pmc, #AT91_PMC_SCDR]
> +
> + dsb
> +
> + wfi @ Wait For Interrupt
> +#else
> + mcr p15, 0, tmp1, c7, c0, 4
> +#endif
> +
> + .endm
> +
> .text
>
> /*
> @@ -120,7 +138,7 @@ skip_disable_main_clock:
> ldr pmc, .pmc_base
>
> /* Wait for interrupt */
> - mcr p15, 0, tmp1, c7, c0, 4
> + at91_cpu_idle
>
> ldr r0, .pm_mode
> tst r0, #AT91_PM_SLOW_CLOCK
> --
> 1.7.9.5
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-02-17 10:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 2:50 [PATCH 0/3] AT91 pm fixes for 3.21 Wenyou Yang
2015-02-12 2:50 ` Wenyou Yang
2015-02-12 2:51 ` [PATCH 1/3] pm: at91: pm_suspend: add the WFI instruction support for ARMv7 Wenyou Yang
2015-02-12 2:51 ` Wenyou Yang
2015-02-17 10:22 ` Alexandre Belloni [this message]
2015-02-17 10:22 ` Alexandre Belloni
2015-02-12 2:52 ` [PATCH 2/3] pm: at91: pm_suspend: MOR register KEY was missing Wenyou Yang
2015-02-12 2:52 ` Wenyou Yang
2015-02-17 10:24 ` Alexandre Belloni
2015-02-17 10:24 ` Alexandre Belloni
2015-02-12 2:52 ` [PATCH 3/3] pm: at91: flush data cache and clean, invalidate and disable the L2 cache Wenyou Yang
2015-02-12 2:52 ` Wenyou Yang
2015-02-17 10:25 ` Alexandre Belloni
2015-02-17 10:25 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150217102255.GB11529@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.