All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 6/6] ARM: shmobile: ape6evm dts: Drop console= bootargs parameter
Date: Tue, 17 Feb 2015 15:16:08 +0000	[thread overview]
Message-ID: <20150217151608.GN8994@leverpostej> (raw)
In-Reply-To: <1424185486-3017-7-git-send-email-geert+renesas@glider.be>

On Tue, Feb 17, 2015 at 03:04:46PM +0000, Geert Uytterhoeven wrote:
> Since ("ARM: shmobile: r8a73a4: ape6evm: Remove legacy platform"),
> ape6evm is restricted to booting from DT, so chosen/stdout-path is
> always used, and we can drop the "console=" parameter from
> chosen/bootargs.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v4:
>   - New.
> ---
>  arch/arm/boot/dts/r8a73a4-ape6evm.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> index 44c4cac1820a4dfe..f9e81512201a2ec4 100644
> --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> @@ -22,7 +22,7 @@
>  	};
>  
>  	chosen {
> -		bootargs = "console=ttySC0,115200 ignore_loglevel root=/dev/nfs ip=dhcp rw";
> +		bootargs = "ignore_loglevel root=/dev/nfs ip=dhcp rw";
>  		stdout-path = &scifa0;

I'd strongly recommend that you also pass the configuration explicitly
here, so as to avoid nasty surprises. For that you can either use a path
or an alias, depending on what the rest of your DT looks like:

	stdout-path = "/path/to/scifa0:115200n8"

	stdout-path = "serial0:115200n8"

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/6] ARM: shmobile: ape6evm dts: Drop console= bootargs parameter
Date: Tue, 17 Feb 2015 15:16:08 +0000	[thread overview]
Message-ID: <20150217151608.GN8994@leverpostej> (raw)
In-Reply-To: <1424185486-3017-7-git-send-email-geert+renesas@glider.be>

On Tue, Feb 17, 2015 at 03:04:46PM +0000, Geert Uytterhoeven wrote:
> Since ("ARM: shmobile: r8a73a4: ape6evm: Remove legacy platform"),
> ape6evm is restricted to booting from DT, so chosen/stdout-path is
> always used, and we can drop the "console=" parameter from
> chosen/bootargs.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v4:
>   - New.
> ---
>  arch/arm/boot/dts/r8a73a4-ape6evm.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> index 44c4cac1820a4dfe..f9e81512201a2ec4 100644
> --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> @@ -22,7 +22,7 @@
>  	};
>  
>  	chosen {
> -		bootargs = "console=ttySC0,115200 ignore_loglevel root=/dev/nfs ip=dhcp rw";
> +		bootargs = "ignore_loglevel root=/dev/nfs ip=dhcp rw";
>  		stdout-path = &scifa0;

I'd strongly recommend that you also pass the configuration explicitly
here, so as to avoid nasty surprises. For that you can either use a path
or an alias, depending on what the rest of your DT looks like:

	stdout-path = "/path/to/scifa0:115200n8"

	stdout-path = "serial0:115200n8"

Thanks,
Mark.

  reply	other threads:[~2015-02-17 15:16 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17 15:04 [PATCH v4 0/6] ARM: shmobile: r8a73a4/ape6evm: Complete multiplatform support Geert Uytterhoeven
2015-02-17 15:04 ` Geert Uytterhoeven
2015-02-17 15:04 ` [PATCH v4 1/6] ARM: shmobile: r8a73a4 dtsi: Add Bus State Controller node Geert Uytterhoeven
2015-02-17 15:04   ` Geert Uytterhoeven
2015-02-17 15:04 ` [PATCH v4 2/6] ARM: shmobile: ape6evm dts: Move Ethernet node to BSC Geert Uytterhoeven
2015-02-17 15:04   ` Geert Uytterhoeven
2015-02-17 15:04 ` [PATCH v4 3/6] ARM: shmobile: r8a73a4: Move pfc node to work around probe ordering bug Geert Uytterhoeven
2015-02-17 15:04   ` Geert Uytterhoeven
2015-02-17 15:04 ` [PATCH v4 4/6] ARM: shmobile: ape6evm-reference: Remove board C code and DT file Geert Uytterhoeven
2015-02-17 15:04   ` Geert Uytterhoeven
2015-02-17 15:04 ` [PATCH v4 5/6] ARM: shmobile: r8a73a4: ape6evm: Remove legacy platform Geert Uytterhoeven
2015-02-17 15:04   ` Geert Uytterhoeven
2015-02-17 15:04 ` [PATCH v4 6/6] ARM: shmobile: ape6evm dts: Drop console= bootargs parameter Geert Uytterhoeven
2015-02-17 15:04   ` Geert Uytterhoeven
2015-02-17 15:16   ` Mark Rutland [this message]
2015-02-17 15:16     ` Mark Rutland
2015-02-18 21:20 ` [PATCH v4 0/6] ARM: shmobile: r8a73a4/ape6evm: Complete multiplatform support Simon Horman
2015-02-18 21:20   ` Simon Horman
2015-02-19 17:44   ` Geert Uytterhoeven
2015-02-19 17:44     ` Geert Uytterhoeven
2015-02-19 17:59     ` Simon Horman
2015-02-19 17:59       ` Simon Horman
2015-02-19 17:59     ` Geert Uytterhoeven
2015-02-19 17:59       ` Geert Uytterhoeven
2015-02-19 18:05       ` Simon Horman
2015-02-19 18:05         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150217151608.GN8994@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.