[PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Aya Mahfouz]

This patch fixes the following checkpatch.pl warning:

Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
__aligned(2)

The changes were applied using the following coccinelle
rule: 
@@ expression e1, e2; @@
- memcpy(e1, e2, ETH_ALEN);
+ ether_addr_copy(e1, e2); 

All variables defined in vnt_mac_set_key start at even offsets
making the variables aligned to the u16 datatype.

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
---
 drivers/staging/vt6656/mac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
index bb37e33..5958ecf 100644
--- a/drivers/staging/vt6656/mac.c
+++ b/drivers/staging/vt6656/mac.c
@@ -126,7 +126,7 @@ void vnt_mac_set_keyentry(struct vnt_private *priv, u16 key_ctl, u32 entry_idx,
 	offset += (entry_idx * MISCFIFO_KEYENTRYSIZE);
 
 	set_key.u.write.key_ctl = cpu_to_le16(key_ctl);
-	memcpy(set_key.u.write.addr, addr, ETH_ALEN);
+	ether_addr_copy(set_key.u.write.addr, addr);
 
 	/* swap over swap[0] and swap[1] to get correct write order */
 	swap(set_key.u.swap[0], set_key.u.swap[1]);
-- 
1.9.3

[PATCH] Staging: vt6656: replace memcpy by ether_addr_copy

[Yeliz Taneroglu]

This patch fixes the following checkpatch.pl warning:

Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
__aligned(2)

Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
---
 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 2fbff90..27a1f98 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -319,7 +319,7 @@ static int vnt_init_registers(struct vnt_private *priv)
 
 	/* get permanent network address */
 	memcpy(priv->permanent_net_addr, init_rsp->net_addr, 6);
-	memcpy(priv->current_net_addr, priv->permanent_net_addr, ETH_ALEN);
+	ether_addr_copy(priv->current_net_addr, priv->permanent_net_addr);
 
 	/* if exist SW network address, use it */
 	dev_dbg(&priv->usb->dev, "Network address = %pM\n",
-- 
1.8.3.2

Re: [Outreachy kernel] [PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Greg KH]

On Tue, Feb 17, 2015 at 10:00:55PM +0200, Aya Mahfouz wrote:
> This patch fixes the following checkpatch.pl warning:
> 
> Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
> __aligned(2)
> 
> The changes were applied using the following coccinelle
> rule: 
> @@ expression e1, e2; @@
> - memcpy(e1, e2, ETH_ALEN);
> + ether_addr_copy(e1, e2); 
> 
> All variables defined in vnt_mac_set_key start at even offsets
> making the variables aligned to the u16 datatype.
> 
> Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> ---
>  drivers/staging/vt6656/mac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
> index bb37e33..5958ecf 100644
> --- a/drivers/staging/vt6656/mac.c
> +++ b/drivers/staging/vt6656/mac.c
> @@ -126,7 +126,7 @@ void vnt_mac_set_keyentry(struct vnt_private *priv, u16 key_ctl, u32 entry_idx,
>  	offset += (entry_idx * MISCFIFO_KEYENTRYSIZE);
>  
>  	set_key.u.write.key_ctl = cpu_to_le16(key_ctl);
> -	memcpy(set_key.u.write.addr, addr, ETH_ALEN);
> +	ether_addr_copy(set_key.u.write.addr, addr);
>  
>  	/* swap over swap[0] and swap[1] to get correct write order */
>  	swap(set_key.u.swap[0], set_key.u.swap[1]);

This patch breaks the build, please _always_ test build your patches :(

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Aya Mahfouz]

On Thu, Feb 26, 2015 at 10:28:27AM -0800, Greg KH wrote:
> On Tue, Feb 17, 2015 at 10:00:55PM +0200, Aya Mahfouz wrote:
> > This patch fixes the following checkpatch.pl warning:
> > 
> > Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
> > __aligned(2)
> > 
> > The changes were applied using the following coccinelle
> > rule: 
> > @@ expression e1, e2; @@
> > - memcpy(e1, e2, ETH_ALEN);
> > + ether_addr_copy(e1, e2); 
> > 
> > All variables defined in vnt_mac_set_key start at even offsets
> > making the variables aligned to the u16 datatype.
> > 
> > Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> > ---
> >  drivers/staging/vt6656/mac.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
> > index bb37e33..5958ecf 100644
> > --- a/drivers/staging/vt6656/mac.c
> > +++ b/drivers/staging/vt6656/mac.c
> > @@ -126,7 +126,7 @@ void vnt_mac_set_keyentry(struct vnt_private *priv, u16 key_ctl, u32 entry_idx,
> >  	offset += (entry_idx * MISCFIFO_KEYENTRYSIZE);
> >  
> >  	set_key.u.write.key_ctl = cpu_to_le16(key_ctl);
> > -	memcpy(set_key.u.write.addr, addr, ETH_ALEN);
> > +	ether_addr_copy(set_key.u.write.addr, addr);
> >  
> >  	/* swap over swap[0] and swap[1] to get correct write order */
> >  	swap(set_key.u.swap[0], set_key.u.swap[1]);
> 
> This patch breaks the build, please _always_ test build your patches :(
> 
> thanks,
> 
> greg k-h

Hello Greg,

I always do and I didn't get any warnings or erros when building it
before sending. If you have the time, please let me know what is the
error. 

It also seems to be that you compile all warnings as errors, it would be
kind of you if you let me know your build settings.

 
-- 
Kind Regards,
Aya Saif El-yazal Mahfouz

Re: [Outreachy kernel] [PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Julia Lawall]

On Thu, 26 Feb 2015, Aya Mahfouz wrote:

> On Thu, Feb 26, 2015 at 10:28:27AM -0800, Greg KH wrote:
> > On Tue, Feb 17, 2015 at 10:00:55PM +0200, Aya Mahfouz wrote:
> > > This patch fixes the following checkpatch.pl warning:
> > >
> > > Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
> > > __aligned(2)
> > >
> > > The changes were applied using the following coccinelle
> > > rule:
> > > @@ expression e1, e2; @@
> > > - memcpy(e1, e2, ETH_ALEN);
> > > + ether_addr_copy(e1, e2);
> > >
> > > All variables defined in vnt_mac_set_key start at even offsets
> > > making the variables aligned to the u16 datatype.
> > >
> > > Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> > > ---
> > >  drivers/staging/vt6656/mac.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
> > > index bb37e33..5958ecf 100644
> > > --- a/drivers/staging/vt6656/mac.c
> > > +++ b/drivers/staging/vt6656/mac.c
> > > @@ -126,7 +126,7 @@ void vnt_mac_set_keyentry(struct vnt_private *priv, u16 key_ctl, u32 entry_idx,
> > >  	offset += (entry_idx * MISCFIFO_KEYENTRYSIZE);
> > >
> > >  	set_key.u.write.key_ctl = cpu_to_le16(key_ctl);
> > > -	memcpy(set_key.u.write.addr, addr, ETH_ALEN);
> > > +	ether_addr_copy(set_key.u.write.addr, addr);
> > >
> > >  	/* swap over swap[0] and swap[1] to get correct write order */
> > >  	swap(set_key.u.swap[0], set_key.u.swap[1]);
> >
> > This patch breaks the build, please _always_ test build your patches :(
> >
> > thanks,
> >
> > greg k-h
>
> Hello Greg,
>
> I always do and I didn't get any warnings or erros when building it
> before sending. If you have the time, please let me know what is the
> error.
>
> It also seems to be that you compile all warnings as errors, it would be
> kind of you if you let me know your build settings.

Are you sure that you have a .o file for this file?

julia

Re: [Outreachy kernel] [PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Aya Mahfouz]

On Thu, Feb 26, 2015 at 09:35:08PM +0100, Julia Lawall wrote:
> On Thu, 26 Feb 2015, Aya Mahfouz wrote:
> 
> > On Thu, Feb 26, 2015 at 10:28:27AM -0800, Greg KH wrote:
> > > On Tue, Feb 17, 2015 at 10:00:55PM +0200, Aya Mahfouz wrote:
> > > > This patch fixes the following checkpatch.pl warning:
> > > >
> > > > Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
> > > > __aligned(2)
> > > >
> > > > The changes were applied using the following coccinelle
> > > > rule:
> > > > @@ expression e1, e2; @@
> > > > - memcpy(e1, e2, ETH_ALEN);
> > > > + ether_addr_copy(e1, e2);
> > > >
> > > > All variables defined in vnt_mac_set_key start at even offsets
> > > > making the variables aligned to the u16 datatype.
> > > >
> > > > Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> > > > ---
> > > >  drivers/staging/vt6656/mac.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
> > > > index bb37e33..5958ecf 100644
> > > > --- a/drivers/staging/vt6656/mac.c
> > > > +++ b/drivers/staging/vt6656/mac.c
> > > > @@ -126,7 +126,7 @@ void vnt_mac_set_keyentry(struct vnt_private *priv, u16 key_ctl, u32 entry_idx,
> > > >  	offset += (entry_idx * MISCFIFO_KEYENTRYSIZE);
> > > >
> > > >  	set_key.u.write.key_ctl = cpu_to_le16(key_ctl);
> > > > -	memcpy(set_key.u.write.addr, addr, ETH_ALEN);
> > > > +	ether_addr_copy(set_key.u.write.addr, addr);
> > > >
> > > >  	/* swap over swap[0] and swap[1] to get correct write order */
> > > >  	swap(set_key.u.swap[0], set_key.u.swap[1]);
> > >
> > > This patch breaks the build, please _always_ test build your patches :(
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Hello Greg,
> >
> > I always do and I didn't get any warnings or erros when building it
> > before sending. If you have the time, please let me know what is the
> > error.
> >
> > It also seems to be that you compile all warnings as errors, it would be
> > kind of you if you let me know your build settings.
> 
> Are you sure that you have a .o file for this file?
> 
> julia

I'm rebuilding the kernel now. I will let you know once I'm done.

-- 
Kind Regards,
Aya Saif El-yazal Mahfouz

Re: [Outreachy kernel] [PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Greg KH]

On Thu, Feb 26, 2015 at 10:32:44PM +0200, Aya Mahfouz wrote:
> On Thu, Feb 26, 2015 at 10:28:27AM -0800, Greg KH wrote:
> > On Tue, Feb 17, 2015 at 10:00:55PM +0200, Aya Mahfouz wrote:
> > > This patch fixes the following checkpatch.pl warning:
> > > 
> > > Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
> > > __aligned(2)
> > > 
> > > The changes were applied using the following coccinelle
> > > rule: 
> > > @@ expression e1, e2; @@
> > > - memcpy(e1, e2, ETH_ALEN);
> > > + ether_addr_copy(e1, e2); 
> > > 
> > > All variables defined in vnt_mac_set_key start at even offsets
> > > making the variables aligned to the u16 datatype.
> > > 
> > > Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> > > ---
> > >  drivers/staging/vt6656/mac.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
> > > index bb37e33..5958ecf 100644
> > > --- a/drivers/staging/vt6656/mac.c
> > > +++ b/drivers/staging/vt6656/mac.c
> > > @@ -126,7 +126,7 @@ void vnt_mac_set_keyentry(struct vnt_private *priv, u16 key_ctl, u32 entry_idx,
> > >  	offset += (entry_idx * MISCFIFO_KEYENTRYSIZE);
> > >  
> > >  	set_key.u.write.key_ctl = cpu_to_le16(key_ctl);
> > > -	memcpy(set_key.u.write.addr, addr, ETH_ALEN);
> > > +	ether_addr_copy(set_key.u.write.addr, addr);
> > >  
> > >  	/* swap over swap[0] and swap[1] to get correct write order */
> > >  	swap(set_key.u.swap[0], set_key.u.swap[1]);
> > 
> > This patch breaks the build, please _always_ test build your patches :(
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hello Greg,
> 
> I always do and I didn't get any warnings or erros when building it
> before sending. If you have the time, please let me know what is the
> error. 

The compiler does not know what ether_addr_copy() is.

> It also seems to be that you compile all warnings as errors, it would be
> kind of you if you let me know your build settings.

I am building a "normal" x86-64 kernel with this driver enabled.  And
no, I am not treating warnings as errors, but your patches should never
be adding build warnings, that is not allowed either.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Aya Mahfouz]

On Thu, Feb 26, 2015 at 12:59:30PM -0800, Greg KH wrote:
> On Thu, Feb 26, 2015 at 10:32:44PM +0200, Aya Mahfouz wrote:
> > On Thu, Feb 26, 2015 at 10:28:27AM -0800, Greg KH wrote:
> > > On Tue, Feb 17, 2015 at 10:00:55PM +0200, Aya Mahfouz wrote:
> > > > This patch fixes the following checkpatch.pl warning:
> > > > 
> > > > Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
> > > > __aligned(2)
> > > > 
> > > > The changes were applied using the following coccinelle
> > > > rule: 
> > > > @@ expression e1, e2; @@
> > > > - memcpy(e1, e2, ETH_ALEN);
> > > > + ether_addr_copy(e1, e2); 
> > > > 
> > > > All variables defined in vnt_mac_set_key start at even offsets
> > > > making the variables aligned to the u16 datatype.
> > > > 
> > > > Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> > > > ---
> > > >  drivers/staging/vt6656/mac.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
> > > > index bb37e33..5958ecf 100644
> > > > --- a/drivers/staging/vt6656/mac.c
> > > > +++ b/drivers/staging/vt6656/mac.c
> > > > @@ -126,7 +126,7 @@ void vnt_mac_set_keyentry(struct vnt_private *priv, u16 key_ctl, u32 entry_idx,
> > > >  	offset += (entry_idx * MISCFIFO_KEYENTRYSIZE);
> > > >  
> > > >  	set_key.u.write.key_ctl = cpu_to_le16(key_ctl);
> > > > -	memcpy(set_key.u.write.addr, addr, ETH_ALEN);
> > > > +	ether_addr_copy(set_key.u.write.addr, addr);
> > > >  
> > > >  	/* swap over swap[0] and swap[1] to get correct write order */
> > > >  	swap(set_key.u.swap[0], set_key.u.swap[1]);
> > > 
> > > This patch breaks the build, please _always_ test build your patches :(
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > Hello Greg,
> > 
> > I always do and I didn't get any warnings or erros when building it
> > before sending. If you have the time, please let me know what is the
> > error. 
> 
> The compiler does not know what ether_addr_copy() is.
> 
> > It also seems to be that you compile all warnings as errors, it would be
> > kind of you if you let me know your build settings.
> 
> I am building a "normal" x86-64 kernel with this driver enabled.  And
> no, I am not treating warnings as errors, but your patches should never
> be adding build warnings, that is not allowed either.
>

Yes, concerning warnings, you told me that before. It seems to me that
I'm compiling the modules in a wrong way. I usually use one of the
following commands, if compiling a module:

make -C $pwd SUBDIRS=drivers/staging/xxx modules
make M=drivers/staging/xxx

The .o files were generated only after I broke the whole kernel build,
otherwise nothing is generated.

Any remedies?

> thanks,
> 
> greg k-h

-- 
Kind Regards,
Aya Saif El-yazal Mahfouz

Re: [Outreachy kernel] [PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Greg KH]

On Fri, Feb 27, 2015 at 03:32:51AM +0200, Aya Mahfouz wrote:
> On Thu, Feb 26, 2015 at 12:59:30PM -0800, Greg KH wrote:
> > On Thu, Feb 26, 2015 at 10:32:44PM +0200, Aya Mahfouz wrote:
> > > On Thu, Feb 26, 2015 at 10:28:27AM -0800, Greg KH wrote:
> > > > On Tue, Feb 17, 2015 at 10:00:55PM +0200, Aya Mahfouz wrote:
> > > > > This patch fixes the following checkpatch.pl warning:
> > > > > 
> > > > > Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
> > > > > __aligned(2)
> > > > > 
> > > > > The changes were applied using the following coccinelle
> > > > > rule: 
> > > > > @@ expression e1, e2; @@
> > > > > - memcpy(e1, e2, ETH_ALEN);
> > > > > + ether_addr_copy(e1, e2); 
> > > > > 
> > > > > All variables defined in vnt_mac_set_key start at even offsets
> > > > > making the variables aligned to the u16 datatype.
> > > > > 
> > > > > Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> > > > > ---
> > > > >  drivers/staging/vt6656/mac.c | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
> > > > > index bb37e33..5958ecf 100644
> > > > > --- a/drivers/staging/vt6656/mac.c
> > > > > +++ b/drivers/staging/vt6656/mac.c
> > > > > @@ -126,7 +126,7 @@ void vnt_mac_set_keyentry(struct vnt_private *priv, u16 key_ctl, u32 entry_idx,
> > > > >  	offset += (entry_idx * MISCFIFO_KEYENTRYSIZE);
> > > > >  
> > > > >  	set_key.u.write.key_ctl = cpu_to_le16(key_ctl);
> > > > > -	memcpy(set_key.u.write.addr, addr, ETH_ALEN);
> > > > > +	ether_addr_copy(set_key.u.write.addr, addr);
> > > > >  
> > > > >  	/* swap over swap[0] and swap[1] to get correct write order */
> > > > >  	swap(set_key.u.swap[0], set_key.u.swap[1]);
> > > > 
> > > > This patch breaks the build, please _always_ test build your patches :(
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > 
> > > Hello Greg,
> > > 
> > > I always do and I didn't get any warnings or erros when building it
> > > before sending. If you have the time, please let me know what is the
> > > error. 
> > 
> > The compiler does not know what ether_addr_copy() is.
> > 
> > > It also seems to be that you compile all warnings as errors, it would be
> > > kind of you if you let me know your build settings.
> > 
> > I am building a "normal" x86-64 kernel with this driver enabled.  And
> > no, I am not treating warnings as errors, but your patches should never
> > be adding build warnings, that is not allowed either.
> >
> 
> Yes, concerning warnings, you told me that before. It seems to me that
> I'm compiling the modules in a wrong way. I usually use one of the
> following commands, if compiling a module:
> 
> make -C $pwd SUBDIRS=drivers/staging/xxx modules
> make M=drivers/staging/xxx

Both of those should work.

> The .o files were generated only after I broke the whole kernel build,
> otherwise nothing is generated.
> 
> Any remedies?

I don't understand, what exactly was the errors?

It's usually just easiest to build the whole tree, you can do it quicker
by doing:
	make -j16

replace the number with 2x the number of cpus you have, and you should
be fine.

good luck,

greg k-h

Re: [Outreachy kernel] [PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Aya Mahfouz]

On Thu, Feb 26, 2015 at 05:55:12PM -0800, Greg KH wrote:
> On Fri, Feb 27, 2015 at 03:32:51AM +0200, Aya Mahfouz wrote:
> > On Thu, Feb 26, 2015 at 12:59:30PM -0800, Greg KH wrote:
> > > On Thu, Feb 26, 2015 at 10:32:44PM +0200, Aya Mahfouz wrote:
> > > > On Thu, Feb 26, 2015 at 10:28:27AM -0800, Greg KH wrote:
> > > > > On Tue, Feb 17, 2015 at 10:00:55PM +0200, Aya Mahfouz wrote:
> > > > > > This patch fixes the following checkpatch.pl warning:
> > > > > > 
> > > > > > Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
> > > > > > __aligned(2)
> > > > > > 
> > > > > > The changes were applied using the following coccinelle
> > > > > > rule: 
> > > > > > @@ expression e1, e2; @@
> > > > > > - memcpy(e1, e2, ETH_ALEN);
> > > > > > + ether_addr_copy(e1, e2); 
> > > > > > 
> > > > > > All variables defined in vnt_mac_set_key start at even offsets
> > > > > > making the variables aligned to the u16 datatype.
> > > > > > 
> > > > > > Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> > > > > > ---
> > > > > >  drivers/staging/vt6656/mac.c | 2 +-
> > > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > > 
> > > > > > diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
> > > > > > index bb37e33..5958ecf 100644
> > > > > > --- a/drivers/staging/vt6656/mac.c
> > > > > > +++ b/drivers/staging/vt6656/mac.c
> > > > > > @@ -126,7 +126,7 @@ void vnt_mac_set_keyentry(struct vnt_private *priv, u16 key_ctl, u32 entry_idx,
> > > > > >  	offset += (entry_idx * MISCFIFO_KEYENTRYSIZE);
> > > > > >  
> > > > > >  	set_key.u.write.key_ctl = cpu_to_le16(key_ctl);
> > > > > > -	memcpy(set_key.u.write.addr, addr, ETH_ALEN);
> > > > > > +	ether_addr_copy(set_key.u.write.addr, addr);
> > > > > >  
> > > > > >  	/* swap over swap[0] and swap[1] to get correct write order */
> > > > > >  	swap(set_key.u.swap[0], set_key.u.swap[1]);
> > > > > 
> > > > > This patch breaks the build, please _always_ test build your patches :(
> > > > > 
> > > > > thanks,
> > > > > 
> > > > > greg k-h
> > > > 
> > > > Hello Greg,
> > > > 
> > > > I always do and I didn't get any warnings or erros when building it
> > > > before sending. If you have the time, please let me know what is the
> > > > error. 
> > > 
> > > The compiler does not know what ether_addr_copy() is.
> > > 
> > > > It also seems to be that you compile all warnings as errors, it would be
> > > > kind of you if you let me know your build settings.
> > > 
> > > I am building a "normal" x86-64 kernel with this driver enabled.  And
> > > no, I am not treating warnings as errors, but your patches should never
> > > be adding build warnings, that is not allowed either.
> > >
> > 
> > Yes, concerning warnings, you told me that before. It seems to me that
> > I'm compiling the modules in a wrong way. I usually use one of the
> > following commands, if compiling a module:
> > 
> > make -C $pwd SUBDIRS=drivers/staging/xxx modules
> > make M=drivers/staging/xxx
> 
> Both of those should work.
> 
> > The .o files were generated only after I broke the whole kernel build,
> > otherwise nothing is generated.
> > 
> > Any remedies?
> 
> I don't understand, what exactly was the errors?
> 
> It's usually just easiest to build the whole tree, you can do it quicker
> by doing:
> 	make -j16
> 
> replace the number with 2x the number of cpus you have, and you should
> be fine.
> 
> good luck,
> 
> greg k-h

ok, Thanks!
-- 
Kind Regards,
Aya Saif El-yazal Mahfouz

Re: [Outreachy kernel] [PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Julia Lawall]

> > It's usually just easiest to build the whole tree, you can do it quicker
> > by doing:
> > 	make -j16
> >
> > replace the number with 2x the number of cpus you have, and you should
> > be fine.
> >
> > good luck,
> >
> > greg k-h
>
> ok, Thanks!

I guess that the problem would have been seen by just compiling make
foo/bar/file.o?

julia

Re: [Outreachy kernel] [PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Aya Mahfouz]

On Fri, Feb 27, 2015 at 06:45:35AM +0100, Julia Lawall wrote:
> > > It's usually just easiest to build the whole tree, you can do it quicker
> > > by doing:
> > > 	make -j16
> > >
> > > replace the number with 2x the number of cpus you have, and you should
> > > be fine.
> > >
> > > good luck,
> > >
> > > greg k-h
> >
> > ok, Thanks!
> 
> I guess that the problem would have been seen by just compiling make
> foo/bar/file.o?
> 
Yup! works for me and my poor old CPU :-D Thanks!
> julia

-- 
Kind Regards,
Aya Saif El-yazal Mahfouz

Re: [Outreachy kernel] [PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Arnd Bergmann]

On Friday 27 February 2015 07:53:49 Aya Mahfouz wrote:
> On Fri, Feb 27, 2015 at 06:45:35AM +0100, Julia Lawall wrote:
> > > > It's usually just easiest to build the whole tree, you can do it quicker
> > > > by doing:
> > > >   make -j16
> > > >
> > > > replace the number with 2x the number of cpus you have, and you should
> > > > be fine.
> > > >
> > > > good luck,
> > > >
> > > > greg k-h
> > >
> > > ok, Thanks!
> > 
> > I guess that the problem would have been seen by just compiling make
> > foo/bar/file.o?
> > 
> Yup! works for me and my poor old CPU  Thanks!

It's also what I normally do, or for the whole directory

make foo/bar/

which will build all files that are turned on in the configuration.
Using 'make foo/bar/file.o' will try to build that one file even
if it is disabled in the configuration, which may or may not be what
you want. The advantage is that you don't have to figure out how
to enable it, but the downside is that it may fail to build in your
current configuration because of some other configuration option
rather than something you did.

	Arnd

Re: [Outreachy kernel] [PATCH] staging: vt6656: replace memcpy by ether_addr_copy

[Aya Mahfouz]

On Fri, Feb 27, 2015 at 09:53:06AM +0100, Arnd Bergmann wrote:
> On Friday 27 February 2015 07:53:49 Aya Mahfouz wrote:
> > On Fri, Feb 27, 2015 at 06:45:35AM +0100, Julia Lawall wrote:
> > > > > It's usually just easiest to build the whole tree, you can do it quicker
> > > > > by doing:
> > > > >   make -j16
> > > > >
> > > > > replace the number with 2x the number of cpus you have, and you should
> > > > > be fine.
> > > > >
> > > > > good luck,
> > > > >
> > > > > greg k-h
> > > >
> > > > ok, Thanks!
> > > 
> > > I guess that the problem would have been seen by just compiling make
> > > foo/bar/file.o?
> > > 
> > Yup! works for me and my poor old CPU  Thanks!
> 
> It's also what I normally do, or for the whole directory
> 
> make foo/bar/
> 
> which will build all files that are turned on in the configuration.
> Using 'make foo/bar/file.o' will try to build that one file even
> if it is disabled in the configuration, which may or may not be what
> you want. The advantage is that you don't have to figure out how
> to enable it, but the downside is that it may fail to build in your
> current configuration because of some other configuration option
> rather than something you did.
>
Thanks Arnd! Yeah, I usually see that some symbols cannot be enabled
unless their dependencies are enabled too.
> 	Arnd

-- 
Kind Regards,
Aya Saif El-yazal Mahfouz