* [PATCH] drivers/vmw_vmci: Show correct get_user_pages_fast upon err
@ 2015-02-17 21:57 Davidlohr Bueso
2015-02-17 22:02 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Davidlohr Bueso @ 2015-02-17 21:57 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: dave, linux-kernel
As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast())
we no longer call get_user_pages(), thus update the warning.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
---
drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
index 35f19a6..1d80c56 100644
--- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
+++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
@@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
produce_q->kernel_if->num_pages, 1,
produce_q->kernel_if->u.h.header_page);
if (retval < produce_q->kernel_if->num_pages) {
- pr_warn("get_user_pages(produce) failed (retval=%d)", retval);
+ pr_warn("get_user_pages_fast(produce) failed (retval=%d)",
+ retval);
qp_release_pages(produce_q->kernel_if->u.h.header_page,
retval, false);
err = VMCI_ERROR_NO_MEM;
@@ -748,7 +749,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
consume_q->kernel_if->num_pages, 1,
consume_q->kernel_if->u.h.header_page);
if (retval < consume_q->kernel_if->num_pages) {
- pr_warn("get_user_pages(consume) failed (retval=%d)", retval);
+ pr_warn("get_user_pages_fast(consume) failed (retval=%d)",
+ retval);
qp_release_pages(consume_q->kernel_if->u.h.header_page,
retval, false);
qp_release_pages(produce_q->kernel_if->u.h.header_page,
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers/vmw_vmci: Show correct get_user_pages_fast upon err
2015-02-17 21:57 [PATCH] drivers/vmw_vmci: Show correct get_user_pages_fast upon err Davidlohr Bueso
@ 2015-02-17 22:02 ` Greg Kroah-Hartman
2015-02-17 22:09 ` Davidlohr Bueso
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-02-17 22:02 UTC (permalink / raw)
To: Davidlohr Bueso; +Cc: linux-kernel
On Tue, Feb 17, 2015 at 01:57:34PM -0800, Davidlohr Bueso wrote:
> As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast())
> we no longer call get_user_pages(), thus update the warning.
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> ---
> drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> index 35f19a6..1d80c56 100644
> --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
> +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> @@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
> produce_q->kernel_if->num_pages, 1,
> produce_q->kernel_if->u.h.header_page);
> if (retval < produce_q->kernel_if->num_pages) {
> - pr_warn("get_user_pages(produce) failed (retval=%d)", retval);
> + pr_warn("get_user_pages_fast(produce) failed (retval=%d)",
> + retval);
What can a user do with this message? Shouldn't it be a debug message?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers/vmw_vmci: Show correct get_user_pages_fast upon err
2015-02-17 22:02 ` Greg Kroah-Hartman
@ 2015-02-17 22:09 ` Davidlohr Bueso
2015-02-17 22:20 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Davidlohr Bueso @ 2015-02-17 22:09 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel
On Tue, 2015-02-17 at 14:02 -0800, Greg Kroah-Hartman wrote:
> On Tue, Feb 17, 2015 at 01:57:34PM -0800, Davidlohr Bueso wrote:
> > As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast())
> > we no longer call get_user_pages(), thus update the warning.
> >
> > Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> > ---
> > drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> > index 35f19a6..1d80c56 100644
> > --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
> > +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> > @@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
> > produce_q->kernel_if->num_pages, 1,
> > produce_q->kernel_if->u.h.header_page);
> > if (retval < produce_q->kernel_if->num_pages) {
> > - pr_warn("get_user_pages(produce) failed (retval=%d)", retval);
> > + pr_warn("get_user_pages_fast(produce) failed (retval=%d)",
> > + retval);
>
> What can a user do with this message? Shouldn't it be a debug message?
I was trying to be as least invasive as possible, as I zero knowledge of
this thingie. But yes, such a message does seem more appropriate as
pr_debug(). Do you want me to respin?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers/vmw_vmci: Show correct get_user_pages_fast upon err
2015-02-17 22:09 ` Davidlohr Bueso
@ 2015-02-17 22:20 ` Greg Kroah-Hartman
2015-02-17 22:29 ` [PATCH v2] drivers/vmw_vmci: Show correct get_user_pages_fast upon failure Davidlohr Bueso
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-02-17 22:20 UTC (permalink / raw)
To: Davidlohr Bueso; +Cc: linux-kernel
On Tue, Feb 17, 2015 at 02:09:19PM -0800, Davidlohr Bueso wrote:
> On Tue, 2015-02-17 at 14:02 -0800, Greg Kroah-Hartman wrote:
> > On Tue, Feb 17, 2015 at 01:57:34PM -0800, Davidlohr Bueso wrote:
> > > As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast())
> > > we no longer call get_user_pages(), thus update the warning.
> > >
> > > Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> > > ---
> > > drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++--
> > > 1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> > > index 35f19a6..1d80c56 100644
> > > --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
> > > +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> > > @@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
> > > produce_q->kernel_if->num_pages, 1,
> > > produce_q->kernel_if->u.h.header_page);
> > > if (retval < produce_q->kernel_if->num_pages) {
> > > - pr_warn("get_user_pages(produce) failed (retval=%d)", retval);
> > > + pr_warn("get_user_pages_fast(produce) failed (retval=%d)",
> > > + retval);
> >
> > What can a user do with this message? Shouldn't it be a debug message?
>
> I was trying to be as least invasive as possible, as I zero knowledge of
> this thingie. But yes, such a message does seem more appropriate as
> pr_debug(). Do you want me to respin?
Please do.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] drivers/vmw_vmci: Show correct get_user_pages_fast upon failure
2015-02-17 22:20 ` Greg Kroah-Hartman
@ 2015-02-17 22:29 ` Davidlohr Bueso
0 siblings, 0 replies; 5+ messages in thread
From: Davidlohr Bueso @ 2015-02-17 22:29 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel
As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast())
we no longer user get_user_pages(), thus update the warning.
Also convert to pr_debug, which is a more appropriate level of logging.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
---
drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
index 35f19a6..c384945 100644
--- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
+++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
@@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
produce_q->kernel_if->num_pages, 1,
produce_q->kernel_if->u.h.header_page);
if (retval < produce_q->kernel_if->num_pages) {
- pr_warn("get_user_pages(produce) failed (retval=%d)", retval);
+ pr_debug("get_user_pages_fast(produce) failed (retval=%d)",
+ retval);
qp_release_pages(produce_q->kernel_if->u.h.header_page,
retval, false);
err = VMCI_ERROR_NO_MEM;
@@ -748,7 +749,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
consume_q->kernel_if->num_pages, 1,
consume_q->kernel_if->u.h.header_page);
if (retval < consume_q->kernel_if->num_pages) {
- pr_warn("get_user_pages(consume) failed (retval=%d)", retval);
+ pr_debug("get_user_pages_fast(consume) failed (retval=%d)",
+ retval);
qp_release_pages(consume_q->kernel_if->u.h.header_page,
retval, false);
qp_release_pages(produce_q->kernel_if->u.h.header_page,
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-17 22:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-17 21:57 [PATCH] drivers/vmw_vmci: Show correct get_user_pages_fast upon err Davidlohr Bueso
2015-02-17 22:02 ` Greg Kroah-Hartman
2015-02-17 22:09 ` Davidlohr Bueso
2015-02-17 22:20 ` Greg Kroah-Hartman
2015-02-17 22:29 ` [PATCH v2] drivers/vmw_vmci: Show correct get_user_pages_fast upon failure Davidlohr Bueso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.