All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: i2o: fixed "foo* bar" should be "foo *bar" warning in debug.c
@ 2015-02-17 22:14 Vatika Harlalka
  2015-02-17 22:22 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 2+ messages in thread
From: Vatika Harlalka @ 2015-02-17 22:14 UTC (permalink / raw)
  To: outreachy-kernel

This patch fixes "foo* bar" should be "foo *bar" warning in debug.c.

Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
 drivers/staging/i2o/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/i2o/debug.c b/drivers/staging/i2o/debug.c
index 7a16114..4f23e3f 100644
--- a/drivers/staging/i2o/debug.c
+++ b/drivers/staging/i2o/debug.c
@@ -5,7 +5,7 @@
 
 static void i2o_report_util_cmd(u8 cmd);
 static void i2o_report_exec_cmd(u8 cmd);
-static void i2o_report_fail_status(u8 req_status, u32 * msg);
+static void i2o_report_fail_status(u8 req_status, u32 *msg);
 static void i2o_report_common_status(u8 req_status);
 static void i2o_report_common_dsc(u16 detailed_status);
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH] Staging: i2o: fixed "foo* bar" should be "foo *bar" warning in debug.c
  2015-02-17 22:14 [PATCH] Staging: i2o: fixed "foo* bar" should be "foo *bar" warning in debug.c Vatika Harlalka
@ 2015-02-17 22:22 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2015-02-17 22:22 UTC (permalink / raw)
  To: Vatika Harlalka; +Cc: outreachy-kernel

On Wed, 18 Feb 2015, Vatika Harlalka wrote:

> This patch fixes "foo* bar" should be "foo *bar" warning in debug.c.

This message could be something like "Remove space after the * in a 
pointer type variable declaration to follow kernel coding conventions."  
That would say what you did and why.

Normally, it is not necessary to mention the file name in the subject line 
or in the commit message.  One can easily see the affected file(s) by 
looking at the diffstat below the ---.

julia


> 
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
>  drivers/staging/i2o/debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/i2o/debug.c b/drivers/staging/i2o/debug.c
> index 7a16114..4f23e3f 100644
> --- a/drivers/staging/i2o/debug.c
> +++ b/drivers/staging/i2o/debug.c
> @@ -5,7 +5,7 @@
>  
>  static void i2o_report_util_cmd(u8 cmd);
>  static void i2o_report_exec_cmd(u8 cmd);
> -static void i2o_report_fail_status(u8 req_status, u32 * msg);
> +static void i2o_report_fail_status(u8 req_status, u32 *msg);
>  static void i2o_report_common_status(u8 req_status);
>  static void i2o_report_common_dsc(u16 detailed_status);
>  
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150217221432.GA4319%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-17 22:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-17 22:14 [PATCH] Staging: i2o: fixed "foo* bar" should be "foo *bar" warning in debug.c Vatika Harlalka
2015-02-17 22:22 ` [Outreachy kernel] " Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.