[PATCH v2] Staging: i2o: Remove space after the * in a pointer type variable.

[PATCH v2] Staging: i2o: Remove space after the * in a pointer type variable.

[Vatika Harlalka]

This patch is to remove space after the * in a pointer type variable declaration to follow kernel coding conventions.

Changes from v1: Changed subject line to make it more descriptive.

Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
 drivers/staging/i2o/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/i2o/debug.c b/drivers/staging/i2o/debug.c
index 7a16114..4f23e3f 100644
--- a/drivers/staging/i2o/debug.c
+++ b/drivers/staging/i2o/debug.c
@@ -5,7 +5,7 @@
 
 static void i2o_report_util_cmd(u8 cmd);
 static void i2o_report_exec_cmd(u8 cmd);
-static void i2o_report_fail_status(u8 req_status, u32 * msg);
+static void i2o_report_fail_status(u8 req_status, u32 *msg);
 static void i2o_report_common_status(u8 req_status);
 static void i2o_report_common_dsc(u16 detailed_status);
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v2] Staging: i2o: Remove space after the * in a pointer type variable.

[Julia Lawall]

On Wed, 18 Feb 2015, Vatika Harlalka wrote:

> This patch is to remove space after the * in a pointer type variable declaration to follow kernel coding conventions.
> 
> Changes from v1: Changed subject line to make it more descriptive.

The change description goes below the ---

When a patch is processed, the part above the --- is taken as the commit 
message and the part below the --- is applied as a patch to the code.  The 
patch command ignores anything that is not patch code, as determined by 
the --- +++ and @@ lines.  Between the --- and the diff, you can put 
information that does not need to be preserved in git.  The difference 
with the previous version falls into this category.  Since the v1 of your 
patch will not be presented in git, the difference between v2 and v1 is 
not useful.

So now you should submit v3 with the difference information in the right 
place.

julia

> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
>  drivers/staging/i2o/debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/i2o/debug.c b/drivers/staging/i2o/debug.c
> index 7a16114..4f23e3f 100644
> --- a/drivers/staging/i2o/debug.c
> +++ b/drivers/staging/i2o/debug.c
> @@ -5,7 +5,7 @@
>  
>  static void i2o_report_util_cmd(u8 cmd);
>  static void i2o_report_exec_cmd(u8 cmd);
> -static void i2o_report_fail_status(u8 req_status, u32 * msg);
> +static void i2o_report_fail_status(u8 req_status, u32 *msg);
>  static void i2o_report_common_status(u8 req_status);
>  static void i2o_report_common_dsc(u16 detailed_status);
>  
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150218074634.GA9707%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>