From: Parmeshwr Prasad <parmeshwr_prasad@dell.com>
To: pjones@redhat.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] Moved assignment out of if() statement in efifb.c
Date: Wed, 18 Feb 2015 08:36:57 +0000 [thread overview]
Message-ID: <20150218083654.GD9820@linuxteamdev.amer.dell.com> (raw)
This patch depend on my earlier patchs.
Moving assignment out of if() statement.
Signed-off-by: Parmeshwr Prasad <parmeshwr_prasad@dell.com>
---
drivers/video/fbdev/efifb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index cc1a156..9124ba9 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -275,11 +275,13 @@ static int efifb_probe(struct platform_device *dev)
info->fix = efifb_fix;
info->flags = FBINFO_FLAG_DEFAULT | FBINFO_MISC_FIRMWARE;
- if ((err = fb_alloc_cmap(&info->cmap, 256, 0)) < 0) {
+ err = fb_alloc_cmap(&info->cmap, 256, 0);
+ if (err < 0) {
pr_err("efifb: cannot allocate colormap\n");
goto err_unmap;
}
- if ((err = register_framebuffer(info)) < 0) {
+ err = register_framebuffer(info);
+ if (err < 0) {
pr_err("efifb: cannot register framebuffer\n");
goto err_fb_dealoc;
}
--
1.9.3
-Parmeshwr
WARNING: multiple messages have this Message-ID (diff)
From: Parmeshwr Prasad <parmeshwr_prasad@dell.com>
To: pjones@redhat.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] Moved assignment out of if() statement in efifb.c
Date: Wed, 18 Feb 2015 03:36:57 -0500 [thread overview]
Message-ID: <20150218083654.GD9820@linuxteamdev.amer.dell.com> (raw)
This patch depend on my earlier patchs.
Moving assignment out of if() statement.
Signed-off-by: Parmeshwr Prasad <parmeshwr_prasad@dell.com>
---
drivers/video/fbdev/efifb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index cc1a156..9124ba9 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -275,11 +275,13 @@ static int efifb_probe(struct platform_device *dev)
info->fix = efifb_fix;
info->flags = FBINFO_FLAG_DEFAULT | FBINFO_MISC_FIRMWARE;
- if ((err = fb_alloc_cmap(&info->cmap, 256, 0)) < 0) {
+ err = fb_alloc_cmap(&info->cmap, 256, 0);
+ if (err < 0) {
pr_err("efifb: cannot allocate colormap\n");
goto err_unmap;
}
- if ((err = register_framebuffer(info)) < 0) {
+ err = register_framebuffer(info);
+ if (err < 0) {
pr_err("efifb: cannot register framebuffer\n");
goto err_fb_dealoc;
}
--
1.9.3
-Parmeshwr
next reply other threads:[~2015-02-18 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 8:36 Parmeshwr Prasad [this message]
2015-02-18 8:36 ` [PATCH 3/3] Moved assignment out of if() statement in efifb.c Parmeshwr Prasad
-- strict thread matches above, loose matches on Subject: below --
2015-02-26 10:48 Parmeshwr Prasad
2015-02-26 10:48 ` Parmeshwr Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218083654.GD9820@linuxteamdev.amer.dell.com \
--to=parmeshwr_prasad@dell.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.